From e225db46e4ded40abf81c73cde190387ff7fe8b4 Mon Sep 17 00:00:00 2001 From: Spaceman1984 <49917670+Spaceman1984@users.noreply.github.com> Date: Wed, 29 Jul 2020 08:55:00 +0200 Subject: [PATCH] ca: Removed check on client mode (#4226) Fixes unit test failures due to behavior change in OpenJDK 11.0.8 JDK-8245077: Default SSLEngine Created in Server Role ===================================================== In JDK 11 and later, `javax.net.ssl.SSLEngine` by default used client mode when handshaking. As a result, the set of default enabled protocols may differ to what is expected. `SSLEngine` would usually be used in server mode. From this JDK release onwards, `SSLEngine` will default to server mode. The `javax.net.ssl.SSLEngine.setUseClientMode(boolean mode)` method may be used to configure the mode. --- .../org/apache/cloudstack/ca/provider/RootCAProviderTest.java | 2 -- 1 file changed, 2 deletions(-) diff --git a/plugins/ca/root-ca/src/test/java/org/apache/cloudstack/ca/provider/RootCAProviderTest.java b/plugins/ca/root-ca/src/test/java/org/apache/cloudstack/ca/provider/RootCAProviderTest.java index 305d18fe8c4..04aba36c8be 100644 --- a/plugins/ca/root-ca/src/test/java/org/apache/cloudstack/ca/provider/RootCAProviderTest.java +++ b/plugins/ca/root-ca/src/test/java/org/apache/cloudstack/ca/provider/RootCAProviderTest.java @@ -135,7 +135,6 @@ public class RootCAProviderTest { public void testCreateSSLEngineWithoutAuthStrictness() throws Exception { overrideDefaultConfigValue(RootCAProvider.rootCAAuthStrictness, "_defaultValue", "false"); final SSLEngine e = provider.createSSLEngine(SSLUtils.getSSLContext(), "/1.2.3.4:5678", null); - Assert.assertTrue(e.getUseClientMode()); Assert.assertFalse(e.getNeedClientAuth()); } @@ -143,7 +142,6 @@ public class RootCAProviderTest { public void testCreateSSLEngineWithAuthStrictness() throws Exception { overrideDefaultConfigValue(RootCAProvider.rootCAAuthStrictness, "_defaultValue", "true"); final SSLEngine e = provider.createSSLEngine(SSLUtils.getSSLContext(), "/1.2.3.4:5678", null); - Assert.assertTrue(e.getUseClientMode()); Assert.assertTrue(e.getNeedClientAuth()); }