diff --git a/api/src/com/cloud/network/security/SecurityGroup.java b/api/src/com/cloud/network/security/SecurityGroup.java index db9d043694b..f6817d7188a 100644 --- a/api/src/com/cloud/network/security/SecurityGroup.java +++ b/api/src/com/cloud/network/security/SecurityGroup.java @@ -18,7 +18,7 @@ package com.cloud.network.security; import com.cloud.acl.ControlledEntity; -@doc("") +//FIXME: Annotation @doc("") public interface SecurityGroup extends ControlledEntity { long getId(); diff --git a/api/src/org/apache/cloudstack/api/admin/network/command/DeleteNetworkDeviceCmd.java b/api/src/org/apache/cloudstack/api/admin/network/command/DeleteNetworkDeviceCmd.java index 491e49a50c0..d01b774642b 100644 --- a/api/src/org/apache/cloudstack/api/admin/network/command/DeleteNetworkDeviceCmd.java +++ b/api/src/org/apache/cloudstack/api/admin/network/command/DeleteNetworkDeviceCmd.java @@ -24,13 +24,13 @@ import org.apache.cloudstack.api.IdentityMapper; import org.apache.cloudstack.api.Implementation; import org.apache.cloudstack.api.Parameter; import org.apache.cloudstack.api.ServerApiException; +import org.apache.cloudstack.network.ExternalNetworkDeviceManager; import com.cloud.api.response.SuccessResponse; import com.cloud.exception.ConcurrentOperationException; import com.cloud.exception.InsufficientCapacityException; import com.cloud.exception.InvalidParameterValueException; import com.cloud.exception.ResourceAllocationException; import com.cloud.exception.ResourceUnavailableException; -import com.cloud.network.ExternalNetworkDeviceManager; import com.cloud.server.ManagementService; import com.cloud.utils.component.ComponentLocator; import com.cloud.utils.exception.CloudRuntimeException; diff --git a/api/src/org/apache/cloudstack/api/admin/network/command/ListNetworkDeviceCmd.java b/api/src/org/apache/cloudstack/api/admin/network/command/ListNetworkDeviceCmd.java index 65c9e1cb871..21e0e6df327 100644 --- a/api/src/org/apache/cloudstack/api/admin/network/command/ListNetworkDeviceCmd.java +++ b/api/src/org/apache/cloudstack/api/admin/network/command/ListNetworkDeviceCmd.java @@ -28,6 +28,8 @@ import org.apache.cloudstack.api.BaseListCmd; import org.apache.cloudstack.api.Implementation; import org.apache.cloudstack.api.Parameter; import org.apache.cloudstack.api.ServerApiException; +import org.apache.cloudstack.network.ExternalNetworkDeviceManager; +import org.apache.cloudstack.api.admin.network.response.NetworkDeviceResponse; import com.cloud.api.response.ListResponse; import com.cloud.exception.ConcurrentOperationException; import com.cloud.exception.InsufficientCapacityException; @@ -35,9 +37,7 @@ import com.cloud.exception.InvalidParameterValueException; import com.cloud.exception.ResourceAllocationException; import com.cloud.exception.ResourceUnavailableException; import com.cloud.host.Host; -import com.cloud.network.ExternalNetworkDeviceManager; import com.cloud.server.ManagementService; -import com.cloud.server.api.response.NetworkDeviceResponse; import com.cloud.utils.component.ComponentLocator; import com.cloud.utils.exception.CloudRuntimeException; diff --git a/api/src/org/apache/cloudstack/api/user/vm/command/DeployVMCmd.java b/api/src/org/apache/cloudstack/api/user/vm/command/DeployVMCmd.java index b06241d285f..ac67297071e 100644 --- a/api/src/org/apache/cloudstack/api/user/vm/command/DeployVMCmd.java +++ b/api/src/org/apache/cloudstack/api/user/vm/command/DeployVMCmd.java @@ -38,6 +38,7 @@ import com.cloud.api.response.UserVmResponse; import com.cloud.async.AsyncJob; import com.cloud.dc.DataCenter; import com.cloud.dc.DataCenter.NetworkType; +import com.cloud.domain.Domain; import com.cloud.event.EventTypes; import com.cloud.exception.ConcurrentOperationException; import com.cloud.exception.InsufficientCapacityException; diff --git a/api/test/src/com/cloud/api/commands/test/ListRoutersCmdTest.java b/api/test/src/com/cloud/api/commands/test/ListRoutersCmdTest.java index d922474e743..64039f1c7c4 100644 --- a/api/test/src/com/cloud/api/commands/test/ListRoutersCmdTest.java +++ b/api/test/src/com/cloud/api/commands/test/ListRoutersCmdTest.java @@ -29,10 +29,9 @@ import org.junit.Test; import org.junit.rules.ExpectedException; import org.mockito.Mockito; - -import com.cloud.api.ResponseGenerator; -import com.cloud.api.ServerApiException; -import com.cloud.api.commands.ListRoutersCmd; +import org.apache.cloudstack.api.ResponseGenerator; +import org.apache.cloudstack.api.ServerApiException; +import org.apache.cloudstack.api.admin.router.command.ListRoutersCmd; import com.cloud.api.response.DomainRouterResponse; import com.cloud.api.response.ListResponse; import com.cloud.api.view.vo.DomainRouterJoinVO; diff --git a/api/test/src/com/cloud/api/commands/test/ListVmsCmdTest.java b/api/test/src/com/cloud/api/commands/test/ListVmsCmdTest.java index ca6d95e2d71..19ce047d241 100644 --- a/api/test/src/com/cloud/api/commands/test/ListVmsCmdTest.java +++ b/api/test/src/com/cloud/api/commands/test/ListVmsCmdTest.java @@ -32,12 +32,12 @@ import org.junit.Test; import org.junit.rules.ExpectedException; import org.mockito.Mockito; -import com.cloud.api.ApiConstants; -import com.cloud.api.ApiConstants.VMDetails; -import com.cloud.api.BaseCmd; -import com.cloud.api.ResponseGenerator; -import com.cloud.api.ServerApiException; -import com.cloud.api.commands.ListVMsCmd; +import org.apache.cloudstack.api.ApiConstants; +import org.apache.cloudstack.api.ApiConstants.VMDetails; +import org.apache.cloudstack.api.BaseCmd; +import org.apache.cloudstack.api.ResponseGenerator; +import org.apache.cloudstack.api.ServerApiException; +import org.apache.cloudstack.api.user.vm.command.ListVMsCmd; import com.cloud.api.response.ListResponse; import com.cloud.api.response.UserVmResponse; import com.cloud.api.view.vo.UserVmJoinVO; diff --git a/server/src/com/cloud/api/ApiDBUtils.java b/server/src/com/cloud/api/ApiDBUtils.java index 5dc24129b9f..a98c5d3557a 100755 --- a/server/src/com/cloud/api/ApiDBUtils.java +++ b/server/src/com/cloud/api/ApiDBUtils.java @@ -896,8 +896,7 @@ public class ApiDBUtils { public static CounterVO getCounter(long counterId) { return _counterDao.findById(counterId); - }} - + } /////////////////////////////////////////////////////////////////////// // Newly Added Utility Methods for List API refactoring // diff --git a/server/src/com/cloud/host/dao/HostDaoImpl.java b/server/src/com/cloud/host/dao/HostDaoImpl.java index 05d5b4bac73..0881675dda7 100755 --- a/server/src/com/cloud/host/dao/HostDaoImpl.java +++ b/server/src/com/cloud/host/dao/HostDaoImpl.java @@ -63,7 +63,7 @@ import com.cloud.utils.exception.CloudRuntimeException; @Local(value = { HostDao.class }) @DB(txn = false) @TableGenerator(name = "host_req_sq", table = "op_host", pkColumnName = "id", valueColumnName = "sequence", allocationSize = 1) -public class HostDaoImpl extends GenericDaoBase implements HostDao, ExternalIdDao { +public class HostDaoImpl extends GenericDaoBase implements HostDao { //FIXME: , ExternalIdDao { private static final Logger s_logger = Logger.getLogger(HostDaoImpl.class); private static final Logger status_logger = Logger.getLogger(Status.class); private static final Logger state_logger = Logger.getLogger(ResourceState.class); diff --git a/server/src/com/cloud/vm/dao/UserVmJoinDao.java b/server/src/com/cloud/vm/dao/UserVmJoinDao.java index adeef63339d..057e043295f 100644 --- a/server/src/com/cloud/vm/dao/UserVmJoinDao.java +++ b/server/src/com/cloud/vm/dao/UserVmJoinDao.java @@ -19,7 +19,7 @@ package com.cloud.vm.dao; import java.util.EnumSet; import java.util.List; -import com.cloud.api.ApiConstants.VMDetails; +import org.apache.cloudstack.api.ApiConstants.VMDetails; import com.cloud.api.response.UserVmResponse; import com.cloud.api.view.vo.UserVmJoinVO; import com.cloud.user.Account; diff --git a/server/src/com/cloud/vm/dao/UserVmJoinDaoImpl.java b/server/src/com/cloud/vm/dao/UserVmJoinDaoImpl.java index 5b7a2c15ac3..4df9f88e8eb 100644 --- a/server/src/com/cloud/vm/dao/UserVmJoinDaoImpl.java +++ b/server/src/com/cloud/vm/dao/UserVmJoinDaoImpl.java @@ -31,7 +31,7 @@ import javax.ejb.Local; import org.apache.log4j.Logger; import com.cloud.api.ApiDBUtils; -import com.cloud.api.ApiConstants.VMDetails; +import org.apache.cloudstack.api.ApiConstants.VMDetails; import com.cloud.api.response.NicResponse; import com.cloud.api.response.ResourceTagResponse; import com.cloud.api.response.SecurityGroupResponse;