bug 10620: allow ISO attachment failure to propogate up

This commit is contained in:
Kelven Yang 2011-07-07 17:00:41 -07:00
parent 01a04935aa
commit d0de1a5b94
2 changed files with 5 additions and 1 deletions

View File

@ -821,6 +821,9 @@ public class TemplateManagerImpl implements TemplateManager, Manager, TemplateSe
throw new InvalidParameterValueException("Cannot attach Xenserver PV drivers to incompatible hypervisor " + vm.getHypervisorType());
}
if("vmware-tools.iso".equals(iso.getName()) && vm.getHypervisorType() != Hypervisor.HypervisorType.VMware) {
throw new InvalidParameterValueException("Cannot attach VMware tools drivers to incompatible hypervisor " + vm.getHypervisorType());
}
return attachISOToVM(vmId, userId, isoId, true);
}

View File

@ -865,7 +865,8 @@ public class UserVmManagerImpl implements UserVmManager, UserVmService, Manager
cmd.setStoreUrl(isoPathPair.second());
}
Answer a = _agentMgr.easySend(vm.getHostId(), cmd);
return (a != null);
return (a != null && a.getResult());
}
private UserVm rebootVirtualMachine(long userId, long vmId) throws InsufficientCapacityException, ResourceUnavailableException {