From d056c3d279823e321b0be2bde83946cbf51d0e41 Mon Sep 17 00:00:00 2001 From: Rafael da Fonseca Date: Sun, 14 Jun 2015 21:21:51 +0200 Subject: [PATCH] Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in VirtualMachineManagerImpl.java Removed two unnecessary null checks as this piece of code will only run if answer is not null, as satified in condition stated in line #1253 Signed-off-by: Daan Hoogland This closes #445 --- .../src/com/cloud/vm/VirtualMachineManagerImpl.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java b/engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java index ad31fdda0a7..057c9e2b77f 100644 --- a/engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java +++ b/engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java @@ -1266,8 +1266,8 @@ public class VirtualMachineManagerImpl extends ManagerBase implements VirtualMac if (gpuDevice != null) { _resourceMgr.updateGPUDetails(vm.getHostId(), gpuDevice.getGroupDetails()); } - if (answer == null || !answer.getResult()) { - final String details = answer != null ? answer.getDetails() : "null answer returned"; + if (!answer.getResult()) { + final String details = answer.getDetails(); s_logger.debug("Unable to stop VM due to " + details); return false; }