apache/cloudstack
1
0
Fork 0
mirror of https://github.com/apache/cloudstack.git synced 2025-11-02 11:52:28 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in VirtualMachineManagerImpl.java Removed two unnecessary null checks as this piece of code will only run if answer is not null, as satified in condition stated in line #1253

Browse Source 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #445
This commit is contained in:
Rafael da Fonseca 2015-06-14 21:21:51 +02:00 committed by Daan Hoogland
parent d702b63bfb
commit d056c3d279
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
View File

@ -1266,8 +1266,8 @@ public class VirtualMachineManagerImpl extends ManagerBase implements VirtualMac
if (gpuDevice != null) {
_resourceMgr.updateGPUDetails(vm.getHostId(), gpuDevice.getGroupDetails());
}
if (answer == null || !answer.getResult()) {
final String details = answer != null ? answer.getDetails() : "null answer returned";
if (!answer.getResult()) {
final String details = answer.getDetails();
s_logger.debug("Unable to stop VM due to " + details);
return false;
}