diff --git a/services/secondary-storage/controller/src/main/java/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImpl.java b/services/secondary-storage/controller/src/main/java/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImpl.java index cd6f23923e1..94a8f367d08 100644 --- a/services/secondary-storage/controller/src/main/java/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImpl.java +++ b/services/secondary-storage/controller/src/main/java/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImpl.java @@ -402,10 +402,13 @@ public class SecondaryStorageManagerImpl extends ManagerBase implements Secondar } String[] cidrs = _allowedInternalSites.split(","); for (String cidr : cidrs) { - if (NetUtils.isValidIp4Cidr(cidr) || NetUtils.isValidIp4(cidr) || !cidr.startsWith("0.0.0.0")) { - if (NetUtils.getCleanIp4Cidr(cidr).equals(cidr)) { + if (NetUtils.isValidIp4Cidr(cidr) && !cidr.startsWith("0.0.0.0")) { + if (! NetUtils.getCleanIp4Cidr(cidr).equals(cidr)) { s_logger.warn(String.format("Invalid CIDR %s in %s", cidr, SecStorageAllowedInternalDownloadSites.key())); } + allowedCidrs.add(NetUtils.getCleanIp4Cidr(cidr)); + } else if (NetUtils.isValidIp4(cidr) && !cidr.startsWith("0.0.0.0")) { + s_logger.warn(String.format("Ip address is not a valid CIDR; %s consider using %s/32", cidr, cidr)); allowedCidrs.add(cidr); } }