diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md index 1dd67599662..dafbcb005b5 100644 --- a/PULL_REQUEST_TEMPLATE.md +++ b/PULL_REQUEST_TEMPLATE.md @@ -12,6 +12,13 @@ - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) +## GitHub Issue/PRs + + + + + + ## Screenshots (if appropriate): ## How Has This Been Tested? diff --git a/api/src/main/java/com/cloud/agent/api/storage/OVFHelper.java b/api/src/main/java/com/cloud/agent/api/storage/OVFHelper.java index 167d5d4fe4b..85d4030b215 100644 --- a/api/src/main/java/com/cloud/agent/api/storage/OVFHelper.java +++ b/api/src/main/java/com/cloud/agent/api/storage/OVFHelper.java @@ -113,7 +113,7 @@ public class OVFHelper { String allocationUnits = disk.getAttribute("ovf:capacityAllocationUnits"); od._diskId = disk.getAttribute("ovf:diskId"); od._fileRef = disk.getAttribute("ovf:fileRef"); - od._populatedSize = Long.parseLong(disk.getAttribute("ovf:populatedSize") == null ? "0" : disk.getAttribute("ovf:populatedSize")); + od._populatedSize = NumberUtils.toLong(disk.getAttribute("ovf:populatedSize")); if ((od._capacity != 0) && (allocationUnits != null)) { diff --git a/python/lib/cloud_utils.py b/python/lib/cloud_utils.py index 43c93c87631..a9afb04dd8e 100644 --- a/python/lib/cloud_utils.py +++ b/python/lib/cloud_utils.py @@ -759,7 +759,7 @@ class SetupLiveMigration(ConfigTask): if os.path.exists("/etc/init/libvirt-bin.conf"): replace_line("/etc/init/libvirt-bin.conf", "exec /usr/sbin/libvirtd","exec /usr/sbin/libvirtd -d -l") else: - replace_or_add_line("/etc/default/libvirt-bin","libvirtd_opts=","libvirtd_opts='-l -d'") + replace_or_add_line("/etc/default/libvirt-bin","libvirtd_opts=","libvirtd_opts='-l'") else: raise AssertionError("Unsupported distribution") diff --git a/python/lib/cloudutils/serviceConfig.py b/python/lib/cloudutils/serviceConfig.py index c9c019c5abe..68d1b9cef5b 100755 --- a/python/lib/cloudutils/serviceConfig.py +++ b/python/lib/cloudutils/serviceConfig.py @@ -526,9 +526,12 @@ class libvirtConfigUbuntu(serviceCfgBase): if os.path.exists("/etc/init/libvirt-bin.conf"): cfo = configFileOps("/etc/init/libvirt-bin.conf", self) cfo.replace_line("exec /usr/sbin/libvirtd","exec /usr/sbin/libvirtd -d -l") - else: + elif os.path.exists("/etc/default/libvirt-bin"): cfo = configFileOps("/etc/default/libvirt-bin", self) - cfo.replace_or_add_line("libvirtd_opts=","libvirtd_opts='-l -d'") + cfo.replace_or_add_line("libvirtd_opts=","libvirtd_opts='-l'") + elif os.path.exists("/etc/default/libvirtd"): + cfo = configFileOps("/etc/default/libvirtd", self) + cfo.replace_or_add_line("libvirtd_opts=","libvirtd_opts='-l'") def config(self): try: diff --git a/systemvm/debian/etc/apache2/conf-enabled/security.conf b/systemvm/debian/etc/apache2/conf-enabled/security.conf new file mode 100644 index 00000000000..498d147c3f2 --- /dev/null +++ b/systemvm/debian/etc/apache2/conf-enabled/security.conf @@ -0,0 +1,3 @@ +ServerTokens Prod +ServerSignature Off +TraceEnable Off diff --git a/systemvm/debian/opt/cloud/bin/setup/common.sh b/systemvm/debian/opt/cloud/bin/setup/common.sh index a84d8814a8b..e24a27790b7 100755 --- a/systemvm/debian/opt/cloud/bin/setup/common.sh +++ b/systemvm/debian/opt/cloud/bin/setup/common.sh @@ -496,9 +496,6 @@ clean_ipalias_config() { setup_apache2_common() { sed -i 's/^Include ports.conf.*/# CS: Done by Python CsApp config\n#Include ports.conf/g' /etc/apache2/apache2.conf - [ -f /etc/apache2/conf.d/security ] && sed -i -e "s/^ServerTokens .*/ServerTokens Prod/g" /etc/apache2/conf.d/security - [ -f /etc/apache2/conf.d/security ] && sed -i -e "s/^ServerSignature .*/ServerSignature Off/g" /etc/apache2/conf.d/security - # Disable listing of http://SSVM-IP/icons folder for security issue. see article http://www.i-lateral.com/tutorials/disabling-the-icons-folder-on-an-ubuntu-web-server/ [ -f /etc/apache2/mods-available/alias.conf ] && sed -i s/"Options Indexes MultiViews"/"Options -Indexes MultiViews"/ /etc/apache2/mods-available/alias.conf diff --git a/ui/css/cloudstack3.css b/ui/css/cloudstack3.css index 1ef2d84f7b4..aaeba9a3b32 100644 --- a/ui/css/cloudstack3.css +++ b/ui/css/cloudstack3.css @@ -4452,7 +4452,7 @@ textarea { /**** Head*/ .dashboard.admin .dashboard-container.head { width: 966px; - height: 331px; + height: 431px; margin: 9px 0 0; float: left; } @@ -4512,7 +4512,7 @@ textarea { /**** Charts / stats*/ .dashboard.admin .zone-stats { width: 974px; - height: 316px; + height: 416px; overflow: auto; overflow-x: hidden; /*+placement:shift 0px 0px;*/ @@ -4711,7 +4711,7 @@ textarea { .dashboard.admin .dashboard-container.sub.alerts { float: left; margin: 0 12px 0 0; - height: 270px; + height: 170px; overflow: hidden; position: relative; }