Fixed all sync commands that can possibly return a <success> tag. If success, it will return true, otherwise an HTTP error will be returned.

server/src/com/cloud/api/commands/AssignToLoadBalancerRuleCmd.java

@@ -24,8 +24,10 @@ import org.apache.log4j.Logger;
 import com.cloud.api.ApiConstants;
 import com.cloud.api.ApiDBUtils;
 import com.cloud.api.BaseAsyncCmd;
+import com.cloud.api.BaseCmd;
 import com.cloud.api.Implementation;
 import com.cloud.api.Parameter;
+import com.cloud.api.ServerApiException;
 import com.cloud.api.response.SuccessResponse;
 import com.cloud.event.EventTypes;
 import com.cloud.network.LoadBalancerVO;
@@ -97,9 +99,10 @@ public class AssignToLoadBalancerRuleCmd extends BaseAsyncCmd {
 
     @Override @SuppressWarnings("unchecked")
     public SuccessResponse getResponse() {
-        SuccessResponse response = new SuccessResponse();
-        response.setSuccess(Boolean.TRUE);
-        response.setResponseName("success");
-        return response;
+    	if (getResponseObject() == null || (Boolean)getResponseObject()) {
+	    	return new SuccessResponse(getName());
+	    } else {
+	    	throw new ServerApiException(BaseCmd.INTERNAL_ERROR, "Failed to assign to load balancer");
+	    }
     }
 }

server/src/com/cloud/api/commands/DeleteDiskOfferingCmd.java

@@ -60,15 +60,10 @@ public class DeleteDiskOfferingCmd extends BaseCmd {
   
     @Override @SuppressWarnings("unchecked")
     public SuccessResponse getResponse() {
-    	 SuccessResponse response = new SuccessResponse();
-         Boolean responseObject = (Boolean)getResponseObject();
-       
-         if (responseObject != null) {
-         	response.setSuccess(responseObject);
-         } else {
-             throw new ServerApiException(BaseCmd.INTERNAL_ERROR, "Failed to delete disk offering");
-         }
-
-         return response;
+    	if (getResponseObject() == null || (Boolean)getResponseObject()) {
+	    	return new SuccessResponse(getName());
+	    } else {
+	    	throw new ServerApiException(BaseCmd.INTERNAL_ERROR, "Failed to delete disk offering");
+	    }
     }
 }

server/src/com/cloud/api/commands/DeleteDomainCmd.java

@@ -90,16 +90,10 @@ public class DeleteDomainCmd extends BaseAsyncCmd {
 
     @Override @SuppressWarnings("unchecked")
     public SuccessResponse getResponse() {
-        Boolean responseObject = (Boolean)getResponseObject();
-
-        SuccessResponse response = new SuccessResponse();
-        
-        if (responseObject != null) {
-        	response.setSuccess(responseObject);
-        } else {
-            throw new ServerApiException(BaseCmd.INTERNAL_ERROR, "Failed to delete host");
-        }
-
-        return response;
+    	if (getResponseObject() == null || (Boolean)getResponseObject()) {
+	    	return new SuccessResponse(getName());
+	    } else {
+	    	throw new ServerApiException(BaseCmd.INTERNAL_ERROR, "Failed to delete delete domain");
+	    }
     }
 }

server/src/com/cloud/api/commands/DeleteHostCmd.java

@@ -63,15 +63,10 @@ public class DeleteHostCmd extends BaseCmd {
     
     @Override@SuppressWarnings("unchecked")
     public SuccessResponse getResponse() {
-        SuccessResponse response = new SuccessResponse();
-        Boolean responseObject = (Boolean)getResponseObject();
-      
-        if (responseObject != null) {
-        	response.setSuccess(responseObject);
-        } else {
-            throw new ServerApiException(BaseCmd.INTERNAL_ERROR, "Failed to delete host");
-        }
-
-        return response;
+    	if (getResponseObject() == null || (Boolean)getResponseObject()) {
+	    	return new SuccessResponse(getName());
+	    } else {
+	    	throw new ServerApiException(BaseCmd.INTERNAL_ERROR, "Failed to delete host");
+	    }
     }
 }

server/src/com/cloud/api/commands/DeleteIPForwardingRuleCmd.java

@@ -59,8 +59,8 @@ public class DeleteIPForwardingRuleCmd extends BaseCmd {
 
 	@Override @SuppressWarnings("unchecked")
 	public SuccessResponse getResponse() {
-	    if ((Boolean)getResponseObject()) {
-	    	return new SuccessResponse();
+		if (getResponseObject() == null || (Boolean)getResponseObject()) {
+	    	return new SuccessResponse(getName());
 	    } else {
 	    	throw new ServerApiException(BaseCmd.INTERNAL_ERROR, "Failed to delete port forwarding rule");
 	    }

server/src/com/cloud/api/commands/DeleteIsoCmd.java

@@ -75,8 +75,8 @@ public class DeleteIsoCmd extends BaseAsyncCmd {
     
     @Override @SuppressWarnings("unchecked")
     public SuccessResponse getResponse() {
-    	if ((Boolean)getResponseObject()) {
-	    	return new SuccessResponse();
+    	if (getResponseObject() == null || (Boolean)getResponseObject()) {
+	    	return new SuccessResponse(getName());
 	    } else {
 	    	throw new ServerApiException(BaseCmd.INTERNAL_ERROR, "Failed to delete iso");
 	    }

server/src/com/cloud/api/commands/DeleteLoadBalancerRuleCmd.java

@@ -83,8 +83,8 @@ public class DeleteLoadBalancerRuleCmd extends BaseAsyncCmd {
 
 	@Override @SuppressWarnings("unchecked")
 	public SuccessResponse getResponse() {
-		if ((Boolean)getResponseObject()) {
-	    	return new SuccessResponse();
+		if (getResponseObject() == null || (Boolean)getResponseObject()) {
+	    	return new SuccessResponse(getName());
 	    } else {
 	    	throw new ServerApiException(BaseCmd.INTERNAL_ERROR, "Failed to delete load balancer rule");
 	    }

server/src/com/cloud/api/commands/DeleteNetworkGroupCmd.java

@@ -57,8 +57,8 @@ public class DeleteNetworkGroupCmd extends BaseCmd {
 
 	@Override @SuppressWarnings("unchecked")
 	public SuccessResponse getResponse() {
-		if ((Boolean)getResponseObject()) {
-	    	return new SuccessResponse();
+		if (getResponseObject() == null || (Boolean)getResponseObject()) {
+	    	return new SuccessResponse(getName());
 	    } else {
 	    	throw new ServerApiException(BaseCmd.INTERNAL_ERROR, "Failed to delete security group");
 	    }

server/src/com/cloud/api/commands/DeletePodCmd.java

@@ -60,8 +60,8 @@ public class DeletePodCmd extends BaseCmd {
     
     @Override @SuppressWarnings("unchecked")
     public SuccessResponse getResponse() {
-    	if ((Boolean)getResponseObject()) {
-	    	return new SuccessResponse();
+    	if (getResponseObject() == null || (Boolean)getResponseObject()) {
+	    	return new SuccessResponse(getName());
 	    } else {
 	    	throw new ServerApiException(BaseCmd.INTERNAL_ERROR, "Failed to delete pod");
 	    }

server/src/com/cloud/api/commands/DeletePoolCmd.java

@@ -43,8 +43,8 @@ public class DeletePoolCmd extends BaseCmd {
     
     @Override @SuppressWarnings("unchecked")
     public SuccessResponse getResponse() {
-    	if ((Boolean)getResponseObject()) {
-	    	return new SuccessResponse();
+    	if ((Boolean)getResponseObject() == null || (Boolean)getResponseObject()) {
+	    	return new SuccessResponse(getName());
 	    } else {
 	    	throw new ServerApiException(BaseCmd.INTERNAL_ERROR, "Failed to delete storage pool");
 	    }

server/src/com/cloud/api/commands/DeletePreallocatedLunCmd.java

@@ -54,8 +54,8 @@ public class DeletePreallocatedLunCmd extends BaseCmd {
 
     @Override @SuppressWarnings("unchecked")
     public SuccessResponse getResponse() {
-    	if ((Boolean)getResponseObject()) {
-	    	return new SuccessResponse();
+    	if (getResponseObject() == null || (Boolean)getResponseObject()) {
+	    	return new SuccessResponse(getName());
 	    } else {
 	    	throw new ServerApiException(BaseCmd.INTERNAL_ERROR, "Failed to delete preallocated lun");
 	    }

server/src/com/cloud/api/commands/DeleteRemoteAccessVpnCmd.java

@@ -81,8 +81,8 @@ public class DeleteRemoteAccessVpnCmd extends BaseAsyncCmd {
 
     @Override @SuppressWarnings("unchecked")
     public SuccessResponse getResponse() {
-    	if ((Boolean)getResponseObject()) {
-	    	return new SuccessResponse();
+    	if ((Boolean)getResponseObject() == null || (Boolean)getResponseObject()) {
+	    	return new SuccessResponse(getName());
 	    } else {
 	    	throw new ServerApiException(BaseCmd.INTERNAL_ERROR, "Failed to delete remote access vpn");
 	    }

server/src/com/cloud/api/commands/DeleteServiceOfferingCmd.java

@@ -61,8 +61,8 @@ public class DeleteServiceOfferingCmd extends BaseCmd{
 
 	@Override @SuppressWarnings("unchecked")
 	public SuccessResponse getResponse() {
-		if ((Boolean)getResponseObject()) {
-	    	return new SuccessResponse();
+		if (getResponseObject() == null || (Boolean)getResponseObject()) {
+	    	return new SuccessResponse(getName());
 	    } else {
 	    	throw new ServerApiException(BaseCmd.INTERNAL_ERROR, "Failed to delete service offering");
 	    }

server/src/com/cloud/api/commands/DeleteSnapshotCmd.java

@@ -99,8 +99,8 @@ public class DeleteSnapshotCmd extends BaseAsyncCmd {
 
 	@Override @SuppressWarnings("unchecked")
 	public SuccessResponse getResponse() {
-		if ((Boolean)getResponseObject()) {
-	    	return new SuccessResponse();
+		if (getResponseObject() == null || (Boolean)getResponseObject()) {
+	    	return new SuccessResponse(getName());
 	    } else {
 	    	throw new ServerApiException(BaseCmd.INTERNAL_ERROR, "Failed to delete snapshot");
 	    }

server/src/com/cloud/api/commands/DeleteSnapshotPoliciesCmd.java

@@ -85,8 +85,8 @@ public class DeleteSnapshotPoliciesCmd extends BaseCmd {
 
 	@Override @SuppressWarnings("unchecked")
 	public SuccessResponse getResponse() {
-		if ((Boolean)getResponseObject()) {
-	    	return new SuccessResponse();
+		if (getResponseObject() == null || (Boolean)getResponseObject()) {
+	    	return new SuccessResponse(getName());
 	    } else {
 	    	throw new ServerApiException(BaseCmd.INTERNAL_ERROR, "Failed to delete snapshot policy");
 	    }

server/src/com/cloud/api/commands/DeleteTemplateCmd.java

@@ -77,8 +77,8 @@ public class DeleteTemplateCmd extends BaseAsyncCmd {
 
 	@Override @SuppressWarnings("unchecked")
 	public SuccessResponse getResponse() {
-		if ((Boolean)getResponseObject()) {
-	    	return new SuccessResponse();
+		if (getResponseObject() == null || (Boolean)getResponseObject()) {
+	    	return new SuccessResponse(getName());
 	    } else {
 	    	throw new ServerApiException(BaseCmd.INTERNAL_ERROR, "Failed to delete template");
 	    }

server/src/com/cloud/api/commands/DeleteUserCmd.java

@@ -92,8 +92,8 @@ public class DeleteUserCmd extends BaseAsyncCmd {
 
 	@Override @SuppressWarnings("unchecked")
 	public SuccessResponse getResponse() {
-		if ((Boolean)getResponseObject()) {
-	    	return new SuccessResponse();
+		if (getResponseObject() == null || (Boolean)getResponseObject()) {
+	    	return new SuccessResponse(getName());
 	    } else {
 	    	throw new ServerApiException(BaseCmd.INTERNAL_ERROR, "Failed to delete user");
 	    }

server/src/com/cloud/api/commands/DeleteVMGroupCmd.java

@@ -58,8 +58,8 @@ public class DeleteVMGroupCmd extends BaseCmd{
 
     @Override @SuppressWarnings("unchecked")
     public SuccessResponse getResponse() {
-    	if ((Boolean)getResponseObject()) {
-	    	return new SuccessResponse();
+    	if (getResponseObject() == null || (Boolean)getResponseObject()) {
+	    	return new SuccessResponse(getName());
 	    } else {
 	    	throw new ServerApiException(BaseCmd.INTERNAL_ERROR, "Failed to delete virtual machine group");
 	    }

server/src/com/cloud/api/commands/DeleteVlanIpRangeCmd.java

@@ -60,8 +60,8 @@ public class DeleteVlanIpRangeCmd extends BaseCmd {
 
 	@Override @SuppressWarnings("unchecked")
 	public SuccessResponse getResponse() {
-		if ((Boolean)getResponseObject()) {
-	    	return new SuccessResponse();
+		if (getResponseObject() == null || (Boolean)getResponseObject()) {
+	    	return new SuccessResponse(getName());
 	    } else {
 	    	throw new ServerApiException(BaseCmd.INTERNAL_ERROR, "Failed to delete vlan ip range");
 	    }

server/src/com/cloud/api/commands/DeleteVolumeCmd.java

@@ -65,8 +65,8 @@ public class DeleteVolumeCmd extends BaseCmd {
 
 	@Override @SuppressWarnings("unchecked")
 	public SuccessResponse getResponse() {
-		if ((Boolean)getResponseObject()) {
-	    	return new SuccessResponse();
+		if (getResponseObject() == null || (Boolean)getResponseObject()) {
+	    	return new SuccessResponse(getName());
 	    } else {
 	    	throw new ServerApiException(BaseCmd.INTERNAL_ERROR, "Failed to delete volume");
 	    }

server/src/com/cloud/api/commands/DeleteZoneCmd.java

@@ -62,8 +62,8 @@ public class DeleteZoneCmd extends BaseCmd {
 
 	@Override @SuppressWarnings("unchecked")
 	public SuccessResponse getResponse() {
-		if ((Boolean)getResponseObject()) {
-	    	return new SuccessResponse();
+		if (getResponseObject() == null || (Boolean)getResponseObject()) {
+	    	return new SuccessResponse(getName());
 	    } else {
 	    	throw new ServerApiException(BaseCmd.INTERNAL_ERROR, "Failed to delete zone");
 	    }

server/src/com/cloud/api/commands/DestroyConsoleProxyCmd.java

@@ -86,8 +86,8 @@ public class DestroyConsoleProxyCmd extends BaseAsyncCmd {
 
 	@Override @SuppressWarnings("unchecked")
 	public SuccessResponse getResponse() {
-		if ((Boolean)getResponseObject()) {
-	    	return new SuccessResponse();
+		if (getResponseObject() == null || (Boolean)getResponseObject()) {
+	    	return new SuccessResponse(getName());
 	    } else {
 	    	throw new ServerApiException(BaseCmd.INTERNAL_ERROR, "Failed to delete console proxy");
 	    }

server/src/com/cloud/api/commands/DetachIsoCmd.java

@@ -84,8 +84,8 @@ public class DetachIsoCmd extends BaseAsyncCmd {
 
 	@Override @SuppressWarnings("unchecked")
 	public SuccessResponse getResponse() {
-		if ((Boolean)getResponseObject()) {
-	    	return new SuccessResponse();
+		if (getResponseObject() == null || (Boolean)getResponseObject()) {
+	    	return new SuccessResponse(getName());
 	    } else {
 	    	throw new ServerApiException(BaseCmd.INTERNAL_ERROR, "Failed to detach iso");
 	    }

server/src/com/cloud/api/commands/DisassociateIPAddrCmd.java

@@ -59,8 +59,8 @@ public class DisassociateIPAddrCmd extends BaseCmd {
 
 	@Override @SuppressWarnings("unchecked")
 	public SuccessResponse getResponse() {
-		if ((Boolean)getResponseObject()) {
-	    	return new SuccessResponse();
+		if (getResponseObject() == null || (Boolean)getResponseObject()) {
+	    	return new SuccessResponse(getName());
 	    } else {
 	    	throw new ServerApiException(BaseCmd.INTERNAL_ERROR, "Failed to disassociate ip address");
 	    }

server/src/com/cloud/api/commands/RemoveFromLoadBalancerRuleCmd.java

@@ -107,8 +107,8 @@ public class RemoveFromLoadBalancerRuleCmd extends BaseAsyncCmd {
 
 	@Override @SuppressWarnings("unchecked")
 	public SuccessResponse getResponse() {
-		if ((Boolean)getResponseObject()) {
-	    	return new SuccessResponse();
+		if (getResponseObject() == null || (Boolean)getResponseObject()) {
+	    	return new SuccessResponse(getName());
 	    } else {
 	    	throw new ServerApiException(BaseCmd.INTERNAL_ERROR, "Failed to remove instance from load balancer rule");
 	    }

server/src/com/cloud/api/commands/RemoveVpnUserCmd.java

@@ -86,8 +86,8 @@ public class RemoveVpnUserCmd extends BaseAsyncCmd {
 
     @Override @SuppressWarnings("unchecked")
     public SuccessResponse getResponse() {
-    	if ((Boolean)getResponseObject()) {
-	    	return new SuccessResponse();
+    	if (getResponseObject() == null || (Boolean)getResponseObject()) {
+	    	return new SuccessResponse(getName());
 	    } else {
 	    	throw new ServerApiException(BaseCmd.INTERNAL_ERROR, "Failed to remove vpn user");
 	    }

server/src/com/cloud/api/commands/RevokeNetworkGroupIngressCmd.java

@@ -182,8 +182,8 @@ public class RevokeNetworkGroupIngressCmd extends BaseAsyncCmd {
 
     @Override @SuppressWarnings("unchecked")
 	public SuccessResponse getResponse() {
-    	if ((Boolean)getResponseObject()) {
-	    	return new SuccessResponse();
+    	if (getResponseObject() == null || (Boolean)getResponseObject()) {
+	    	return new SuccessResponse(getName());
 	    } else {
 	    	throw new ServerApiException(BaseCmd.INTERNAL_ERROR, "Failed to revoke security group ingress rule");
 	    }

server/src/com/cloud/api/commands/UpdateTemplateOrIsoPermissionsCmd.java

@@ -81,8 +81,8 @@ public abstract class UpdateTemplateOrIsoPermissionsCmd extends BaseCmd {
     
     @Override @SuppressWarnings("unchecked")
     public SuccessResponse getResponse() {
-    	if ((Boolean)getResponseObject()) {
-	    	return new SuccessResponse();
+    	if (getResponseObject() == null || (Boolean)getResponseObject()) {
+	    	return new SuccessResponse(getName());
 	    } else {
 	    	throw new ServerApiException(BaseCmd.INTERNAL_ERROR, "Failed to update template permissions");
 	    }

server/src/com/cloud/api/response/ApiResponseSerializer.java

@@ -47,6 +47,8 @@ public class ApiResponseSerializer {
                 } else {
                     sb.append("{ }");
                 }
+            } else if (result instanceof SuccessResponse) {
+            	sb.append("{ \"success\" : \""+((SuccessResponse)result).getSuccess()+"\"} ");
             } else {
                 String jsonStr = gson.toJson(result);
                 if ((jsonStr != null) && !"".equals(jsonStr)) {

server/src/com/cloud/api/response/SuccessResponse.java

@@ -25,4 +25,8 @@ public class SuccessResponse extends BaseResponse {
     public void setDisplayText(String displayText) {
         this.displayText = displayText;
     }
+    
+    public SuccessResponse(String responseName) {
+    	super.setResponseName(responseName);
+    }
 }