From c9a95bc22c57a388f3d0e5f2c9aa3e6601717251 Mon Sep 17 00:00:00 2001 From: Charles Weng Date: Wed, 12 Jun 2024 04:32:49 -0700 Subject: [PATCH] Add unit tests for null cpu for null parameters for set allocated cpu (#9137) * Add unit tests for null cpu for null parameters for set allocated cpu * break up tests for null cpu checks --- .../response/HostMetricsResponseTest.java | 23 +++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/plugins/metrics/src/test/java/org/apache/cloudstack/response/HostMetricsResponseTest.java b/plugins/metrics/src/test/java/org/apache/cloudstack/response/HostMetricsResponseTest.java index 98c8cd3d97f..d81d6f6dadb 100644 --- a/plugins/metrics/src/test/java/org/apache/cloudstack/response/HostMetricsResponseTest.java +++ b/plugins/metrics/src/test/java/org/apache/cloudstack/response/HostMetricsResponseTest.java @@ -56,4 +56,27 @@ public class HostMetricsResponseTest { Assert.assertEquals(expected, hostResponse.getCpuAllocatedGhz()); } + @Test + public void testSetCpuAllocatedWithNullCpu() { + String expected = null; + final HostMetricsResponse hostResponse = new HostMetricsResponse(); + hostResponse.setCpuAllocated(null, 10, 1000L); + Assert.assertEquals(expected, hostResponse.getCpuAllocatedGhz()); + } + + @Test + public void testSetCpuAllocatedWithNullCpuNumber() { + String expected = null; + final HostMetricsResponse hostResponse = new HostMetricsResponse(); + hostResponse.setCpuAllocated(String.format("50%s25%%", decimalSeparator), null, 1000L); + Assert.assertEquals(expected, hostResponse.getCpuAllocatedGhz()); + } + + @Test + public void testSetCpuAllocatedWithNullCpuSpeed() { + String expected = null; + final HostMetricsResponse hostResponse = new HostMetricsResponse(); + hostResponse.setCpuAllocated(String.format("50%s25%%", decimalSeparator), 10, null); + Assert.assertEquals(expected, hostResponse.getCpuAllocatedGhz()); + } }