From c79ab570b0f80caeaba301e0aa4a5758f676b346 Mon Sep 17 00:00:00 2001 From: Daan Hoogland Date: Tue, 24 Jun 2014 10:24:01 +0200 Subject: [PATCH] Revert "CLOUDSTACK-6967: Initial OVM3 drop" This reverts commit 8a485b9b59e4108e862022baf7477f768380b325. --- api/src/com/cloud/hypervisor/Hypervisor.java | 5 -- api/src/com/cloud/network/NetworkService.java | 4 +- .../network/PhysicalNetworkTrafficType.java | 2 - .../apache/cloudstack/api/ApiConstants.java | 4 - .../command/admin/cluster/AddClusterCmd.java | 18 +--- .../admin/usage/AddTrafficTypeCmd.java | 11 +-- .../admin/usage/UpdateTrafficTypeCmd.java | 11 +-- .../api/response/ClusterResponse.java | 12 --- .../api/response/TrafficTypeResponse.java | 12 --- .../classes/resources/messages.properties | 4 - client/pom.xml | 5 -- .../PhysicalNetworkTrafficTypeDaoImpl.java | 9 -- .../dao/PhysicalNetworkTrafficTypeVO.java | 16 +--- .../storage/snapshot/SnapshotObject.java | 10 +-- plugins/pom.xml | 1 - .../storage/secondary/cloud-install-sys-tmplt | 27 +++--- scripts/storage/secondary/createtmplt.sh | 2 +- .../src/com/cloud/configuration/Config.java | 10 +-- .../ConfigurationManagerImpl.java | 2 +- .../com/cloud/network/NetworkModelImpl.java | 13 +-- .../com/cloud/network/NetworkServiceImpl.java | 12 +-- .../VirtualNetworkApplianceManagerImpl.java | 1 - .../cloud/resource/ResourceManagerImpl.java | 8 -- .../cloud/server/ManagementServerImpl.java | 7 +- .../storage/listener/StoragePoolMonitor.java | 3 +- .../src/com/cloud/vm/UserVmManagerImpl.java | 6 +- .../com/cloud/vpc/MockNetworkManagerImpl.java | 6 +- setup/db/create-schema.sql | 3 - setup/db/db/schema-410to420.sql | 3 +- setup/db/templates.sql | 20 +---- ui/dictionary.jsp | 3 - ui/scripts/docs.js | 12 --- ui/scripts/system.js | 89 ++----------------- ui/scripts/templates.js | 6 -- ui/scripts/zoneWizard.js | 43 +-------- 35 files changed, 47 insertions(+), 353 deletions(-) diff --git a/api/src/com/cloud/hypervisor/Hypervisor.java b/api/src/com/cloud/hypervisor/Hypervisor.java index f8868af9278..f8b98cf49dd 100644 --- a/api/src/com/cloud/hypervisor/Hypervisor.java +++ b/api/src/com/cloud/hypervisor/Hypervisor.java @@ -31,7 +31,6 @@ public class Hypervisor { BareMetal, Simulator, Ovm, - Ovm3, LXC, Any; /*If you don't care about the hypervisor type*/ @@ -58,8 +57,6 @@ public class Hypervisor { return HypervisorType.Simulator; } else if (hypervisor.equalsIgnoreCase("Ovm")) { return HypervisorType.Ovm; - } else if (hypervisor.equalsIgnoreCase("Ovm3")) { - return HypervisorType.Ovm3; } else if (hypervisor.equalsIgnoreCase("LXC")) { return HypervisorType.LXC; } else if (hypervisor.equalsIgnoreCase("Any")) { @@ -84,8 +81,6 @@ public class Hypervisor { return ImageFormat.OVA; } else if (hyperType == HypervisorType.Ovm) { return ImageFormat.RAW; - } else if (hyperType == HypervisorType.Ovm3) { - return ImageFormat.RAW; } else { return null; } diff --git a/api/src/com/cloud/network/NetworkService.java b/api/src/com/cloud/network/NetworkService.java index 646dcb647ef..1e126f52aee 100755 --- a/api/src/com/cloud/network/NetworkService.java +++ b/api/src/com/cloud/network/NetworkService.java @@ -111,11 +111,11 @@ public interface NetworkService { long findPhysicalNetworkId(long zoneId, String tag, TrafficType trafficType); PhysicalNetworkTrafficType addTrafficTypeToPhysicalNetwork(Long physicalNetworkId, String trafficType, String isolationMethod, String xenLabel, String kvmLabel, String vmwareLabel, - String simulatorLabel, String vlan, String hypervLabel, String ovm3Label); + String simulatorLabel, String vlan, String hypervLabel); PhysicalNetworkTrafficType getPhysicalNetworkTrafficType(Long id); - PhysicalNetworkTrafficType updatePhysicalNetworkTrafficType(Long id, String xenLabel, String kvmLabel, String vmwareLabel, String hypervLabel, String ovm3Label); + PhysicalNetworkTrafficType updatePhysicalNetworkTrafficType(Long id, String xenLabel, String kvmLabel, String vmwareLabel, String hypervLabel); boolean deletePhysicalNetworkTrafficType(Long id); diff --git a/api/src/com/cloud/network/PhysicalNetworkTrafficType.java b/api/src/com/cloud/network/PhysicalNetworkTrafficType.java index 9676badb4e9..a50aa37b8db 100644 --- a/api/src/com/cloud/network/PhysicalNetworkTrafficType.java +++ b/api/src/com/cloud/network/PhysicalNetworkTrafficType.java @@ -39,6 +39,4 @@ public interface PhysicalNetworkTrafficType extends InternalIdentity, Identity { String getSimulatorNetworkLabel(); String getHypervNetworkLabel(); - - String getOvm3NetworkLabel(); } diff --git a/api/src/org/apache/cloudstack/api/ApiConstants.java b/api/src/org/apache/cloudstack/api/ApiConstants.java index 70ba1445bf2..adda5f4cee2 100755 --- a/api/src/org/apache/cloudstack/api/ApiConstants.java +++ b/api/src/org/apache/cloudstack/api/ApiConstants.java @@ -379,7 +379,6 @@ public class ApiConstants { public static final String LOCAL_STORAGE_ENABLED = "localstorageenabled"; public static final String GUEST_IP_TYPE = "guestiptype"; public static final String XENSERVER_NETWORK_LABEL = "xenservernetworklabel"; - public static final String OVM3_NETWORK_LABEL = "ovm3networklabel"; public static final String KVM_NETWORK_LABEL = "kvmnetworklabel"; public static final String VMWARE_NETWORK_LABEL = "vmwarenetworklabel"; public static final String HYPERV_NETWORK_LABEL = "hypervnetworklabel"; @@ -462,9 +461,6 @@ public class ApiConstants { public static final String VSM_CONFIG_MODE = "vsmconfigmode"; public static final String VSM_CONFIG_STATE = "vsmconfigstate"; public static final String VSM_DEVICE_STATE = "vsmdevicestate"; - public static final String OVM3_POOL = "ovm3pool"; - public static final String OVM3_CLUSTER = "ovm3cluster"; - public static final String OVM3_VIP = "ovm3vip"; public static final String VCENTER = "vcenter"; public static final String ADD_VSM_FLAG = "addvsmflag"; public static final String END_POINT = "endpoint"; diff --git a/api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java b/api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java index c42886cdca1..b9df18e01ed 100644 --- a/api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java +++ b/api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java @@ -66,7 +66,7 @@ public class AddClusterCmd extends BaseCmd { @Parameter(name = ApiConstants.HYPERVISOR, type = CommandType.STRING, required = true, - description = "hypervisor type of the cluster: XenServer,KVM,VMware,Hyperv,BareMetal,Simulator,Ovm3") + description = "hypervisor type of the cluster: XenServer,KVM,VMware,Hyperv,BareMetal,Simulator") private String hypervisor; @Parameter(name = ApiConstants.CLUSTER_TYPE, type = CommandType.STRING, required = true, description = "type of the cluster: CloudManaged, ExternalManaged") @@ -75,22 +75,6 @@ public class AddClusterCmd extends BaseCmd { @Parameter(name = ApiConstants.ALLOCATION_STATE, type = CommandType.STRING, description = "Allocation state of this cluster for allocation of new resources") private String allocationState; - @Parameter(name = ApiConstants.OVM3_POOL, type = CommandType.STRING, required = false, description = "Ovm3 native pooling enabled for cluster") - private String ovm3pool; - @Parameter(name = ApiConstants.OVM3_CLUSTER, type = CommandType.STRING, required = false, description = "Ovm3 native OCFS2 clustering enabled for cluster") - private String ovm3cluster; - @Parameter(name = ApiConstants.OVM3_VIP, type = CommandType.STRING, required = false, description = "Ovm3 vip to use for pool (and cluster)") - private String ovm3vip; - public String getOvm3Pool() { - return ovm3pool; - } - public String getOvm3Cluster() { - return ovm3cluster; - } - public String getOvm3Vip() { - return ovm3vip; - } - @Parameter(name = ApiConstants.VSM_USERNAME, type = CommandType.STRING, required = false, description = "the username for the VSM associated with this cluster") private String vsmusername; diff --git a/api/src/org/apache/cloudstack/api/command/admin/usage/AddTrafficTypeCmd.java b/api/src/org/apache/cloudstack/api/command/admin/usage/AddTrafficTypeCmd.java index ba9015ffc64..5f1188e74bc 100644 --- a/api/src/org/apache/cloudstack/api/command/admin/usage/AddTrafficTypeCmd.java +++ b/api/src/org/apache/cloudstack/api/command/admin/usage/AddTrafficTypeCmd.java @@ -65,11 +65,6 @@ public class AddTrafficTypeCmd extends BaseAsyncCreateCmd { description = "The network name label of the physical device dedicated to this traffic on a KVM host") private String kvmLabel; - @Parameter(name = ApiConstants.OVM3_NETWORK_LABEL, - type = CommandType.STRING, - description = "The network name of the physical device dedicated to this traffic on an OVM3 host") - private String ovm3Label; - @Parameter(name = ApiConstants.VMWARE_NETWORK_LABEL, type = CommandType.STRING, description = "The network name label of the physical device dedicated to this traffic on a VMware host") @@ -107,10 +102,6 @@ public class AddTrafficTypeCmd extends BaseAsyncCreateCmd { return kvmLabel; } - public String getOvm3Label() { - return ovm3Label; - } - public String getVmwareLabel() { return vmwareLabel; } @@ -171,7 +162,7 @@ public class AddTrafficTypeCmd extends BaseAsyncCreateCmd { public void create() throws ResourceAllocationException { PhysicalNetworkTrafficType result = _networkService.addTrafficTypeToPhysicalNetwork(getPhysicalNetworkId(), getTrafficType(), getIsolationMethod(), getXenLabel(), getKvmLabel(), getVmwareLabel(), - getSimulatorLabel(), getVlan(), getHypervLabel(), getOvm3Label()); + getSimulatorLabel(), getVlan(), getHypervLabel()); if (result != null) { setEntityId(result.getId()); setEntityUuid(result.getUuid()); diff --git a/api/src/org/apache/cloudstack/api/command/admin/usage/UpdateTrafficTypeCmd.java b/api/src/org/apache/cloudstack/api/command/admin/usage/UpdateTrafficTypeCmd.java index 8a8aeb2af56..68a9431ce84 100644 --- a/api/src/org/apache/cloudstack/api/command/admin/usage/UpdateTrafficTypeCmd.java +++ b/api/src/org/apache/cloudstack/api/command/admin/usage/UpdateTrafficTypeCmd.java @@ -55,11 +55,6 @@ public class UpdateTrafficTypeCmd extends BaseAsyncCmd { description = "The network name label of the physical device dedicated to this traffic on a KVM host") private String kvmLabel; - @Parameter(name = ApiConstants.OVM3_NETWORK_LABEL, - type = CommandType.STRING, - description = "The network name of the physical device dedicated to this traffic on an OVM3 host") - private String ovm3Label; - @Parameter(name = ApiConstants.VMWARE_NETWORK_LABEL, type = CommandType.STRING, description = "The network name label of the physical device dedicated to this traffic on a VMware host") @@ -86,10 +81,6 @@ public class UpdateTrafficTypeCmd extends BaseAsyncCmd { return kvmLabel; } - public String getOvm3Label() { - return ovm3Label; - } - public String getVmwareLabel() { return vmwareLabel; } @@ -114,7 +105,7 @@ public class UpdateTrafficTypeCmd extends BaseAsyncCmd { @Override public void execute() { - PhysicalNetworkTrafficType result = _networkService.updatePhysicalNetworkTrafficType(getId(), getXenLabel(), getKvmLabel(), getVmwareLabel(), getHypervLabel(), getOvm3Label()); + PhysicalNetworkTrafficType result = _networkService.updatePhysicalNetworkTrafficType(getId(), getXenLabel(), getKvmLabel(), getVmwareLabel(), getHypervLabel()); if (result != null) { TrafficTypeResponse response = _responseGenerator.createTrafficTypeResponse(result); response.setResponseName(getCommandName()); diff --git a/api/src/org/apache/cloudstack/api/response/ClusterResponse.java b/api/src/org/apache/cloudstack/api/response/ClusterResponse.java index df01e09595b..08903091eba 100644 --- a/api/src/org/apache/cloudstack/api/response/ClusterResponse.java +++ b/api/src/org/apache/cloudstack/api/response/ClusterResponse.java @@ -82,10 +82,6 @@ public class ClusterResponse extends BaseResponse { @Param(description = "The memory overcommit ratio of the cluster") private String memoryovercommitratio; - @SerializedName("ovm3vip") - @Param(description = "Ovm3 VIP to use for pooling and/or clustering") - private String ovm3vip; - public String getId() { return id; } @@ -189,12 +185,4 @@ public class ClusterResponse extends BaseResponse { public String getMemoryOvercommitRatio() { return memoryovercommitratio; } - - public void setOvm3Vip(String ovm3vip) { - this.ovm3vip = ovm3vip; - } - - public String getOvm3Vip() { - return ovm3vip; - } } diff --git a/api/src/org/apache/cloudstack/api/response/TrafficTypeResponse.java b/api/src/org/apache/cloudstack/api/response/TrafficTypeResponse.java index d8a98786695..84ed2e69d86 100644 --- a/api/src/org/apache/cloudstack/api/response/TrafficTypeResponse.java +++ b/api/src/org/apache/cloudstack/api/response/TrafficTypeResponse.java @@ -48,10 +48,6 @@ public class TrafficTypeResponse extends BaseResponse { @Param(description = "The network name label of the physical device dedicated to this traffic on a KVM host") private String kvmNetworkLabel; - @SerializedName(ApiConstants.OVM3_NETWORK_LABEL) - @Param(description = "The network name of the physical device dedicated to this traffic on an OVM3 host") - private String ovm3NetworkLabel; - @SerializedName(ApiConstants.VMWARE_NETWORK_LABEL) @Param(description = "The network name label of the physical device dedicated to this traffic on a VMware host") private String vmwareNetworkLabel; @@ -97,10 +93,6 @@ public class TrafficTypeResponse extends BaseResponse { return kvmNetworkLabel; } - public String getOvm3Label() { - return ovm3NetworkLabel; - } - public String getHypervLabel() { return hypervNetworkLabel; } @@ -117,10 +109,6 @@ public class TrafficTypeResponse extends BaseResponse { this.kvmNetworkLabel = kvmLabel; } - public void setOvm3Label(String ovm3Label) { - this.ovm3NetworkLabel = ovm3Label; - } - public void setVmwareLabel(String vmwareNetworkLabel) { this.vmwareNetworkLabel = vmwareNetworkLabel; } diff --git a/client/WEB-INF/classes/resources/messages.properties b/client/WEB-INF/classes/resources/messages.properties index 9ab35098d08..b504a18d020 100644 --- a/client/WEB-INF/classes/resources/messages.properties +++ b/client/WEB-INF/classes/resources/messages.properties @@ -378,10 +378,6 @@ label.affinity.groups=Affinity Groups label.affinity=Affinity label.agent.password=Agent Password label.agent.username=Agent Username -label.agent.port=Agent Port -label.ovm3.vip=Master Vip IP -label.ovm3.pool=Native Pooling -label.ovm3.cluster=Native Clustering label.agree=Agree label.alert=Alert label.algorithm=Algorithm diff --git a/client/pom.xml b/client/pom.xml index cfa1bec3f1a..29fef4f335e 100644 --- a/client/pom.xml +++ b/client/pom.xml @@ -165,11 +165,6 @@ cloud-plugin-hypervisor-ovm ${project.version} - - org.apache.cloudstack - cloud-plugin-hypervisor-ovm3 - ${project.version} - org.apache.cloudstack cloud-plugin-hypervisor-kvm diff --git a/engine/schema/src/com/cloud/network/dao/PhysicalNetworkTrafficTypeDaoImpl.java b/engine/schema/src/com/cloud/network/dao/PhysicalNetworkTrafficTypeDaoImpl.java index fe7d49c4015..4e8e0179d37 100755 --- a/engine/schema/src/com/cloud/network/dao/PhysicalNetworkTrafficTypeDaoImpl.java +++ b/engine/schema/src/com/cloud/network/dao/PhysicalNetworkTrafficTypeDaoImpl.java @@ -43,7 +43,6 @@ public class PhysicalNetworkTrafficTypeDaoImpl extends GenericDaoBase simulatorAllFieldsSearch; final GenericSearchBuilder ovmAllFieldsSearch; final GenericSearchBuilder hypervAllFieldsSearch; - final GenericSearchBuilder ovm3AllFieldsSearch; protected PhysicalNetworkTrafficTypeDaoImpl() { super(); @@ -87,12 +86,6 @@ public class PhysicalNetworkTrafficTypeDaoImpl extends GenericDaoBasededicated-resources hypervisors/ovm hypervisors/xenserver - hypervisors/ovm3 hypervisors/kvm event-bus/rabbitmq event-bus/inmemory diff --git a/scripts/storage/secondary/cloud-install-sys-tmplt b/scripts/storage/secondary/cloud-install-sys-tmplt index a6de3ad96fe..96b11de41d4 100755 --- a/scripts/storage/secondary/cloud-install-sys-tmplt +++ b/scripts/storage/secondary/cloud-install-sys-tmplt @@ -20,9 +20,9 @@ usage() { - printf "Usage: %s: -m -f [-h ] [ -s ][-u ] [-F ] [-e