diff --git a/server/src/com/cloud/agent/manager/AgentManagerImpl.java b/server/src/com/cloud/agent/manager/AgentManagerImpl.java index 5d0ff918307..0bf509d5c92 100755 --- a/server/src/com/cloud/agent/manager/AgentManagerImpl.java +++ b/server/src/com/cloud/agent/manager/AgentManagerImpl.java @@ -163,6 +163,7 @@ import com.cloud.utils.db.DB; import com.cloud.utils.db.SearchCriteria; import com.cloud.utils.db.Transaction; import com.cloud.utils.exception.CloudRuntimeException; +import com.cloud.utils.net.Ip; import com.cloud.utils.net.MacAddress; import com.cloud.utils.net.NetUtils; import com.cloud.utils.nio.HandlerFactory; @@ -1916,7 +1917,7 @@ public class AgentManagerImpl implements AgentManager, HandlerFactory, ResourceS } } - if (serverPublicIP != null && !_publicIPAddressDao.mark(dc.getId(), serverPublicIP)) { + if (serverPublicIP != null && !_publicIPAddressDao.mark(dc.getId(), new Ip(serverPublicIP))) { // If the server's public IP address is already in the database, // return false List existingPublicIPs = _publicIPAddressDao.listByDcIdIpAddress(dc.getId(), serverPublicIP); diff --git a/server/src/com/cloud/network/dao/IPAddressDao.java b/server/src/com/cloud/network/dao/IPAddressDao.java index 4a1f5922a25..f7a179ff1ec 100644 --- a/server/src/com/cloud/network/dao/IPAddressDao.java +++ b/server/src/com/cloud/network/dao/IPAddressDao.java @@ -40,7 +40,7 @@ public interface IPAddressDao extends GenericDao { int countIPs(long dcId, Long accountId, String vlanId, String vlanGateway, String vlanNetmask); - boolean mark(long dcId, String ip); + boolean mark(long dcId, Ip ip); List assignAcccountSpecificIps(long accountId, long longValue, Long vlanDbId, boolean sourceNat); diff --git a/server/src/com/cloud/network/dao/IPAddressDaoImpl.java b/server/src/com/cloud/network/dao/IPAddressDaoImpl.java index 03b54c7005b..a587266504b 100644 --- a/server/src/com/cloud/network/dao/IPAddressDaoImpl.java +++ b/server/src/com/cloud/network/dao/IPAddressDaoImpl.java @@ -97,7 +97,7 @@ public class IPAddressDaoImpl extends GenericDaoBase implements } @Override - public boolean mark(long dcId, String ip) { + public boolean mark(long dcId, Ip ip) { SearchCriteria sc = AllFieldsSearch.create(); sc.setParameters("dataCenterId", dcId); sc.setParameters("ipAddress", ip);