Add three more pre-commit checks (#7083)

Co-authored-by: dahn <daan@onecht.net>

.pre-commit-config.yaml

@@ -26,17 +26,18 @@ repos:
       - id: identity
       - id: check-hooks-apply
   - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v4.1.0
+    rev: v4.4.0
     hooks:
       #- id: check-added-large-files
-      #- id: check-case-conflict
+      - id: check-case-conflict
       #- id: check-executables-have-shebangs
       #- id: check-merge-conflict
-      #- id: check-vcs-permalinks
+      - id: check-vcs-permalinks
       #- id: check-yaml
       #- id: detect-private-key
-      #- id: end-of-file-fixer
+      - id: end-of-file-fixer
+        files: \.(java|md|py|txt|yaml|yml)$
       #- id: fix-byte-order-marker
       - id: mixed-line-ending
-        files: \.(java|py)$
+        files: \.(java|md|py|txt|yaml|yml)$
       # - id: trailing-whitespace

api/src/main/java/org/apache/cloudstack/api/command/admin/direct/download/UploadTemplateDirectDownloadCertificateCmd.java

@@ -113,5 +113,3 @@ public class UploadTemplateDirectDownloadCertificateCmd extends BaseCmd {
         return CallContext.current().getCallingAccount().getId();
     }
 }
-
-

api/src/main/java/org/apache/cloudstack/api/command/admin/template/CopyTemplateCmdByAdmin.java

@@ -24,4 +24,3 @@ import org.apache.cloudstack.api.response.TemplateResponse;
 @APICommand(name = "copyTemplate", description = "Copies a template from one zone to another.", responseObject = TemplateResponse.class, responseView = ResponseView.Full,
         requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
 public class CopyTemplateCmdByAdmin extends CopyTemplateCmd {}
-

api/src/test/java/org/apache/cloudstack/api/command/user/template/CopyTemplateCmdByAdminTest.java

@@ -74,4 +74,3 @@ public class CopyTemplateCmdByAdminTest{
 
 
 }
-

api/src/test/java/org/apache/cloudstack/api/command/user/template/CopyTemplateCmdTest.java

@@ -72,4 +72,3 @@ public class CopyTemplateCmdTest{
 
 
 }
-

core/src/main/java/com/cloud/agent/api/routing/SetPortForwardingRulesCommand.java

@@ -41,4 +41,3 @@ public class SetPortForwardingRulesCommand extends NetworkElementCommand {
         return rules;
     }
 }
-

core/src/main/java/com/cloud/host/HostInfo.java

@@ -26,4 +26,3 @@ public final class HostInfo {
     public static final String HOST_OS_KERNEL_VERSION = "Host.OS.Kernel.Version"; //linux-2.6.31 etc
     public static final String XS620_SNAPSHOT_HOTFIX = "xs620_snapshot_hotfix";
 }
-

core/src/main/java/org/apache/cloudstack/storage/command/MoveVolumeCommand.java

@@ -63,4 +63,3 @@ public class MoveVolumeCommand extends Command {
     }
 
  }
-

engine/components-api/src/main/java/com/cloud/network/IpAddressManager.java

@@ -234,4 +234,3 @@ public interface IpAddressManager {
     public static final String MESSAGE_ASSIGN_IPADDR_EVENT = "Message.AssignIpAddr.Event";
     public static final String MESSAGE_RELEASE_IPADDR_EVENT = "Message.ReleaseIpAddr.Event";
 }
-

engine/schema/src/main/java/com/cloud/service/dao/ServiceOfferingDetailsDao.java

@@ -29,4 +29,3 @@ public interface ServiceOfferingDetailsDao extends GenericDao<ServiceOfferingDet
     String getDetail(Long diskOfferingId, String key);
     List<Long> findOfferingIdsByDomainIds(List<Long> domainIds);
 }
-

engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade40to41.java

@@ -185,4 +185,3 @@ public class Upgrade40to41 implements DbUpgrade {
     }
 
 }
-

engine/schema/src/main/java/org/apache/cloudstack/resourcedetail/Site2SiteVpnGatewayDetailVO.java

@@ -80,6 +80,3 @@ public class Site2SiteVpnGatewayDetailVO implements ResourceDetail {
         return display;
     }
 }
-
-
-

engine/schema/src/main/java/org/apache/cloudstack/resourcedetail/dao/DiskOfferingDetailsDao.java

@@ -29,4 +29,3 @@ public interface DiskOfferingDetailsDao extends GenericDao<DiskOfferingDetailVO,
     String getDetail(Long diskOfferingId, String key);
     List<Long> findOfferingIdsByDomainIds(List<Long> domainIds);
 }
-

engine/schema/src/main/java/org/apache/cloudstack/resourcedetail/dao/DiskOfferingDetailsDaoImpl.java

@@ -74,4 +74,3 @@ public class DiskOfferingDetailsDaoImpl extends ResourceDetailsDaoBase<DiskOffer
         return findResourceIdsByNameAndValueIn("domainid", dIds);
     }
 }
-

engine/schema/src/main/java/org/apache/cloudstack/resourcedetail/dao/Site2SiteVpnGatewayDetailsDao.java

@@ -24,4 +24,3 @@ import com.cloud.utils.db.GenericDao;
 public interface Site2SiteVpnGatewayDetailsDao extends GenericDao<Site2SiteVpnGatewayDetailVO, Long>, ResourceDetailsDao<Site2SiteVpnGatewayDetailVO> {
 
 }
-

engine/schema/src/test/java/com/cloud/vm/dao/VMInstanceDaoImplTest.java

@@ -68,5 +68,3 @@ public class VMInstanceDaoImplTest {
     }
 
 }
-
-

engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/SecondaryStorageServiceImpl.java

@@ -247,5 +247,3 @@ public class SecondaryStorageServiceImpl implements SecondaryStorageService {
         }
     }
 }
-
-

plugins/hypervisors/hyperv/DotNet/ServerResource/WmiWrappers/Readme.txt

@@ -14,7 +14,3 @@ ALSO, you have to tweak the generated code to expose useful details such as the
 E.g. the generated code creates a wrapper called class ComputerSystem for WMI objects of class Msvm_ComputerSystem.
 Thus, there is a mismatch in the class name and the corresponding WMI class, and the WMI class name is a private
 constant static member.  The tweak involves making this member public.
-
-
-
-

plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtPatchSystemVmCommandWrapper.java

@@ -109,4 +109,3 @@ public class LibvirtPatchSystemVmCommandWrapper extends CommandWrapper<PatchSyst
         return result;
     }
 }
-

plugins/integrations/kubernetes-service/src/main/resources/conf/k8s-control-node.yml

@@ -326,4 +326,3 @@ runcmd:
   - /opt/bin/setup-kube-system
   - until [ -f /etc/systemd/system/deploy-kube-system.service ]; do sleep 5; done
   - systemctl start deploy-kube-system
-

plugins/network-elements/tungsten/src/main/java/org/apache/cloudstack/network/tungsten/api/command/ListTungstenFabricProvidersCmd.java

@@ -85,4 +85,3 @@ public class ListTungstenFabricProvidersCmd extends BaseListCmd {
         setResponseObject(listResponse);
     }
 }
-

plugins/network-elements/tungsten/src/main/java/org/apache/cloudstack/network/tungsten/vrouter/Gateway.java

@@ -72,4 +72,3 @@ public class Gateway {
         this.routes = routes;
     }
 }
-

plugins/network-elements/tungsten/src/main/java/org/apache/cloudstack/network/tungsten/vrouter/Subnet.java

@@ -45,4 +45,3 @@ public class Subnet {
         this.length = length;
     }
 }
-

plugins/network-elements/tungsten/src/test/java/org/apache/cloudstack/network/tungsten/api/command/ListTungstenFabricProvidersCmdTest.java

@@ -72,4 +72,3 @@ public class ListTungstenFabricProvidersCmdTest {
         Assert.assertEquals(responseList, listTungstenFabricProvidersCmd.getResponseObject());
     }
 }
-

services/console-proxy/rdpconsole/src/main/java/rdpclient/ntlmssp/package-info.java

@@ -68,4 +68,3 @@ END
 For packet flow, @see http://msdn.microsoft.com/en-us/library/cc226794.aspx
  */
 package rdpclient.ntlmssp;
-

services/console-proxy/rdpconsole/src/main/java/rdpclient/rdp/ClientSynchronizePDU.java

@@ -245,4 +245,3 @@ public class ClientSynchronizePDU extends OneTimeSwitch {
         MessageType: 0x1, MUST be set to SYNCMSGTYPE_SYNC (1)
         TargetUser: 1002 (0x3EA)
  */
-

tools/appliance/README.md

@@ -40,4 +40,3 @@ VMWare and HyperV in `dist` directory:
 
     bash build.sh systemvmtemplate
     bash build.sh builtin
-

tools/devcloud4/advanced/README.md

@@ -91,5 +91,3 @@ vagrant up
     ```
     python -m marvin.deployDataCenter -i marvin.cfg 
     ```
-
-

tools/marvin/marvin/misc/build/README.md

@@ -64,4 +64,3 @@ OR
 
 ### 5. wait for templates and system VMs to be ready
 `$ nosetests -v --with-marvin --marvin-config=deployment.cfg --result-log=result.log testSetupSuccess.py`
-

utils/src/main/java/org/apache/cloudstack/utils/imagestore/ImageStoreUtil.java

@@ -107,4 +107,3 @@ public class ImageStoreUtil {
                        .anyMatch(lowerCasePath::endsWith);
     }
 }
-

vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/PbmProfileManagerMO.java

@@ -100,5 +100,3 @@ public class PbmProfileManagerMO extends BaseMO {
     }
 
 }
-
-