diff --git a/services/secondary-storage/controller/src/main/java/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImpl.java b/services/secondary-storage/controller/src/main/java/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImpl.java index ec1e8a81979..dc6b042fc3a 100644 --- a/services/secondary-storage/controller/src/main/java/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImpl.java +++ b/services/secondary-storage/controller/src/main/java/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImpl.java @@ -400,10 +400,13 @@ public class SecondaryStorageManagerImpl extends ManagerBase implements Secondar } String[] cidrs = _allowedInternalSites.split(","); for (String cidr : cidrs) { - if (NetUtils.isValidIp4Cidr(cidr) || NetUtils.isValidIp4(cidr) || !cidr.startsWith("0.0.0.0")) { - if (NetUtils.getCleanIp4Cidr(cidr).equals(cidr)) { - logger.warn(String.format("Invalid CIDR %s in %s", cidr, SecStorageAllowedInternalDownloadSites.key())); + if (NetUtils.isValidIp4Cidr(cidr) && !cidr.startsWith("0.0.0.0")) { + if (! NetUtils.getCleanIp4Cidr(cidr).equals(cidr)) { + logger.warn("Invalid CIDR {} in {}", cidr, SecStorageAllowedInternalDownloadSites.key()); } + allowedCidrs.add(NetUtils.getCleanIp4Cidr(cidr)); + } else if (NetUtils.isValidIp4(cidr) && !cidr.startsWith("0.0.0.0")) { + logger.warn("Ip address is not a valid CIDR; {} consider using {}/32", cidr, cidr); allowedCidrs.add(cidr); } } diff --git a/vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java b/vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java index 5f73a42e3c6..c0ada87491b 100644 --- a/vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java +++ b/vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java @@ -3167,9 +3167,12 @@ public class VirtualMachineMO extends BaseMO { int deviceCount = 0; int ideDeviceUnitNumber = -1; - if (devices != null && devices.size() > 0) { + if (devices != null) { for (VirtualDevice device : devices) { - if (device instanceof VirtualDisk && (controllerKey == device.getControllerKey())) { + if (device.getControllerKey() == null || device.getControllerKey() != controllerKey) { + continue; + } + if (device instanceof VirtualDisk || device instanceof VirtualCdrom) { deviceCount++; ideDeviceUnitNumber = device.getUnitNumber(); }