From b4464d88d34f2de8a57133eedf69eaa3f5f7bdec Mon Sep 17 00:00:00 2001 From: Kishan Kavala Date: Tue, 13 Aug 2013 17:24:27 +0530 Subject: [PATCH] CLOUDSTACK-4281 : Usage - exception was hiding the db error. Make the usage job fail incase of any DB insert exceptions --- usage/src/com/cloud/usage/parser/NetworkUsageParser.java | 7 ++----- usage/src/com/cloud/usage/parser/VmDiskUsageParser.java | 6 +----- 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/usage/src/com/cloud/usage/parser/NetworkUsageParser.java b/usage/src/com/cloud/usage/parser/NetworkUsageParser.java index f2f24e460c9..4bf62d9e75b 100644 --- a/usage/src/com/cloud/usage/parser/NetworkUsageParser.java +++ b/usage/src/com/cloud/usage/parser/NetworkUsageParser.java @@ -129,11 +129,8 @@ public static final Logger s_logger = Logger.getLogger(NetworkUsageParser.class. } } } - try { - m_usageDao.saveUsageRecords(usageRecords); - } catch (Exception ex) { - s_logger.error("Exception in usage manager", ex); - } + + m_usageDao.saveUsageRecords(usageRecords); return true; } diff --git a/usage/src/com/cloud/usage/parser/VmDiskUsageParser.java b/usage/src/com/cloud/usage/parser/VmDiskUsageParser.java index 84bdfd2950f..b0cb2ff1b1d 100644 --- a/usage/src/com/cloud/usage/parser/VmDiskUsageParser.java +++ b/usage/src/com/cloud/usage/parser/VmDiskUsageParser.java @@ -157,11 +157,7 @@ public static final Logger s_logger = Logger.getLogger(VmDiskUsageParser.class.g } } - try { - m_usageDao.saveUsageRecords(usageRecords); - } catch (Exception ex) { - s_logger.error("Exception in usage manager", ex); - } + m_usageDao.saveUsageRecords(usageRecords); return true; }