diff --git a/server/src/com/cloud/network/NetworkManagerImpl.java b/server/src/com/cloud/network/NetworkManagerImpl.java index 283212280e4..541082e83c1 100755 --- a/server/src/com/cloud/network/NetworkManagerImpl.java +++ b/server/src/com/cloud/network/NetworkManagerImpl.java @@ -3616,7 +3616,7 @@ public class NetworkManagerImpl extends ManagerBase implements NetworkManager, L //revoke all network ACLs for network try { - if (_networkACLMgr.revokeACLItemsForNetwork(networkId, callerUserId, caller)) { + if (_networkACLMgr.revokeACLItemsForNetwork(networkId)) { s_logger.debug("Successfully cleaned up NetworkACLs for network id=" + networkId); } else { success = false; @@ -3785,7 +3785,7 @@ public class NetworkManagerImpl extends ManagerBase implements NetworkManager, L try { //revoke all Network ACLs for the network w/o applying them in the DB - if (!_networkACLMgr.revokeACLItemsForNetwork(networkId, callerUserId, caller)) { + if (!_networkACLMgr.revokeACLItemsForNetwork(networkId)) { s_logger.warn("Failed to cleanup network ACLs as a part of shutdownNetworkRules"); success = false; } diff --git a/server/src/com/cloud/network/vpc/NetworkACLManager.java b/server/src/com/cloud/network/vpc/NetworkACLManager.java index 8a2e65f0148..463e43b4b21 100644 --- a/server/src/com/cloud/network/vpc/NetworkACLManager.java +++ b/server/src/com/cloud/network/vpc/NetworkACLManager.java @@ -104,7 +104,7 @@ public interface NetworkACLManager{ * @return * @throws ResourceUnavailableException */ - boolean revokeACLItemsForNetwork(long networkId, long userId, Account caller) throws ResourceUnavailableException; + boolean revokeACLItemsForNetwork(long networkId) throws ResourceUnavailableException; /** * List network ACL items by network diff --git a/server/src/com/cloud/network/vpc/NetworkACLManagerImpl.java b/server/src/com/cloud/network/vpc/NetworkACLManagerImpl.java index 227975eb9c1..c2d092a48b7 100644 --- a/server/src/com/cloud/network/vpc/NetworkACLManagerImpl.java +++ b/server/src/com/cloud/network/vpc/NetworkACLManagerImpl.java @@ -150,6 +150,18 @@ public class NetworkACLManagerImpl extends ManagerBase implements NetworkACLMana throw new InvalidParameterValueException("Cannot apply NetworkACL. Network Offering does not support NetworkACL service"); } + if(network.getNetworkACLId() != null){ + //Revoke ACL Items of the existing ACL if the new ACL is empty + //Existing rules won't be removed otherwise + List aclItems = _networkACLItemDao.listByACL(acl.getId()); + if(aclItems == null || aclItems.isEmpty()){ + s_logger.debug("New network ACL is empty. Revoke existing rules before applying ACL"); + if(!revokeACLItemsForNetwork(network.getId())){ + throw new CloudRuntimeException("Failed to replace network ACL. Error while removing existing ACL items for network: "+network.getId()); + } + } + } + network.setNetworkACLId(acl.getId()); //Update Network ACL if(_networkDao.update(network.getId(), network)){ @@ -229,7 +241,7 @@ public class NetworkACLManagerImpl extends ManagerBase implements NetworkACLMana } @Override - public boolean revokeACLItemsForNetwork(long networkId, long userId, Account caller) throws ResourceUnavailableException { + public boolean revokeACLItemsForNetwork(long networkId) throws ResourceUnavailableException { Network network = _networkDao.findById(networkId); if(network.getNetworkACLId() == null){ return true; diff --git a/server/src/com/cloud/network/vpc/NetworkACLServiceImpl.java b/server/src/com/cloud/network/vpc/NetworkACLServiceImpl.java index b4ec22dab6a..b0c807efdd3 100644 --- a/server/src/com/cloud/network/vpc/NetworkACLServiceImpl.java +++ b/server/src/com/cloud/network/vpc/NetworkACLServiceImpl.java @@ -104,7 +104,7 @@ public class NetworkACLServiceImpl extends ManagerBase implements NetworkACLServ SearchBuilder sb = _networkACLDao.createSearchBuilder(); sb.and("id", sb.entity().getId(), Op.EQ); sb.and("name", sb.entity().getName(), Op.EQ); - sb.and("vpcId", sb.entity().getVpcId(), Op.EQ); + sb.and("vpcId", sb.entity().getVpcId(), Op.IN); if(networkId != null){ SearchBuilder network = _networkDao.createSearchBuilder(); @@ -122,7 +122,8 @@ public class NetworkACLServiceImpl extends ManagerBase implements NetworkACLServ } if(vpcId != null){ - sc.setParameters("vpcId", vpcId); + //Include vpcId 0 to list default ACLs + sc.setParameters("vpcId", vpcId, 0); } if(networkId != null){