apache/cloudstack
1
0
Fork 0
mirror of https://github.com/apache/cloudstack.git synced 2025-10-26 08:42:29 +01:00
Code Issues Packages Projects Releases Wiki Activity

kvm: Update the java doc for the method disconnectPhysicalDiskByPath (#9210)

Browse Source 
This PR addresses the issue #8789

The original issue is disconnectPhysicalDiskByPath() implementation in FibreChannelAdaptor always returns true irrespective of the success of the operation. This was already fixed in the PR #8889 .

Ideally this method has to be called after choosing the right adapter based on the storage pool type of the volume path, but currently it is just called in a loop.
05b9b6e2e7/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStoragePoolManager.java (L200-L212)

while trying to fix the case of running into the loop of all adapters by somehow passing the storage pool type to that caller cleanup() method but this is touching all over the code (which I fear it creates other regressions), instead I feel we can keep it the current way only since Fibrechannel adapter has already fixed.

In this PR I've added the java doc explaining the method and situation.
This commit is contained in:
Harikrishna 2024-06-11 14:44:46 +05:30 committed by GitHub
parent 43ab8a9367
commit acae5c5b9e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/StorageAdaptor.java
View File

@ -50,8 +50,17 @@ public interface StorageAdaptor {
public boolean disconnectPhysicalDisk(Map<String, String> volumeToDisconnect);
// given local path to file/device (per Libvirt XML), 1) check that device is
// handled by your adaptor, return false if not. 2) clean up device, return true
/**
* Given local path to file/device (per Libvirt XML),
* 1) Make sure to check that device is handled by your adaptor, return false if not.
* 2) clean up device, return true
* 3) if clean up fails, then return false
*
* If the method wrongly returns true, then there are chances that disconnect will not reach the right storage adapter
*
* @param localPath path for the file/device from the disk definition per Libvirt XML.
* @return true if the operation is successful; false if the operation fails or the adapter fails to handle the path.
*/
public boolean disconnectPhysicalDiskByPath(String localPath);
public boolean deletePhysicalDisk(String uuid, KVMStoragePool pool, Storage.ImageFormat format);