From a8a9b37824cfe4e83d463f676f673dc466b0e17a Mon Sep 17 00:00:00 2001 From: alena Date: Wed, 6 Jul 2011 10:51:20 -0700 Subject: [PATCH] bug 10553: allow networkDomain update for Guest system network in Basic zone status 10553: resolved fixed --- api/src/com/cloud/api/commands/CreateZoneCmd.java | 1 - api/src/com/cloud/api/commands/UpdateNetworkCmd.java | 1 - server/src/com/cloud/network/NetworkManagerImpl.java | 4 ++-- 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/api/src/com/cloud/api/commands/CreateZoneCmd.java b/api/src/com/cloud/api/commands/CreateZoneCmd.java index c150c540dfc..049245dcb5b 100644 --- a/api/src/com/cloud/api/commands/CreateZoneCmd.java +++ b/api/src/com/cloud/api/commands/CreateZoneCmd.java @@ -25,7 +25,6 @@ import com.cloud.api.BaseCmd; import com.cloud.api.Implementation; import com.cloud.api.Parameter; import com.cloud.api.ServerApiException; -import com.cloud.api.BaseCmd.CommandType; import com.cloud.api.response.ZoneResponse; import com.cloud.dc.DataCenter; import com.cloud.user.Account; diff --git a/api/src/com/cloud/api/commands/UpdateNetworkCmd.java b/api/src/com/cloud/api/commands/UpdateNetworkCmd.java index 8add07d7eba..305cf63a97e 100644 --- a/api/src/com/cloud/api/commands/UpdateNetworkCmd.java +++ b/api/src/com/cloud/api/commands/UpdateNetworkCmd.java @@ -27,7 +27,6 @@ import com.cloud.api.BaseCmd; import com.cloud.api.Implementation; import com.cloud.api.Parameter; import com.cloud.api.ServerApiException; -import com.cloud.api.BaseCmd.CommandType; import com.cloud.api.response.NetworkResponse; import com.cloud.exception.ConcurrentOperationException; import com.cloud.exception.InsufficientCapacityException; diff --git a/server/src/com/cloud/network/NetworkManagerImpl.java b/server/src/com/cloud/network/NetworkManagerImpl.java index fb97e26ce71..cd8962c49ad 100755 --- a/server/src/com/cloud/network/NetworkManagerImpl.java +++ b/server/src/com/cloud/network/NetworkManagerImpl.java @@ -2849,9 +2849,9 @@ public class NetworkManagerImpl implements NetworkManager, NetworkService, Manag throw new InvalidParameterException("Unable to support more than one tag on network yet"); } - // Don't allow to update system network + // Don't allow to update system network - make an exception for the Guest network in Basic zone NetworkOffering offering = _networkOfferingDao.findByIdIncludingRemoved(network.getNetworkOfferingId()); - if (offering.isSystemOnly()) { + if (offering.isSystemOnly() && network.getTrafficType() != TrafficType.Guest) { throw new InvalidParameterValueException("Can't update system networks"); }