apache/cloudstack
1
0
Fork 0
mirror of https://github.com/apache/cloudstack.git synced 2025-10-26 08:42:29 +01:00
Code Issues Packages Projects Releases Wiki Activity

lower level and no stack traces at info or higher (#8278)

Browse Source 
This PR reduces loglevel on non fatal errors and removes stacktraces above debug level.
This commit is contained in:
dahn 2023-12-06 12:12:54 +01:00 committed by GitHub
parent a15b706fbe
commit a6b570845f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 16 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
framework/spring/module/src/main/java/org/apache/cloudstack/spring/module/model/impl/DefaultModuleDefinitionSet.java
View File

@ -105,10 +105,16 @@ public class DefaultModuleDefinitionSet implements ModuleDefinitionSet {
log.info(String.format("Starting module [%s].", moduleDefinitionName)); log.info(String.format("Starting module [%s].", moduleDefinitionName));
runnable.run(); runnable.run();
} catch (BeansException e) { } catch (BeansException e) {
log.error(String.format("Failed to start module [%s] due to: [%s].", moduleDefinitionName, e.getMessage()), e); log.warn(String.format("Failed to start module [%s] due to: [%s].", moduleDefinitionName, e.getMessage()));
if (log.isDebugEnabled()) {
log.debug(String.format("module start failure of module [%s] was due to: ", moduleDefinitionName), e);
}
} }
} catch (EmptyStackException e) { } catch (EmptyStackException e) {
log.error(String.format("Failed to obtain module context due to [%s]. Using root context instead.", e.getMessage()), e); log.warn(String.format("Failed to obtain module context due to [%s]. Using root context instead.", e.getMessage()));
if (log.isDebugEnabled()) {
log.debug("Failed to obtain module context: ", e);
}
} }
} }
}); });
@ -125,9 +131,15 @@ public class DefaultModuleDefinitionSet implements ModuleDefinitionSet {
log.debug(String.format("Trying to load module [%s] context.", moduleDefinitionName)); log.debug(String.format("Trying to load module [%s] context.", moduleDefinitionName));
loadContext(def, parent); loadContext(def, parent);
} catch (EmptyStackException e) { } catch (EmptyStackException e) {
log.error(String.format("Failed to obtain module context due to [%s]. Using root context instead.", e.getMessage()), e); log.warn(String.format("Failed to obtain module context due to [%s]. Using root context instead.", e.getMessage()));
if (log.isDebugEnabled()) {
log.debug("Failed to obtain module context: ", e);
}
} catch (BeansException e) { } catch (BeansException e) {
log.error(String.format("Failed to load module [%s] due to: [%s].", def.getName(), e.getMessage()), e); log.warn(String.format("Failed to start module [%s] due to: [%s].", def.getName(), e.getMessage()));
if (log.isDebugEnabled()) {
log.debug(String.format("module start failure of module [%s] was due to: ", def.getName()), e);
}
} }
} }
}); });