diff --git a/server/src/com/cloud/resource/ResourceManagerImpl.java b/server/src/com/cloud/resource/ResourceManagerImpl.java index c0187702e71..6a9a434e515 100755 --- a/server/src/com/cloud/resource/ResourceManagerImpl.java +++ b/server/src/com/cloud/resource/ResourceManagerImpl.java @@ -215,8 +215,6 @@ public class ResourceManagerImpl extends ManagerBase implements ResourceManager, PlannerHostReservationDao _plannerHostReserveDao; @Inject protected DedicatedResourceDao _dedicatedDao; - @Inject - protected ConfigurationServer _configServer; protected List _discoverers; @@ -462,7 +460,6 @@ public class ResourceManagerImpl extends ManagerBase implements ResourceManager, List result = new ArrayList(); - long clusterId = 0; ClusterVO cluster = new ClusterVO(dcId, podId, clusterName); cluster.setHypervisorType(hypervisorType.toString()); @@ -479,14 +476,8 @@ public class ResourceManagerImpl extends ManagerBase implements ResourceManager, ex.addProxyObject(zone.getUuid(), "dcId"); throw ex; } - clusterId = cluster.getId(); result.add(cluster); - ClusterDetailsVO cluster_detail_cpu = new ClusterDetailsVO(clusterId, "cpuOvercommitRatio", _configServer.getConfigValue(Config.CPUOverprovisioningFactor.key(), null, null)); - ClusterDetailsVO cluster_detail_ram = new ClusterDetailsVO(clusterId, "memoryOvercommitRatio", _configServer.getConfigValue(Config.MemOverprovisioningFactor.key(), null, null)); - _clusterDetailsDao.persist(cluster_detail_cpu); - _clusterDetailsDao.persist(cluster_detail_ram); - if (clusterType == Cluster.ClusterType.CloudManaged) { return result; } @@ -496,6 +487,8 @@ public class ResourceManagerImpl extends ManagerBase implements ResourceManager, details.put("url", url); details.put("username", username); details.put("password", password); + details.put("cpuOvercommitRatio", _configDao.getValue(Config.CPUOverprovisioningFactor.key())); + details.put("memoryOvercommitRatio", _configDao.getValue(Config.MemOverprovisioningFactor.key())); _clusterDetailsDao.persist(cluster.getId(), details); boolean success = false; @@ -515,7 +508,7 @@ public class ResourceManagerImpl extends ManagerBase implements ResourceManager, List hosts = new ArrayList(); Map> resources = null; - resources = discoverer.find(dcId, podId, clusterId, uri, username, password, null); + resources = discoverer.find(dcId, podId, cluster.getId(), uri, username, password, null); if (resources != null) { for (Map.Entry> entry : resources.entrySet()) { @@ -536,8 +529,8 @@ public class ResourceManagerImpl extends ManagerBase implements ResourceManager, throw new DiscoveryException("Unable to add the external cluster"); } finally { if (!success) { - _clusterDetailsDao.deleteDetails(clusterId); - _clusterDao.remove(clusterId); + _clusterDetailsDao.deleteDetails(cluster.getId()); + _clusterDao.remove(cluster.getId()); } } }