apache/cloudstack
1
0
Fork 0
mirror of https://github.com/apache/cloudstack.git synced 2025-11-02 20:02:29 +01:00
Code Issues Packages Projects Releases Wiki Activity

CLOUDSTACK-7639: make cidr updation more efficient

Browse Source 
check and update only when required

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit b879916f5c64ddbca8713852b2c0ac187e9be1ff)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This commit is contained in:
Rohit Yadav 2015-03-09 16:29:05 +05:30
parent e1cbe6d18a
commit 9b669f0648
3 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
engine/schema/src/com/cloud/network/vpc/NetworkACLItemCidrsDao.java
View File

@ -31,6 +31,8 @@ public interface NetworkACLItemCidrsDao extends GenericDao<NetworkACLItemCidrsVO
void persist(long networkACLItemId, List<String> cidrs);
void updateCidrs(long networkACLItemId, List<String> cidrs);
List<String> getCidrs(long networkACLItemId);
@DB

11
engine/schema/src/com/cloud/network/vpc/dao/NetworkACLItemCidrsDaoImpl.java
View File

@ -64,6 +64,17 @@ public class NetworkACLItemCidrsDaoImpl extends GenericDaoBase<NetworkACLItemCid
txn.commit();
}
@Override
public void updateCidrs(long networkACLItemId, List<String> cidrs) {
List<String> oldCidrs = getCidrs(networkACLItemId);
if (!(oldCidrs.size() == cidrs.size() && oldCidrs.equals(cidrs))) {
SearchCriteria<NetworkACLItemCidrsVO> sc = cidrsSearch.create();
sc.setParameters("networkAclItemId", networkACLItemId);
remove(sc);
persist(networkACLItemId, cidrs);
}
}
/* (non-Javadoc)
* @see com.cloud.network.dao.NetworkAclItemCidrsDao#getCidrs(long)
*/

2
engine/schema/src/com/cloud/network/vpc/dao/NetworkACLItemDaoImpl.java
View File

@ -93,7 +93,7 @@ public class NetworkACLItemDaoImpl extends GenericDaoBase<NetworkACLItemVO, Long
@Override
public boolean update(Long id, NetworkACLItemVO item) {
boolean result = super.update(id, item);
saveCidrs(item, item.getSourceCidrList());
_networkACLItemCidrsDao.updateCidrs(item.getId(), item.getSourceCidrList());
return result;
}