.github: fix first PR welcome message by boring-cyborg (#6217)

* .github: fix first PR welcome message

Adds newlines

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

* add community slack link

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

* add rules for storage label

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

* remove semantic yaml which is not needed now

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

* disable the strict check to assist RM

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

.asf.yaml

@@ -46,7 +46,7 @@ github:
   collaborators:
     - acs-robot
 
-  protected_branches:
-    main:
-      required_pull_request_reviews:
-        required_approving_review_count: 2
+  #protected_branches:
+  #  main:
+  #    required_pull_request_reviews:
+  #      required_approving_review_count: 2

.github/boring-cyborg.yml

@@ -121,6 +121,17 @@ labelPRBasedOnFilePath:
     - plugins/storage/volume/solidfire/*
   "component:ssvm":
     - services/secondary-storage/*
+  "component:storage":
+    - plugins/storage/*
+    - plugins/storage-allocators/*
+    - server/src/main/java/com/cloud/storage/*
+    - server/src/main/java/org/apache/cloudstack/storage/*
+    - engine/api/src/main/java/org/apache/cloudstack/engine/subsystem/api/storage/*
+    - engine/api/src/main/java/org/apache/cloudstack/storage/*
+    - engine/schema/src/main/java/com/cloud/storage/*
+    - engine/schema/src/main/java/org/apache/cloudstack/storage/*
+    - engine/storage/*
+    - scripts/storage/*
   "component:systemd":
     - packaging/systemd/*
     - systemvm/debian/etc/systemd/*
@@ -178,17 +189,28 @@ firstPRWelcomeComment: >
   Congratulations on your first Pull Request and welcome to the Apache CloudStack community!
   If you have any issues or are unsure about any anything please check our
   Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
+
   Here are some useful points:
+
   - In case of a new feature add useful documentation (raise doc PR at https://github.com/apache/cloudstack-documentation)
+
   - Be patient and persistent. It might take some time to get a review or get the final approval from the committers.
+
   - Pay attention to the quality of your code, ensure tests are passing and your PR doesn't have conflicts.
+
   - Please follow [ASF Code of Conduct](https://github.com/apache/.github/blob/main/.github/CODE_OF_CONDUCT.md) for all
   communication including (but not limited to) comments on Pull Requests, Issues, Mailing list and Slack.
+
   - Be sure to read the [CloudStack Coding Conventions](https://cwiki.apache.org/confluence/display/CLOUDSTACK/Coding+conventions).
+
   Apache CloudStack is a community-driven project and together we are making it better 🚀.
+
   In case of doubts contact the developers at:
+
   Mailing List: dev@cloudstack.apache.org (https://cloudstack.apache.org/mailing-lists.html)
 
+  Slack: https://apachecloudstack.slack.com/
+
 firstPRMergeComment: >
   Awesome work, congrats on your first merged pull request!
 

.github/semantic.yml

@@ -1,19 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements.  See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership.  The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License.  You may obtain a copy of the License at
-#
-#   http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied.  See the License for the
-# specific language governing permissions and limitations
-# under the License.
-
-enabled: true
-titleOnly: true