From 96d6aaa2933d2b37f2859323822de5e61310e4c4 Mon Sep 17 00:00:00 2001
From: Rafael da Fonseca <rsafonseca@gmail.com>
Date: Sun, 14 Jun 2015 15:25:33 +0200
Subject: [PATCH] Fix findbugs ClassCastException in UpgradeSystemVMCmd.java
 getDetails() isn't called anywhere in the code, either way, implementation is
 wrong since details is a Map<String, String> and not a Map<String,
 Map<String,String>> If this piece of could would get run, it would just fail
 trying to cast String to HashMap<String,String> in line 83

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
---
 .../command/admin/systemvm/UpgradeSystemVMCmd.java  | 13 +------------
 1 file changed, 1 insertion(+), 12 deletions(-)

diff --git a/api/src/org/apache/cloudstack/api/command/admin/systemvm/UpgradeSystemVMCmd.java b/api/src/org/apache/cloudstack/api/command/admin/systemvm/UpgradeSystemVMCmd.java
index f087077bc16..409b9b22810 100644
--- a/api/src/org/apache/cloudstack/api/command/admin/systemvm/UpgradeSystemVMCmd.java
+++ b/api/src/org/apache/cloudstack/api/command/admin/systemvm/UpgradeSystemVMCmd.java
@@ -75,18 +75,7 @@ public class UpgradeSystemVMCmd extends BaseCmd {
     }
 
     public Map<String, String> getDetails() {
-        Map<String, String> customparameterMap = new HashMap<String, String>();
-        if (details != null && details.size() != 0) {
-            Collection parameterCollection = details.values();
-            Iterator iter = parameterCollection.iterator();
-            while (iter.hasNext()) {
-                HashMap<String, String> value = (HashMap<String, String>)iter.next();
-                for (Map.Entry<String,String>entry : value.entrySet()) {
-                    customparameterMap.put(entry.getKey(), entry.getValue());
-                }
-            }
-        }
-        return customparameterMap;
+        return details;
     }
 
     /////////////////////////////////////////////////////