From 965346cad15a03d8cf7ffc12460ffd8ecaf35bf1 Mon Sep 17 00:00:00 2001 From: Murali Reddy Date: Tue, 20 May 2014 10:21:01 +0530 Subject: [PATCH] CLOUDSTACK-6712: NPE in findJobInstanceUuid() in ApiDBUtils --- server/src/com/cloud/api/ApiDBUtils.java | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/server/src/com/cloud/api/ApiDBUtils.java b/server/src/com/cloud/api/ApiDBUtils.java index a953cd645e1..153d99811e4 100755 --- a/server/src/com/cloud/api/ApiDBUtils.java +++ b/server/src/com/cloud/api/ApiDBUtils.java @@ -1442,6 +1442,12 @@ public class ApiDBUtils { String jobInstanceId = null; ApiCommandJobType jobInstanceType = EnumUtils.fromString(ApiCommandJobType.class, job.getInstanceType(), ApiCommandJobType.None); + if (job.getInstanceId() == null) { + // when assert is hit, implement 'getInstanceId' of BaseAsyncCmd and return appropriate instance id + assert (false); + return null; + } + if (jobInstanceType == ApiCommandJobType.Volume) { VolumeVO volume = ApiDBUtils.findVolumeById(job.getInstanceId()); if (volume != null) {