apache/cloudstack
1
0
Fork 0
mirror of https://github.com/apache/cloudstack.git synced 2025-11-03 04:12:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

bug 5190: This covers the case of unforseen exceptions (although a corner case), which might pop up. We introduce a finally block which will release the cert db record for other ms to process, in case the owning ms errors out (not crash), whilst running the cert update process

Browse Source
This commit is contained in:
abhishek 2010-11-01 14:32:56 -07:00
parent 17d049138f
commit 8e9d74c7f6
1 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
server/src/com/cloud/server/ManagementServerImpl.java
View File

@ -6004,6 +6004,14 @@ public class ManagementServerImpl implements ManagementServer {
s_logger.error(msg);
throw new ServerApiException(BaseCmd.CUSTOM_CERT_UPDATE_ERROR, msg);
}
}finally{
try {
releaseCertRecord(_certDao.listAll().get(0));//release record in case of unforseen exceptions
} catch (ResourceUnavailableException e) {
String msg = "Unable to release the cert record for other mgmt servers";
s_logger.error(msg);
throw new ServerApiException(BaseCmd.CUSTOM_CERT_UPDATE_ERROR, msg);
}
}
return null;
}
@ -6013,12 +6021,15 @@ public class ManagementServerImpl implements ManagementServer {
if(lockedCert == null){
String msg = "Unable to obtain lock on the cert from releaseCertRecord() in uploadCertificate()";
s_logger.error(msg);
throw new ResourceUnavailableException(msg);
}else{
try{
lockedCert.setMgmtServerId(null);//release for other ms
_certDao.update(lockedCert.getId(), lockedCert);
}catch (Exception e){
s_logger.warn("Unable to update record in cert table from releaseCertRecord() during uploadCertificate()",e);
String msg = "Unable to update record in cert table from releaseCertRecord() during uploadCertificate()";
s_logger.warn(msg,e);
throw new ResourceUnavailableException(msg);
}finally{
_certDao.release(cert.getId());
}