Enable Flake8 rule W391 (#6606)

Best practice is to have one blank line at the end of Python files.

Remove unneeded blank lines from the end of files

.github/linters/.flake8

@@ -15,5 +15,10 @@
 # specific language governing permissions and limitations
 # under the License.
 
+# W291 Trailing whitespace
+# W292 No newline at end of file
+# W293 Blank line contains whitespace
+# W391 Blank line at end of file
+
 [flake8]
-select = W291,W292,W293
+select = W291,W292,W293,W391

cloud-cli/cloudapis/__init__.py

@@ -40,4 +40,3 @@ def lookup_api(api_name):
     else: api = matchingapi[0]
     if api: api = getattr(api,"implementor")
     return api
-

cloud-cli/cloudapis/cloud.py

@@ -194,5 +194,3 @@ for name,meth in load_dynamic_methods():
 implementor = CloudAPI
 
 del name,meth,describe,load_dynamic_methods
-
-

plugins/hypervisors/ovm/src/main/scripts/vm/hypervisor/ovm/ConfigFileOps.py

@@ -172,4 +172,3 @@ class ConfigFileOps:
                 self.add_lines(oldLine, False)
             else:
                 self.replace_lines(newLine, oldLine, False)
-

plugins/hypervisors/ovm/src/main/scripts/vm/hypervisor/ovm/OvmCommonModule.py

@@ -156,4 +156,3 @@ def makeOwnerFileName():
     hostIp = successToMap(get_master_ip())['ip']
     ownerFileName = OWNER_FILE_PREFIX + hostIp.replace('.', '_')
     return ownerFileName
-

plugins/hypervisors/ovm/src/main/scripts/vm/hypervisor/ovm/OvmHaHeartBeatModule.py

@@ -102,4 +102,3 @@ class OvmHaHeartBeat(object):
             stopOldHeartBeat(pid)
 
         setupHeartBeat()
-

plugins/hypervisors/ovm/src/main/scripts/vm/hypervisor/ovm/OvmOCFS2Module.py

@@ -77,4 +77,3 @@ EOF
         doCmd(cmd)
         cmd = ['service o2cb start %s'%cluster]
         doCmd(cmd)
-

plugins/hypervisors/ovm/src/main/scripts/vm/hypervisor/ovm/OvmSecurityGroupModule.py

@@ -438,41 +438,3 @@ class OvmSecurityGroup(OvmObject):
             return [True, True, True, True, True, True]
 
         return [(vm_name != _vm_name), (vm_id != _vm_id), (vm_ip != _vm_ip), (dom_id != _dom_id), (signature != _signature), (seqno != _seqno)]
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-

plugins/hypervisors/ovm/src/main/scripts/vm/hypervisor/ovm/OvmStoragePoolModule.py

@@ -427,5 +427,3 @@ if this doesn't resolve the problem, please check oracle manual to see how to of
             errmsg = fmt_err_msg(e)
             logger.error(OvmStoragePool.copyVolume, errmsg)
             raise XmlRpcFault(toErrCode(OvmStoragePool, OvmStoragePool.copyVolume), errmsg)
-
-

plugins/hypervisors/ovm/src/main/scripts/vm/hypervisor/ovm/OvmVolumeModule.py

@@ -153,6 +153,3 @@ class OvmVolume(OvmObject):
 
 if __name__ == "__main__":
     print OvmVolume.detachOrAttachIso(sys.argv[1], '', False)
-
-
-

python/lib/cloud_utils.py

@@ -679,4 +679,3 @@ class MigrationContext:
 	def rollback(self):raise NotImplementedError
 	def get_schema_level(self):raise NotImplementedError
 	def set_schema_level(self,l):raise NotImplementedError
-

python/lib/cloudutils/networkConfig.py

@@ -163,4 +163,3 @@ class networkConfig:
             type = "dev"
 
         return networkConfig.devInfo(macAddr, ipAddr, netmask, None, type, dev)
-

scripts/network/exdhcp/dhcpd_edithosts.py

@@ -120,4 +120,3 @@ if __name__ == "__main__":
 
 	ret = insert_host_entry(mac, ip, hostname, dns, gateway, next_server)
 	sys.exit(ret)
-

scripts/network/ping/prepare_kickstart_kernel_initrd.py

@@ -72,4 +72,3 @@ if __name__ == "__main__":
 
     (kernel, initrd, copy_to) = sys.argv[1:]
     sys.exit(prepare())
-

scripts/vm/hypervisor/xenserver/perfmon.py

@@ -258,4 +258,3 @@ def get_vm_group_perfmon(args={}):
                 else:
                     result += ',' + str(vm_count) +  '.' +  str(counter_count) + ':' + str(average_memory)
     return result
-

scripts/vm/network/vnet/ovstunnel.py

@@ -309,4 +309,3 @@ if __name__ == '__main__':
     else:
         logging.debug("Unknown command: " + cmd)
         sys.exit(1)
-

test/integration/broken/test_ps_resource_limits_volume.py

@@ -169,4 +169,3 @@ class TestPrimaryResourceLimitsVolume(cloudstackTestCase):
         self.assertEqual(response[0], PASS, response[1])
 
         return
-

test/integration/broken/test_vr_metadata.py

@@ -334,4 +334,3 @@ class TestDeployVmWithMetaData(cloudstackTestCase):
                               )
 
         return
-

test/integration/component/maint/test_ip_resource_count_for_vpc.py

@@ -349,5 +349,3 @@ class TestIPResourceCountVPC(cloudstackTestCase):
         account_list = Account.list(self.apiclient, id=self.account.id)
         totalip = account_list[0].iptotal
         self.assertTrue(totalip - totalip_1 == 3, "publicip count is 3")
-
-

test/integration/component/test_acl_isolatednetwork_delete.py

@@ -546,4 +546,3 @@ class TestIsolatedNetworkDelete(cloudstackTestCase):
         )
         cls._cleanup.append(network)
         return network
-

test/integration/component/test_acl_sharednetwork.py

@@ -1124,5 +1124,3 @@ class TestSharedNetwork(cloudstackTestCase):
                         apiclient,
                         user.id
                       ))
-
-

test/integration/component/test_affinity_groups_projects.py

@@ -1082,6 +1082,3 @@ class TestDeployVMAffinityGroups(cloudstackTestCase):
 
         wait_for_cleanup(self.api_client, ["expunge.delay", "expunge.interval"])
         self.cleanup.append(aff_grp)
-
-
-

test/integration/component/test_baremetal.py

@@ -120,4 +120,3 @@ class TestBaremetal(cloudstackTestCase):
         cmd.endip = "10.1.1.40"
         cmd.forVirtualNetwork="false"
         self.apiclient.createVlanIpRange(cmd)
-

test/integration/component/test_brocade_vcs.py

@@ -329,4 +329,3 @@ class TestBrocadeVcs(cloudstackTestCase):
         Network.delete(self.network, self.apiclient)
 
         return
-

test/integration/component/test_concurrent_create_volume_from_snapshot.py

@@ -303,4 +303,3 @@ class TestSnapshotRootDisk(cloudstackTestCase):
         )
 
         return
-

test/integration/component/test_dhcp_dns_offload.py

@@ -2124,4 +2124,3 @@ class TestDeployVMs(cloudstackTestCase):
                 self.debug("Success: Updating dhcp config params with invalid values is not allowed\
                            and throws following message: %s" % e)
         return
-

test/integration/component/test_egress_rules.py

@@ -2125,6 +2125,3 @@ class TestInvalidParametersForEgress(cloudstackTestCase):
                                     domainid=self.account.domainid
                                     )
         return
-
-
-

test/integration/component/test_escalations_instances.py

@@ -4492,6 +4492,3 @@ class TestInstances(cloudstackTestCase):
                 "Warning: Exception in expunging vms vm3 and vm4 : %s" %
                 e)
         return
-
-
-

test/integration/component/test_escalations_templates.py

@@ -861,6 +861,3 @@ class TestTemplates(cloudstackTestCase):
             )
         del self.services["privatetemplate"]["ostype"]
         return
-
-
-

test/integration/component/test_escalations_vmware.py

@@ -367,6 +367,3 @@ class TestVMware(cloudstackTestCase):
             snapshot_created_1,
             "VM Snapshot creation failed"
         )
-
-
-

test/integration/component/test_hypervisor_capabilities.py

@@ -286,4 +286,3 @@ class TestHypervisorCapabilities(cloudstackTestCase):
         cmd = listHypervisorCapabilities.listHypervisorCapabilitiesCmd()
         cmd.id = id
         return self.apiclient.listHypervisorCapabilities(cmd)
-

test/integration/component/test_invalid_gw_nm.py

@@ -124,4 +124,3 @@ class TestIsolatedNetworkInvalidGw(cloudstackTestCase):
                 netmask="255.0.255.0",
             )
         return
-

test/integration/component/test_ldap.py

@@ -304,4 +304,3 @@ class TestLdap(cloudstackTestCase):
         except Exception as p:
             self.debug("login operation failed %s" % p)
             self.reason = "Login operation Failed %s" % p
-

test/integration/component/test_ldap_auto_import.py

@@ -594,5 +594,3 @@ class TestLdap(cloudstackTestCase):
             "", "", self.parent_domain.name, method="POST")
         self.debug(loginRes)
         self.assertEqual(loginRes, None, self.reason)
-
-

test/integration/component/test_multiple_nic_support.py

@@ -621,4 +621,3 @@ class TestMulipleNicSupport(cloudstackTestCase):
             self.fail("Exception occurred: %s" % e)
 
         self.verify_network_rules(self.virtual_machine1.id)
-

test/integration/component/test_redundant_router_services.py

@@ -380,4 +380,3 @@ class TestEnableVPNOverRvR(cloudstackTestCase):
                          "List remote VPNs should not return empty response"
                          )
         return
-

test/integration/plugins/solidfire/TestAddRemoveHosts.py

@@ -955,4 +955,3 @@ class TestAddRemoveHosts(cloudstackTestCase):
             xen_server = cls.testdata[TestData.xenServer]
 
             cls.xen_session.xenapi.login_with_password(xen_server[TestData.username], xen_server[TestData.password])
-

test/integration/plugins/solidfire/TestManagedSystemVMs.py

@@ -624,4 +624,3 @@ class TestManagedSystemVMs(cloudstackTestCase):
             xen_server = cls.testdata[TestData.xenServer]
 
             cls.xen_session.xenapi.login_with_password(xen_server[TestData.username], xen_server[TestData.password])
-

test/integration/plugins/solidfire/TestSnapshots.py

@@ -1767,4 +1767,3 @@ class TestSnapshots(cloudstackTestCase):
         sf_volumes = sf_util.get_active_sf_volumes(self.sfe, sf_account_id)
 
         sf_util.check_list(sf_volumes, expected_num_volumes, self, volume_err_msg)
-

test/integration/plugins/solidfire/TestVolumes.py

@@ -2710,4 +2710,3 @@ class TestVolumes(cloudstackTestCase):
             xen_server = cls.testdata[TestData.xenServer]
 
             cls.xen_session.xenapi.login_with_password(xen_server[TestData.username], xen_server[TestData.password])
-

test/integration/plugins/storpool/TestStorPoolVolumes.py

@@ -2149,5 +2149,3 @@ class TestStoragePool(cloudstackTestCase):
         host, port = cfg['SP_API_HTTP'].split(':')
         auth = cfg['SP_AUTH_TOKEN']
         return host, int(port), auth
-
-

test/integration/plugins/storpool/sp_util.py

@@ -745,4 +745,3 @@ class StorPoolHelper():
         cmd.id = vmid
         cmd.hostid = hostid
         return (apiclient.startVirtualMachine(cmd))
-

test/integration/smoke/test_create_network.py

@@ -289,4 +289,3 @@ class TestNetworkManagement(cloudstackTestCase):
         )
 
         self.cleanup.append(self.network_offering)
-

test/integration/smoke/test_deploy_vm_root_resize.py

@@ -394,6 +394,3 @@ class TestDeployVmRootSize(cloudstackTestCase):
             self.assertEqual(success, True, "Check if passing rootdisksize < templatesize fails appropriately")
         else:
             self.debug("test 02 does not support hypervisor type " + self.hypervisor)
-
-
-

test/integration/smoke/test_enable_role_based_users_in_projects.py

@@ -268,4 +268,3 @@ class TestRoleBasedUsersInProjects(cloudstackTestCase):
             )
         except Exception as e:
             pass
-

test/integration/smoke/test_metrics_api.py

@@ -376,4 +376,3 @@ class TestMetrics(cloudstackTestCase):
             return True
         except ValueError:
             return False
-

test/integration/smoke/test_network_permissions.py

@@ -791,4 +791,4 @@ class TestNetworkPermissions(cloudstackTestCase):
 
         self.remove_network_permission(self.apiclient, self.user_network, self.other_user, None, expected=True)
         self.list_network(self.apiclient, self.other_user, self.user_network, None, None, expected=False)
-        self.list_network(self.otheruser_apiclient, self.other_user, self.user_network, None, None, expected=False)
+        self.list_network(self.otheruser_apiclient, self.other_user, self.user_network, None, None, expected=False)

test/integration/smoke/test_non_contigiousvlan.py

@@ -88,4 +88,3 @@ class TestUpdatePhysicalNetwork(cloudstackTestCase):
         updateResponse = self.network.update(self.apiClient, id = self.networkid, vlan=self.existing_vlan)
         self.assertTrue(updateResponse.vlan.find(self.vlan["full_range"]) < 0,
             "VLAN was not removed successfully")
-

test/integration/testpaths/testpath_delta_snapshots.py

@@ -537,4 +537,3 @@ class TestDeltaSnapshots(cloudstackTestCase):
             "Check: Snapshot 1 is still on Secondary Storage. Not Deleted.")
 
         return
-

test/selenium/browser/firefox.py

@@ -53,4 +53,3 @@ if __name__ == "__main__":
     browser.set_url("http://10.88.90.84:8080/client/")
     time.sleep(3)
     browser.quit_browser()
-

test/selenium/common/__init__.py

@@ -14,5 +14,3 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-
-

test/selenium/common/shared.py

@@ -146,4 +146,3 @@ class Shared(object):
 
         #this method isn't as slick as I hoped :(
         time.sleep(1)
-

test/selenium/cspages/__init__.py

@@ -14,5 +14,3 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-
-

test/selenium/cspages/cspage.py

@@ -18,4 +18,3 @@
 class CloudStackPage(object):
     def __init__():
         self.browser = None
-

test/selenium/cspages/dashboard/__init__.py

@@ -14,5 +14,3 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-
-

test/selenium/cspages/dashboard/dashboardpage.py

@@ -71,4 +71,3 @@ class DashboardPage(CloudStackPage):
                 li.click()
                 time.sleep(3)
                 return
-

test/selenium/cspages/login/__init__.py

@@ -14,5 +14,3 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-
-

test/selenium/cstests/__init__.py

@@ -14,4 +14,3 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-

test/selenium/cstests/regressiontests/__init__.py

@@ -14,4 +14,3 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-

test/selenium/cstests/smoketests/__init__.py

@@ -14,4 +14,3 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-

test/selenium/cstests/smoketests/smokecfg.py

@@ -60,4 +60,3 @@ smokecfg = {
                                },
 
            }
-

test/selenium/lib/Global_Locators.py

@@ -220,5 +220,3 @@ login_password_css = "body.login > div.login > form > div.fields > div.field.pas
 
 # Click ok to login
 login_submit_css = "body.login > div.login > form > div.fields > input[type=\"submit\"]" # Login>Login Button (Submit button)
-
-

test/selenium/smoke/main.py

@@ -140,6 +140,3 @@ runner = xmlrunner.XMLTestRunner(output='test-reports')
 
 # Leave following as is for either XML or HTML
 runner.run(suite)
-
-
-

tools/marvin/marvin/cloudstackException.py

@@ -92,4 +92,3 @@ class CloudstackAclException():
             return True
         else:
             return False
-

tools/marvin/marvin/lib/utils.py

@@ -551,4 +551,3 @@ def wait_until(retry_interval=2, no_of_times=2, callback=None, *callback_args):
             break
 
     return wait_result, return_val
-

tools/marvin/marvin/misc/build/bashUtils.py

@@ -145,4 +145,3 @@ class bash:
             return self.getStdout()
         else:
             return self.getStderr()
-

tools/marvin/marvin/misc/build/restartMgmt.py

@@ -50,4 +50,3 @@ if __name__ == '__main__':
             timeout = timeout - 1
     if tn is None:
         raise socket.error("Unable to reach API port")
-

tools/marvin/marvin/sandbox/__init__.py

@@ -14,5 +14,3 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-
-

tools/marvin/marvin/sandbox/advanced/__init__.py

@@ -14,5 +14,3 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-
-

tools/marvin/marvin/sandbox/advancedsg/__init__.py

@@ -14,5 +14,3 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-
-

tools/marvin/marvin/sandbox/basic/__init__.py

@@ -14,5 +14,3 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-
-

tools/marvin/marvin/sandbox/demo/__init__.py

@@ -14,4 +14,3 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-

tools/marvin/marvin/sandbox/demo/live/__init__.py

@@ -14,4 +14,3 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-

tools/marvin/marvin/sandbox/demo/simulator/__init__.py

@@ -14,5 +14,3 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-
-

tools/marvin/marvin/sandbox/demo/simulator/testcase/__init__.py

@@ -14,5 +14,3 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-
-

tools/marvin/marvin/sandbox/demo/simulator/testcase/libs/__init__.py

@@ -14,5 +14,3 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-
-