diff --git a/api/src/main/java/org/apache/cloudstack/api/response/ServiceOfferingResponse.java b/api/src/main/java/org/apache/cloudstack/api/response/ServiceOfferingResponse.java index 51b5c1f6db8..41c8645029e 100644 --- a/api/src/main/java/org/apache/cloudstack/api/response/ServiceOfferingResponse.java +++ b/api/src/main/java/org/apache/cloudstack/api/response/ServiceOfferingResponse.java @@ -19,14 +19,13 @@ package org.apache.cloudstack.api.response; import java.util.Date; import java.util.Map; -import com.google.gson.annotations.SerializedName; - import org.apache.cloudstack.api.ApiConstants; import org.apache.cloudstack.api.BaseResponse; import org.apache.cloudstack.api.EntityReference; import com.cloud.offering.ServiceOffering; import com.cloud.serializer.Param; +import com.google.gson.annotations.SerializedName; @EntityReference(value = ServiceOffering.class) public class ServiceOfferingResponse extends BaseResponse { @@ -81,14 +80,22 @@ public class ServiceOfferingResponse extends BaseResponse { @Param(description = "the tags for the service offering") private String tags; - @SerializedName("domainid") - @Param(description = "the domain id of the service offering") + @SerializedName(ApiConstants.DOMAIN_ID) + @Param(description = "the domain ID(s) this disk offering belongs to. Ignore this information as it is not currently applicable.") private String domainId; @SerializedName(ApiConstants.DOMAIN) - @Param(description = "Domain name for the offering") + @Param(description = "the domain name(s) this disk offering belongs to. Ignore this information as it is not currently applicable.") private String domain; + @SerializedName(ApiConstants.ZONE_ID) + @Param(description = "the zone ID(s) this disk offering belongs to. Ignore this information as it is not currently applicable.", since = "4.13.0") + private String zoneId; + + @SerializedName(ApiConstants.ZONE) + @Param(description = "the zone name(s) this disk offering belongs to. Ignore this information as it is not currently applicable.", since = "4.13.0") + private String zone; + @SerializedName(ApiConstants.HOST_TAGS) @Param(description = "the host tag for the service offering") private String hostTag; @@ -324,6 +331,22 @@ public class ServiceOfferingResponse extends BaseResponse { this.domain = domain; } + public String getZoneId() { + return zoneId; + } + + public void setZoneId(String zoneId) { + this.zoneId = zoneId; + } + + public String getZone() { + return zone; + } + + public void setZone(String zone) { + this.zone = zone; + } + public String getHostTag() { return hostTag; } diff --git a/engine/schema/src/main/java/com/cloud/dc/dao/DataCenterDao.java b/engine/schema/src/main/java/com/cloud/dc/dao/DataCenterDao.java index e006b0e4573..a6cd59f1cc3 100644 --- a/engine/schema/src/main/java/com/cloud/dc/dao/DataCenterDao.java +++ b/engine/schema/src/main/java/com/cloud/dc/dao/DataCenterDao.java @@ -121,6 +121,4 @@ public interface DataCenterDao extends GenericDao { List findByKeyword(String keyword); List listAllZones(); - - List list(Object[] ids); } diff --git a/engine/schema/src/main/java/com/cloud/dc/dao/DataCenterDaoImpl.java b/engine/schema/src/main/java/com/cloud/dc/dao/DataCenterDaoImpl.java index 2db904f78c9..385fb406155 100644 --- a/engine/schema/src/main/java/com/cloud/dc/dao/DataCenterDaoImpl.java +++ b/engine/schema/src/main/java/com/cloud/dc/dao/DataCenterDaoImpl.java @@ -437,12 +437,4 @@ public class DataCenterDaoImpl extends GenericDaoBase implem return dcs; } - - @Override - public List list(Object[] ids) { - SearchBuilder sb = createSearchBuilder(); - SearchCriteria sc = sb.create(); - sc.addAnd("id", SearchCriteria.Op.IN, ids); - return listBy(sc); - } } diff --git a/engine/schema/src/main/java/com/cloud/domain/dao/DomainDao.java b/engine/schema/src/main/java/com/cloud/domain/dao/DomainDao.java index 45ff6b5df54..297fbfad6de 100644 --- a/engine/schema/src/main/java/com/cloud/domain/dao/DomainDao.java +++ b/engine/schema/src/main/java/com/cloud/domain/dao/DomainDao.java @@ -40,6 +40,4 @@ public interface DomainDao extends GenericDao { Set getDomainParentIds(long domainId); List getDomainChildrenIds(String path); - - List list(Object[] ids); } diff --git a/engine/schema/src/main/java/com/cloud/domain/dao/DomainDaoImpl.java b/engine/schema/src/main/java/com/cloud/domain/dao/DomainDaoImpl.java index 45be8ea2af1..6b6255a3ca9 100644 --- a/engine/schema/src/main/java/com/cloud/domain/dao/DomainDaoImpl.java +++ b/engine/schema/src/main/java/com/cloud/domain/dao/DomainDaoImpl.java @@ -290,12 +290,4 @@ public class DomainDaoImpl extends GenericDaoBase implements Dom return parentDomains; } - - @Override - public List list(Object[] ids) { - SearchBuilder sb = createSearchBuilder(); - SearchCriteria sc = sb.create(); - sc.addAnd("id", SearchCriteria.Op.IN, ids); - return listBy(sc); - } } diff --git a/engine/schema/src/main/java/com/cloud/service/ServiceOfferingVO.java b/engine/schema/src/main/java/com/cloud/service/ServiceOfferingVO.java index a45b7c41522..0229776ba6b 100644 --- a/engine/schema/src/main/java/com/cloud/service/ServiceOfferingVO.java +++ b/engine/schema/src/main/java/com/cloud/service/ServiceOfferingVO.java @@ -75,8 +75,9 @@ public class ServiceOfferingVO extends DiskOfferingVO implements ServiceOffering @Column(name = "deployment_planner") private String deploymentPlanner = null; + @Transient @Column(name = "domain_id") - private Long domainId = null; + Long domainId; // This is a delayed load value. If the value is null, // then this field has not been loaded yet. diff --git a/framework/quota/src/main/java/org/apache/cloudstack/quota/vo/ServiceOfferingVO.java b/framework/quota/src/main/java/org/apache/cloudstack/quota/vo/ServiceOfferingVO.java index 0bd2e971c80..8f33a183ad5 100644 --- a/framework/quota/src/main/java/org/apache/cloudstack/quota/vo/ServiceOfferingVO.java +++ b/framework/quota/src/main/java/org/apache/cloudstack/quota/vo/ServiceOfferingVO.java @@ -75,6 +75,10 @@ public class ServiceOfferingVO extends DiskOfferingVO implements ServiceOffering @Column(name = "deployment_planner") private String deploymentPlanner = null; + @Transient + @Column(name = "domain_id") + Long domainId; + @Transient Map details = new HashMap(); @@ -226,11 +230,6 @@ public class ServiceOfferingVO extends DiskOfferingVO implements ServiceOffering return multicastRateMbps; } - @Override - public Long getDomainId() { - return null; - } - public void setHostTag(String hostTag) { this.hostTag = hostTag; } @@ -289,4 +288,10 @@ public class ServiceOfferingVO extends DiskOfferingVO implements ServiceOffering public void setDynamicFlag(boolean isdynamic) { isDynamic = isdynamic; } + + @Override + public Long getDomainId() { + // TODO: get rid of me + return domainId; + } } diff --git a/server/src/main/java/com/cloud/api/query/dao/ServiceOfferingJoinDaoImpl.java b/server/src/main/java/com/cloud/api/query/dao/ServiceOfferingJoinDaoImpl.java index 71a67da2e3f..3e4c830fef1 100644 --- a/server/src/main/java/com/cloud/api/query/dao/ServiceOfferingJoinDaoImpl.java +++ b/server/src/main/java/com/cloud/api/query/dao/ServiceOfferingJoinDaoImpl.java @@ -67,9 +67,10 @@ public class ServiceOfferingJoinDaoImpl extends GenericDaoBase