Validate the direct downloaded template file format (QCOW2) if the template file exists (#10332)

* Validate the direct downloaded template file format (QCOW2) if the template file exists

* string format not required
This commit is contained in:
Suresh Kumar Anaparti 2025-02-13 12:08:57 +05:30 committed by GitHub
parent 59e054396a
commit 8c4a085a16
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -2472,8 +2472,15 @@ public class KVMStorageProcessor implements StorageProcessor {
template = storagePoolMgr.createPhysicalDiskFromDirectDownloadTemplate(tempFilePath, destTemplatePath, destPool, cmd.getFormat(), cmd.getWaitInMillSeconds());
String templatePath = template.getPath();
if (templatePath != null) {
String templatePath = null;
if (template != null) {
templatePath = template.getPath();
}
if (StringUtils.isEmpty(templatePath)) {
logger.warn("Skipped validation whether downloaded file is QCOW2 for template {}, due to downloaded template path is empty", template.getName());
} else if (!new File(templatePath).exists()) {
logger.warn("Skipped validation whether downloaded file is QCOW2 for template {}, due to downloaded template path is not valid: {}", template.getName(), templatePath);
} else {
try {
Qcow2Inspector.validateQcow2File(templatePath);
} catch (RuntimeException e) {