From 8ace2722e72f544cbb22782d084f3082d601103b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gabriel=20Beims=20Br=C3=A4scher?= Date: Wed, 15 Dec 2021 05:08:15 -0300 Subject: [PATCH] Set length for parameters that expect a list of domain ids. (#5763) Currently, when updating a service offering there is a limitation of the number of domains the offering can be updated. Multiple domain ids lead to the following API error: Error: (HTTP 431, error code 9999) Unable to execute API command updateserviceoffering due to invalid value. Value greater than max allowed length 255 for param: domainIds" --- .../api/command/admin/network/UpdateNetworkOfferingCmd.java | 3 ++- .../api/command/admin/offering/UpdateDiskOfferingCmd.java | 3 ++- .../api/command/admin/offering/UpdateServiceOfferingCmd.java | 3 ++- .../cloudstack/api/command/admin/vpc/UpdateVPCOfferingCmd.java | 3 ++- 4 files changed, 8 insertions(+), 4 deletions(-) diff --git a/api/src/main/java/org/apache/cloudstack/api/command/admin/network/UpdateNetworkOfferingCmd.java b/api/src/main/java/org/apache/cloudstack/api/command/admin/network/UpdateNetworkOfferingCmd.java index 83c82741ab2..12e9bca883f 100644 --- a/api/src/main/java/org/apache/cloudstack/api/command/admin/network/UpdateNetworkOfferingCmd.java +++ b/api/src/main/java/org/apache/cloudstack/api/command/admin/network/UpdateNetworkOfferingCmd.java @@ -86,7 +86,8 @@ public class UpdateNetworkOfferingCmd extends BaseCmd { @Parameter(name = ApiConstants.ZONE_ID, type = CommandType.STRING, description = "the ID of the containing zone(s) as comma separated string, all for all zones offerings", - since = "4.13") + since = "4.13", + length = 4096) private String zoneIds; ///////////////////////////////////////////////////// diff --git a/api/src/main/java/org/apache/cloudstack/api/command/admin/offering/UpdateDiskOfferingCmd.java b/api/src/main/java/org/apache/cloudstack/api/command/admin/offering/UpdateDiskOfferingCmd.java index 5ccdc06cc05..57631046c33 100644 --- a/api/src/main/java/org/apache/cloudstack/api/command/admin/offering/UpdateDiskOfferingCmd.java +++ b/api/src/main/java/org/apache/cloudstack/api/command/admin/offering/UpdateDiskOfferingCmd.java @@ -69,7 +69,8 @@ public class UpdateDiskOfferingCmd extends BaseCmd { @Parameter(name = ApiConstants.DOMAIN_ID, type = CommandType.STRING, description = "the ID of the containing domain(s) as comma separated string, public for public offerings", - since = "4.13") + since = "4.13", + length = 4096) private String domainIds; @Parameter(name = ApiConstants.ZONE_ID, diff --git a/api/src/main/java/org/apache/cloudstack/api/command/admin/offering/UpdateServiceOfferingCmd.java b/api/src/main/java/org/apache/cloudstack/api/command/admin/offering/UpdateServiceOfferingCmd.java index 4212a0059e2..f2d064c8e61 100644 --- a/api/src/main/java/org/apache/cloudstack/api/command/admin/offering/UpdateServiceOfferingCmd.java +++ b/api/src/main/java/org/apache/cloudstack/api/command/admin/offering/UpdateServiceOfferingCmd.java @@ -64,7 +64,8 @@ public class UpdateServiceOfferingCmd extends BaseCmd { @Parameter(name = ApiConstants.DOMAIN_ID, type = CommandType.STRING, - description = "the ID of the containing domain(s) as comma separated string, public for public offerings") + description = "the ID of the containing domain(s) as comma separated string, public for public offerings", + length = 4096) private String domainIds; @Parameter(name = ApiConstants.ZONE_ID, diff --git a/api/src/main/java/org/apache/cloudstack/api/command/admin/vpc/UpdateVPCOfferingCmd.java b/api/src/main/java/org/apache/cloudstack/api/command/admin/vpc/UpdateVPCOfferingCmd.java index ce8f96c464d..2ad1eeac76b 100644 --- a/api/src/main/java/org/apache/cloudstack/api/command/admin/vpc/UpdateVPCOfferingCmd.java +++ b/api/src/main/java/org/apache/cloudstack/api/command/admin/vpc/UpdateVPCOfferingCmd.java @@ -60,7 +60,8 @@ public class UpdateVPCOfferingCmd extends BaseAsyncCmd { @Parameter(name = ApiConstants.DOMAIN_ID, type = CommandType.STRING, - description = "the ID of the containing domain(s) as comma separated string, public for public offerings") + description = "the ID of the containing domain(s) as comma separated string, public for public offerings", + length = 4096) private String domainIds; @Parameter(name = ApiConstants.ZONE_ID,