diff --git a/server/src/com/cloud/configuration/ConfigurationManagerImpl.java b/server/src/com/cloud/configuration/ConfigurationManagerImpl.java index 388fc06cdfa..bcd87da832a 100755 --- a/server/src/com/cloud/configuration/ConfigurationManagerImpl.java +++ b/server/src/com/cloud/configuration/ConfigurationManagerImpl.java @@ -4487,18 +4487,16 @@ public class ConfigurationManagerImpl extends ManagerBase implements Configurati } // Now apply pagination - List wPagination = StringUtils.applyPagination(supportedOfferings, cmd.getStartIndex(), cmd.getPageSizeVal()); + List wPagination = StringUtils.applyPagination(supportedOfferings, cmd.getStartIndex(), cmd.getPageSizeVal()); if (wPagination != null) { - @SuppressWarnings("unchecked") - Pair, Integer> listWPagination = new Pair, Integer>((List) wPagination, offerings.size()); + Pair, Integer> listWPagination = new Pair, Integer>(wPagination, offerings.size()); return listWPagination; } return new Pair, Integer>(supportedOfferings, supportedOfferings.size()); } else { - List wPagination = StringUtils.applyPagination(offerings, cmd.getStartIndex(), cmd.getPageSizeVal()); + List wPagination = StringUtils.applyPagination(offerings, cmd.getStartIndex(), cmd.getPageSizeVal()); if (wPagination != null) { - @SuppressWarnings("unchecked") - Pair, Integer> listWPagination = new Pair, Integer>((List) wPagination, offerings.size()); + Pair, Integer> listWPagination = new Pair, Integer>(wPagination, offerings.size()); return listWPagination; } return new Pair, Integer>(offerings, offerings.size()); diff --git a/server/src/com/cloud/network/NetworkServiceImpl.java b/server/src/com/cloud/network/NetworkServiceImpl.java index 4ac1bea32b7..9d1fc6680d6 100755 --- a/server/src/com/cloud/network/NetworkServiceImpl.java +++ b/server/src/com/cloud/network/NetworkServiceImpl.java @@ -1623,10 +1623,9 @@ public class NetworkServiceImpl extends ManagerBase implements NetworkService { } //Now apply pagination - List wPagination = StringUtils.applyPagination(networksToReturn, cmd.getStartIndex(), cmd.getPageSizeVal()); + List wPagination = StringUtils.applyPagination(networksToReturn, cmd.getStartIndex(), cmd.getPageSizeVal()); if (wPagination != null) { - @SuppressWarnings("unchecked") - Pair, Integer> listWPagination = new Pair, Integer>((List) wPagination, networksToReturn.size()); + Pair, Integer> listWPagination = new Pair, Integer>(wPagination, networksToReturn.size()); return listWPagination; } diff --git a/server/src/com/cloud/network/vpc/VpcManagerImpl.java b/server/src/com/cloud/network/vpc/VpcManagerImpl.java index 5a90233b34b..d58c0a468a5 100644 --- a/server/src/com/cloud/network/vpc/VpcManagerImpl.java +++ b/server/src/com/cloud/network/vpc/VpcManagerImpl.java @@ -671,18 +671,16 @@ public class VpcManagerImpl extends ManagerBase implements VpcManager, VpcProvis } } - List wPagination = StringUtils.applyPagination(supportedOfferings, startIndex, pageSizeVal); + List wPagination = StringUtils.applyPagination(supportedOfferings, startIndex, pageSizeVal); if (wPagination != null) { - @SuppressWarnings("unchecked") - Pair, Integer> listWPagination = new Pair, Integer>((List) wPagination, supportedOfferings.size()); + Pair, Integer> listWPagination = new Pair, Integer>(wPagination, supportedOfferings.size()); return listWPagination; } return new Pair, Integer>(supportedOfferings, supportedOfferings.size()); } else { - List wPagination = StringUtils.applyPagination(offerings, startIndex, pageSizeVal); + List wPagination = StringUtils.applyPagination(offerings, startIndex, pageSizeVal); if (wPagination != null) { - @SuppressWarnings("unchecked") - Pair, Integer> listWPagination = new Pair, Integer>((List) wPagination, offerings.size()); + Pair, Integer> listWPagination = new Pair, Integer>(wPagination, offerings.size()); return listWPagination; } return new Pair, Integer>(offerings, offerings.size()); @@ -1128,18 +1126,16 @@ public class VpcManagerImpl extends ManagerBase implements VpcManager, VpcProvis } } - List wPagination = StringUtils.applyPagination(supportedVpcs, startIndex, pageSizeVal); + List wPagination = StringUtils.applyPagination(supportedVpcs, startIndex, pageSizeVal); if (wPagination != null) { - @SuppressWarnings("unchecked") - Pair, Integer> listWPagination = new Pair, Integer>((List) wPagination, supportedVpcs.size()); + Pair, Integer> listWPagination = new Pair, Integer>(wPagination, supportedVpcs.size()); return listWPagination; } return new Pair, Integer>(supportedVpcs, supportedVpcs.size()); } else { - List wPagination = StringUtils.applyPagination(vpcs, startIndex, pageSizeVal); + List wPagination = StringUtils.applyPagination(vpcs, startIndex, pageSizeVal); if (wPagination != null) { - @SuppressWarnings("unchecked") - Pair, Integer> listWPagination = new Pair, Integer>((List) wPagination, vpcs.size()); + Pair, Integer> listWPagination = new Pair, Integer>(wPagination, vpcs.size()); return listWPagination; } return new Pair, Integer>(vpcs, vpcs.size()); diff --git a/utils/src/com/cloud/utils/StringUtils.java b/utils/src/com/cloud/utils/StringUtils.java index f4c3f9e0f40..17b8fc00573 100644 --- a/utils/src/com/cloud/utils/StringUtils.java +++ b/utils/src/com/cloud/utils/StringUtils.java @@ -269,16 +269,16 @@ public class StringUtils { return s; } - public static List applyPagination(List originalList, Long startIndex, Long pageSizeVal) { + public static List applyPagination(List originalList, Long startIndex, Long pageSizeVal) { // Most likely pageSize will never exceed int value, and we need integer to partition the listToReturn boolean applyPagination = startIndex != null && pageSizeVal != null && startIndex <= Integer.MAX_VALUE && startIndex >= Integer.MIN_VALUE && pageSizeVal <= Integer.MAX_VALUE && pageSizeVal >= Integer.MIN_VALUE; - List listWPagination = null; + List listWPagination = null; if (applyPagination) { listWPagination = new ArrayList<>(); int index = startIndex.intValue() == 0 ? 0 : startIndex.intValue() / pageSizeVal.intValue(); - List> partitions = StringUtils.partitionList(originalList, pageSizeVal.intValue()); + List> partitions = StringUtils.partitionList(originalList, pageSizeVal.intValue()); if (index < partitions.size()) { listWPagination = partitions.get(index); } @@ -286,8 +286,8 @@ public class StringUtils { return listWPagination; } - private static List> partitionList(List originalList, int chunkSize) { - List> listOfChunks = new ArrayList>(); + private static List> partitionList(List originalList, int chunkSize) { + List> listOfChunks = new ArrayList>(); for (int i = 0; i < originalList.size() / chunkSize; i++) { listOfChunks.add(originalList.subList(i * chunkSize, i * chunkSize + chunkSize)); }