apache/cloudstack
1
0
Fork 0
mirror of https://github.com/apache/cloudstack.git synced 2025-10-26 08:42:29 +01:00
Code Issues Packages Projects Releases Wiki Activity

bug 6928: throw error when router is not in stopped state while upgrading

Browse Source 
status 6928: resolved fixed
This commit is contained in:
kishan 2011-01-19 16:30:12 +05:30
parent 1117eff8f9
commit 88024bea6a
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
View File

@ -370,6 +370,12 @@ public class VirtualNetworkApplianceManagerImpl implements VirtualNetworkApplian
throw new InvalidParameterValueException("Unable to find service offering with id " + serviceOfferingId); throw new InvalidParameterValueException("Unable to find service offering with id " + serviceOfferingId);
} }
// Check that the router is stopped
if (!router.getState().equals(State.Stopped)) {
s_logger.warn("Unable to upgrade router " + router.toString() + " in state " + router.getState());
throw new InvalidParameterValueException("Unable to upgrade router " + router.toString() + " in state " + router.getState() + "; make sure the router is stopped and not in an error state before upgrading.");
}
ServiceOfferingVO currentServiceOffering = _serviceOfferingDao.findById(router.getServiceOfferingId()); ServiceOfferingVO currentServiceOffering = _serviceOfferingDao.findById(router.getServiceOfferingId());
if (!currentServiceOffering.getGuestIpType().equals(newServiceOffering.getGuestIpType())) { if (!currentServiceOffering.getGuestIpType().equals(newServiceOffering.getGuestIpType())) {