From 848860d822f7f94308ef8f3cce4021a06ef7a31f Mon Sep 17 00:00:00 2001 From: Wei Zhou Date: Tue, 22 Oct 2019 13:17:30 +0200 Subject: [PATCH] security_group.py: fix NameError: name 'd' is not defined (#3641) in agent.log on a host running with cloudstack 4.14.0.0-SNAPSHOT, it gives error root@node212:~# /usr/share/cloudstack-common/scripts/vm/network/security_group.py get_rule_logs_for_vms Traceback (most recent call last): File "/usr/share/cloudstack-common/scripts/vm/network/security_group.py", line 1272, in get_rule_logs_for_vms() File "/usr/share/cloudstack-common/scripts/vm/network/security_group.py", line 758, in get_rule_logs_for_vms vms = virshlist(state) File "/usr/share/cloudstack-common/scripts/vm/network/security_group.py", line 104, in virshlist alldomains = [d for domain in map(conn.lookupByID, conn.listDomainsID())] File "/usr/share/cloudstack-common/scripts/vm/network/security_group.py", line 104, in alldomains = [d for domain in map(conn.lookupByID, conn.listDomainsID())] NameError: name 'd' is not defined --- scripts/vm/network/security_group.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/vm/network/security_group.py b/scripts/vm/network/security_group.py index f93f089f111..7b3a38d6820 100755 --- a/scripts/vm/network/security_group.py +++ b/scripts/vm/network/security_group.py @@ -101,8 +101,8 @@ def virshlist(states): conn = get_libvirt_connection() - alldomains = [d for domain in map(conn.lookupByID, conn.listDomainsID())] - alldomains += [d for domain in map(conn.lookupByName, conn.listDefinedDomains())] + alldomains = [domain for domain in map(conn.lookupByID, conn.listDomainsID())] + alldomains += [domain for domain in map(conn.lookupByName, conn.listDefinedDomains())] domains = [] for domain in alldomains: