diff --git a/engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java b/engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java index 14870e73122..2c682103373 100644 --- a/engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java +++ b/engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java @@ -641,30 +641,23 @@ public class UserVmDaoImpl extends GenericDaoBase implements Use TransactionLegacy txn = TransactionLegacy.currentTxn(); List, Pair>> vmsDetailByNames = new ArrayList, Pair>>(); - PreparedStatement pstmt = null; - try { - pstmt = txn.prepareStatement(VMS_DETAIL_BY_NAME + getQueryBatchAppender(vmNames.size())); + try (PreparedStatement pstmt = txn.prepareStatement(VMS_DETAIL_BY_NAME + getQueryBatchAppender(vmNames.size()));) { pstmt.setString(1, detail); int i = 2; for(String name : vmNames) { pstmt.setString(i, name); i++; } - try { - ResultSet rs = pstmt.executeQuery(); + try (ResultSet rs = pstmt.executeQuery();) { while (rs.next()) { vmsDetailByNames.add(new Pair, Pair>(new Pair( rs.getString("vm_instance.instance_name"), VirtualMachine.Type.valueOf(rs.getString("vm_type"))), new Pair(rs.getLong("vm_instance.id"), rs.getString("user_vm_details.value")))); } - rs.close(); } catch (Exception e) { s_logger.error("GetVmsDetailsByNames: Exception: " + e.getMessage()); throw new CloudRuntimeException("GetVmsDetailsByNames: Exception: " + e.getMessage()); } - if(pstmt != null) { - pstmt.close(); - } } catch (Exception e) { s_logger.error("GetVmsDetailsByNames: Exception in sql: " + e.getMessage()); throw new CloudRuntimeException("GetVmsDetailsByNames: Exception: " + e.getMessage());