From 7f780f26f99aa063147c38b208eaf191ce8ccac3 Mon Sep 17 00:00:00 2001 From: Rajesh Battala Date: Wed, 5 Feb 2014 23:44:14 +0530 Subject: [PATCH] Fixed agent code to handle untagged public vlan while parsing the vlan id --- .../DotNet/ServerResource/HypervResource/WmiCallsV2.cs | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCallsV2.cs b/plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCallsV2.cs index b9694f00eca..dde6e214f09 100644 --- a/plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCallsV2.cs +++ b/plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCallsV2.cs @@ -391,7 +391,7 @@ namespace HypervResource string vlan = null; string isolationUri = nic.isolationUri; string broadcastUri = nic.broadcastUri; - if ( (broadcastUri != null ) || (isolationUri != null && isolationUri.StartsWith("vlan://")) && !isolationUri.Equals("vlan://untagged")) + if ( (broadcastUri != null ) || (isolationUri != null && isolationUri.StartsWith("vlan://"))) { if (broadcastUri != null && broadcastUri.StartsWith("storage")) { @@ -402,7 +402,11 @@ namespace HypervResource vlan = isolationUri.Substring("vlan://".Length); } int tmp; - if (!int.TryParse(vlan, out tmp)) + if (vlan.Equals("untagged", StringComparison.CurrentCultureIgnoreCase) ) { + // recevied vlan is untagged, don't parse for the vlan in the isolation uri + vlan = null; + } + else if (!int.TryParse(vlan, out tmp)) { // TODO: double check exception type errMsg = string.Format("Invalid VLAN value {0} for on vm {1} for nic uuid {2}", isolationUri, vmName, nic.uuid);