apache/cloudstack
1
0
Fork 0
mirror of https://github.com/apache/cloudstack.git synced 2025-11-03 04:12:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

Quickview: don't run tabFilter

Browse Source 
For compact detail view (quickview), don't execute tabFilter, as only
the first tab is rendered in all cases. This prevents excessive API
calls from being made, slowing performance.
This commit is contained in:
Brian Federle 2012-10-24 12:35:33 -07:00
parent 72259693ac
commit 7ed60961f0
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
ui/scripts/ui/widgets/detailView.js
View File

@ -1019,7 +1019,6 @@
var context = options.context ? options.context : {};
var updateContext = $detailView.data('view-args').updateContext;
var compact = options.compact;
var tabTotal = 0;
if (updateContext) {
$.extend($detailView.data('view-args').context, updateContext({
@ -1035,16 +1034,22 @@
);
}
if (tabFilter) {
if (tabFilter && !compact) {
removedTabs = tabFilter({
context: context
});
} else if (compact) {
removedTabs = $.grep(
$.map(
tabs,
function(value, key) { return key; }
), function(tab, index) { return index > 0; }
);
}
$.each(tabs, function(key, value) {
// Don't render tab, if filtered out
if ($.inArray(key, removedTabs) > -1) return true;
if (compact && tabTotal) return true;
var propGroup = key;
var prop = value;
@ -1062,8 +1067,6 @@
$tabContent.data('detail-view-tab-id', key);
$tabContent.data('detail-view-tab-data', value);
tabTotal++;
return true;
});