apache/cloudstack
1
0
Fork 0
mirror of https://github.com/apache/cloudstack.git synced 2025-11-02 20:02:29 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1501 from mike-tutkowski/cs-9354

Browse Source 
Fixing an issue in Marvin around creating a template from a snapshotThis fixes the following ticket: https://issues.apache.org/jira/browse/CLOUDSTACK-9354

The problem was that Marvin was requiring you to pass in the "ispublic" parameter when creating a template from a snapshot.

As the ticket notes, this issue was introduced by the following commit: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=bbe0fc4be9527d51820b067a602886003991db4d

The solution I've provided is simply to check if the "ispublic" property is in the dictionary before referencing it.

* pr/1501:
  CLOUDSTACK-9354 - Fixing an issue in Marvin around creating a template from a snapshot (if “is public” is not provided, there was a problem)

Signed-off-by: Will Stevens <williamstevens@gmail.com>
This commit is contained in:
Will Stevens 2016-04-21 16:36:50 -04:00
commit 7cd2284bf5
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tools/marvin/marvin/lib/base.py
View File

@ -1201,8 +1201,8 @@ class Template:
random_gen()
]) if random_name else services["name"]
if services["ispublic"]:
cmd.ispublic = services["ispublic"]
if "ispublic" in services:
cmd.ispublic = services["ispublic"]
if "ostypeid" in services:
cmd.ostypeid = services["ostypeid"]