diff --git a/awsapi/pom.xml b/awsapi/pom.xml index 55a16326934..3c2bbe16399 100644 --- a/awsapi/pom.xml +++ b/awsapi/pom.xml @@ -317,6 +317,16 @@ + + org.apache.maven.plugins + maven-checkstyle-plugin + ${cs.checkstyle.version} + + + none + + + org.apache.maven.plugins maven-surefire-plugin diff --git a/deps/XenServerJava/pom.xml b/deps/XenServerJava/pom.xml index cdc1e302f6d..5c885b49808 100644 --- a/deps/XenServerJava/pom.xml +++ b/deps/XenServerJava/pom.xml @@ -35,4 +35,26 @@ ${cs.xmlrpc.version} + + + + org.apache.maven.plugins + maven-checkstyle-plugin + ${cs.checkstyle.version} + + + none + + + + + org.apache.cloudstack + checkstyle + + ${project.parent.version} + + + + + diff --git a/plugins/network-elements/opendaylight/pom.xml b/plugins/network-elements/opendaylight/pom.xml index 8c69b6ebe17..47d66f60b13 100644 --- a/plugins/network-elements/opendaylight/pom.xml +++ b/plugins/network-elements/opendaylight/pom.xml @@ -47,34 +47,6 @@ - - org.apache.maven.plugins - maven-checkstyle-plugin - - - org.apache.cloudstack - checkstyle - ${project.version} - - - - - process-classes - - check - - - - - true - tooling/checkstyle.xml - true - true - ${project.basedir} - **\/*.java,**\/*.xml,**\/*.ini,**\/*.sh,**\/*.bat - **\/target\/,**\/bin\/ - - com.mycila.maven-license-plugin maven-license-plugin diff --git a/pom.xml b/pom.xml index 4a4719e4e75..3f65bdd05ad 100644 --- a/pom.xml +++ b/pom.xml @@ -160,6 +160,7 @@ + tools/checkstyle api agent core @@ -447,7 +448,22 @@ org.apache.maven.plugins maven-checkstyle-plugin - false + + + + + + org.apache.maven.plugins + maven-checkstyle-plugin + ${cs.checkstyle.version} + + + org.apache.cloudstack + checkstyle + ${project.version} + + + validate @@ -458,7 +474,7 @@ true - ${project.basedir}/tools/checkstyle/cloud-style.xml + cloud-style.xml true true ${project.basedir} @@ -466,14 +482,6 @@ **\/deps\/,**\/test\/,**\/target\/,**\/bin\/,**\/*.xml,**\/*.ini,**\/*.sh,**\/*.bat,**\/awsapi\/,**\/XenServerJava\/,**\/apidoc\/ - - - - - org.apache.maven.plugins - maven-checkstyle-plugin - ${cs.checkstyle.version} - maven-clean-plugin diff --git a/server/test/com/cloud/vpc/MockNetworkManagerImpl.java b/server/test/com/cloud/vpc/MockNetworkManagerImpl.java index b62bf4758a6..be305dee0f4 100644 --- a/server/test/com/cloud/vpc/MockNetworkManagerImpl.java +++ b/server/test/com/cloud/vpc/MockNetworkManagerImpl.java @@ -25,9 +25,9 @@ import javax.ejb.Local; import javax.inject.Inject; import javax.naming.ConfigurationException; -import org.apache.cloudstack.acl.ControlledEntity; import org.apache.log4j.Logger; import org.springframework.stereotype.Component; + import org.apache.cloudstack.acl.ControlledEntity.ACLType; import org.apache.cloudstack.api.command.admin.network.DedicateGuestVlanRangeCmd; import org.apache.cloudstack.api.command.admin.network.ListDedicatedGuestVlanRangesCmd; diff --git a/tools/checkstyle/pom.xml b/tools/checkstyle/pom.xml new file mode 100644 index 00000000000..25eb5284d30 --- /dev/null +++ b/tools/checkstyle/pom.xml @@ -0,0 +1,43 @@ + + + + 4.0.0 + + Apache CloudStack Developer Tools - Checkstyle Configuration + org.apache.cloudstack + checkstyle + 4.4.0-SNAPSHOT + + + + org.apache.maven.plugins + maven-checkstyle-plugin + 2.11 + + + none + + + + + + + diff --git a/tools/checkstyle/cloud-style.xml b/tools/checkstyle/src/main/resources/cloud-style.xml similarity index 100% rename from tools/checkstyle/cloud-style.xml rename to tools/checkstyle/src/main/resources/cloud-style.xml