apache/cloudstack
1
0
Fork 0
mirror of https://github.com/apache/cloudstack.git synced 2025-11-03 04:12:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

bug 6451: XenServer username/password should be changable through API

Browse Source
This commit is contained in:
Abhinandan Prateek 2011-04-27 12:14:51 +05:30
parent 0fc005f20a
commit 7960a499dc
1 changed files with 46 additions and 48 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

94
server/src/com/cloud/server/ManagementServerImpl.java
View File

@ -4763,55 +4763,53 @@ public class ManagementServerImpl implements ManagementServer {
return password;
}
@Override
@DB
public boolean updateHostPassword(UpdateHostPasswordCmd cmd) {
if (cmd.getClusterId()==null && cmd.getHostId() == null){
throw new InvalidParameterValueException("You should provide one of cluster id or a host id.");
}
else if (cmd.getClusterId()==null){
HostVO h = _hostDao.findById(cmd.getHostId());
if (h.getHypervisorType() == HypervisorType.XenServer){
throw new InvalidParameterValueException("You should provide cluster id for Xenserver cluster.");
}
DetailVO nv= _detailsDao.findDetail(h.getId(), ApiConstants.USERNAME);
if (nv.getValue().equals(cmd.getUsername())){
DetailVO nvp= _detailsDao.findDetail(h.getId(), ApiConstants.PASSWORD);
nvp.setValue(cmd.getPassword());
_detailsDao.persist(nvp);
}
else {
throw new InvalidParameterValueException("The username is not under use by management server.");
}
}
else {
//get all the hosts in this cluster
List<HostVO> hosts = _hostDao.listByCluster(cmd.getClusterId());
Transaction txn = Transaction.currentTxn();
txn.start();
for (HostVO h : hosts) {
if (s_logger.isDebugEnabled()) {
s_logger.debug("Changing password for host name = " + h.getName());
}
//update password for this host
DetailVO nv= _detailsDao.findDetail(h.getId(), ApiConstants.USERNAME);
if (nv.getValue().equals(cmd.getUsername())){
DetailVO nvp= _detailsDao.findDetail(h.getId(), ApiConstants.PASSWORD);
nvp.setValue(cmd.getPassword());
_detailsDao.persist(nvp);
}
else { //if one host in the cluster has diff username then rollback to maintain consistency
txn.rollback();
throw new InvalidParameterValueException("The username is not same for all hosts, please modify passwords for individual hosts.");
}
}
txn.commit();
// if hypervisor is xenserver then we update it in CitrixResourceBase
}
return true;
}
if (cmd.getClusterId()==null && cmd.getHostId() == null){
throw new InvalidParameterValueException("You should provide one of cluster id or a host id.");
}
else if (cmd.getClusterId()==null){
HostVO h = _hostDao.findById(cmd.getHostId());
if (h.getHypervisorType() == HypervisorType.XenServer){
throw new InvalidParameterValueException("You should provide cluster id for Xenserver cluster.");
}
DetailVO nv= _detailsDao.findDetail(h.getId(), ApiConstants.USERNAME);
if (nv.getValue().equals(cmd.getUsername())){
DetailVO nvp= _detailsDao.findDetail(h.getId(), ApiConstants.PASSWORD);
nvp.setValue(cmd.getPassword());
_detailsDao.persist(nvp);
}
else {
throw new InvalidParameterValueException("The username is not under use by management server.");
}
}
else {
//get all the hosts in this cluster
List<HostVO> hosts = _hostDao.listByCluster(cmd.getClusterId());
Transaction txn = Transaction.currentTxn();
txn.start();
for (HostVO h : hosts) {
if (s_logger.isDebugEnabled()) {
s_logger.debug("Changing password for host name = " + h.getName());
}
//update password for this host
DetailVO nv= _detailsDao.findDetail(h.getId(), ApiConstants.USERNAME);
if (nv.getValue().equals(cmd.getUsername())){
DetailVO nvp= _detailsDao.findDetail(h.getId(), ApiConstants.PASSWORD);
nvp.setValue(cmd.getPassword());
_detailsDao.persist(nvp);
}
else {
//if one host in the cluster has diff username then rollback to maintain consistency
txn.rollback();
throw new InvalidParameterValueException("The username is not same for all hosts, please modify passwords for individual hosts.");
}
}
txn.commit();
// if hypervisor is xenserver then we update it in CitrixResourceBase
}
return true;
}
}