Clean up UI error handling

Restore error messages for widgets -- as the default error handler
will be overridden if an error fn is specified, thus rendering no
message
This commit is contained in:
Brian Federle 2011-12-08 16:28:32 -08:00
parent 477676c168
commit 77ee3cedd5
5 changed files with 15 additions and 16 deletions

View File

@ -59,7 +59,6 @@ var pollAsyncJobResult = function(args) {
else if (result.jobstatus == 2) { // Failed
var msg = (result.jobresult.errortext == null)? "": result.jobresult.errortext;
args.error({message: msg});
cloudStack.dialog.notice({ message: msg });
}
}
},

View File

@ -49,12 +49,12 @@
close();
},
error: function(args) {
error: function(message) {
$wizard.remove();
$('div.overlay').remove();
if (args.message) {
//cloudStack.dialog.notice({ message: args.message });
if (message) {
cloudStack.dialog.notice({ message: message });
}
}
}

View File

@ -37,12 +37,12 @@
close();
},
error: function(args) {
error: function(message) {
$wizard.remove();
$('div.overlay').remove();
if (args.message) {
//cloudStack.dialog.notice({ message: args.message });
if (message) {
cloudStack.dialog.notice({ message: message });
}
}
}

View File

@ -220,9 +220,9 @@
}
);
},
error: function(data){
// if (data.message)
// cloudStack.dialog.notice({ message: data.message });
error: function(message){
if (message)
cloudStack.dialog.notice({ message: message });
}
}
};
@ -372,9 +372,9 @@
if (options.success) options.success(args);
},
error: function(args) {
if (args.message) {
//cloudStack.dialog.notice({ message: args.message });
error: function(message) {
if (message) {
cloudStack.dialog.notice({ message: message });
$edit.hide(),
$label.html(oldVal).fadeIn();
$instanceRow.closest('div.data-table').dataTable('refresh');

View File

@ -1,4 +1,4 @@
(function($) {
(function($, cloudStack) {
/**
* Notification handling
*/
@ -89,7 +89,7 @@
incomplete: function(args) {},
error: function(args) {
if (args.message) {
//cloudStack.dialog.notice({ message: args.message });
cloudStack.dialog.notice({ message: args.message });
}
clearInterval(pollTimer);
@ -287,4 +287,4 @@
if ($popup.size())
notifications.popup.reposition($popup, $popup.data('notifications-attach-to'));
});
})(window.jQuery);
})(window.jQuery, cloudStack);