From 74a3cb4d5ec2c4919eef531a2b0d5986b975bee3 Mon Sep 17 00:00:00 2001 From: Laszlo Hornyak Date: Sun, 9 Feb 2014 19:01:45 +0100 Subject: [PATCH] String concatenation cleanup Replaced string concatenation in loop with StringBuilder Signed-off-by: Laszlo Hornyak --- .../kvm/src/org/apache/cloudstack/utils/qemu/QemuImg.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/plugins/hypervisors/kvm/src/org/apache/cloudstack/utils/qemu/QemuImg.java b/plugins/hypervisors/kvm/src/org/apache/cloudstack/utils/qemu/QemuImg.java index a948ca1899f..b380815d04b 100644 --- a/plugins/hypervisors/kvm/src/org/apache/cloudstack/utils/qemu/QemuImg.java +++ b/plugins/hypervisors/kvm/src/org/apache/cloudstack/utils/qemu/QemuImg.java @@ -90,11 +90,11 @@ public class QemuImg { if (options != null && !options.isEmpty()) { s.add("-o"); - String optionsStr = ""; + final StringBuilder optionsStr = new StringBuilder(); for (Map.Entry option : options.entrySet()) { - optionsStr += option.getKey() + "=" + option.getValue() + ","; + optionsStr.append(option.getKey()).append('=').append(option.getValue()).append(','); } - s.add(optionsStr); + s.add(optionsStr.toString()); } /*