diff --git a/engine/components-api/src/main/java/com/cloud/capacity/CapacityManager.java b/engine/components-api/src/main/java/com/cloud/capacity/CapacityManager.java index c24909fb05d..d23002b298b 100644 --- a/engine/components-api/src/main/java/com/cloud/capacity/CapacityManager.java +++ b/engine/components-api/src/main/java/com/cloud/capacity/CapacityManager.java @@ -16,10 +16,13 @@ // under the License. package com.cloud.capacity; +import java.util.Map; + import org.apache.cloudstack.framework.config.ConfigKey; import org.apache.cloudstack.storage.datastore.db.StoragePoolVO; import com.cloud.host.Host; +import com.cloud.service.ServiceOfferingVO; import com.cloud.storage.VMTemplateVO; import com.cloud.vm.VirtualMachine; @@ -99,6 +102,8 @@ public interface CapacityManager { void updateCapacityForHost(Host host); + void updateCapacityForHost(Host host, Map offeringsMap); + /** * @param pool storage pool * @param templateForVmCreation template that will be used for vm creation diff --git a/server/src/main/java/com/cloud/alert/AlertManagerImpl.java b/server/src/main/java/com/cloud/alert/AlertManagerImpl.java index 5a7a8b436e0..75b8cc7f3b4 100644 --- a/server/src/main/java/com/cloud/alert/AlertManagerImpl.java +++ b/server/src/main/java/com/cloud/alert/AlertManagerImpl.java @@ -75,6 +75,8 @@ import com.cloud.host.HostVO; import com.cloud.network.dao.IPAddressDao; import com.cloud.org.Grouping.AllocationState; import com.cloud.resource.ResourceManager; +import com.cloud.service.ServiceOfferingVO; +import com.cloud.service.dao.ServiceOfferingDao; import com.cloud.storage.StorageManager; import com.cloud.utils.NumbersUtil; import com.cloud.utils.component.ManagerBase; @@ -121,6 +123,8 @@ public class AlertManagerImpl extends ManagerBase implements AlertManager, Confi private ConfigurationManager _configMgr; @Inject protected ConfigDepot _configDepot; + @Inject + ServiceOfferingDao _offeringsDao; private Timer _timer = null; private long _capacityCheckPeriod = 60L * 60L * 1000L; // One hour by default. @@ -275,8 +279,14 @@ public class AlertManagerImpl extends ManagerBase implements AlertManager, Confi // get all hosts...even if they are not in 'UP' state List hosts = _resourceMgr.listAllNotInMaintenanceHostsInOneZone(Host.Type.Routing, null); if (hosts != null) { + // prepare the service offerings + List offerings = _offeringsDao.listAllIncludingRemoved(); + Map offeringsMap = new HashMap(); + for (ServiceOfferingVO offering : offerings) { + offeringsMap.put(offering.getId(), offering); + } for (HostVO host : hosts) { - _capacityMgr.updateCapacityForHost(host); + _capacityMgr.updateCapacityForHost(host, offeringsMap); } } if (s_logger.isDebugEnabled()) { diff --git a/server/src/main/java/com/cloud/capacity/CapacityManagerImpl.java b/server/src/main/java/com/cloud/capacity/CapacityManagerImpl.java index c95c8acb4e8..fba24e0a8c7 100644 --- a/server/src/main/java/com/cloud/capacity/CapacityManagerImpl.java +++ b/server/src/main/java/com/cloud/capacity/CapacityManagerImpl.java @@ -629,7 +629,12 @@ public class CapacityManagerImpl extends ManagerBase implements CapacityManager, for (ServiceOfferingVO offering : offerings) { offeringsMap.put(offering.getId(), offering); } + updateCapacityForHost(host, offeringsMap); + } + @DB + @Override + public void updateCapacityForHost(final Host host, final Map offeringsMap) { long usedCpuCore = 0; long reservedCpuCore = 0; long usedCpu = 0; @@ -666,6 +671,9 @@ public class CapacityManagerImpl extends ManagerBase implements CapacityManager, ramOvercommitRatio = Float.parseFloat(vmDetailRam); } ServiceOffering so = offeringsMap.get(vm.getServiceOfferingId()); + if (so == null) { + so = _offeringsDao.findByIdIncludingRemoved(vm.getServiceOfferingId()); + } if (so.isDynamic()) { usedMemory += ((Integer.parseInt(vmDetails.get(UsageEventVO.DynamicParameters.memory.name())) * 1024L * 1024L) / ramOvercommitRatio) * @@ -705,6 +713,9 @@ public class CapacityManagerImpl extends ManagerBase implements CapacityManager, } ServiceOffering so = offeringsMap.get(vm.getServiceOfferingId()); Map vmDetails = _userVmDetailsDao.listDetailsKeyPairs(vm.getId()); + if (so == null) { + so = _offeringsDao.findByIdIncludingRemoved(vm.getServiceOfferingId()); + } if (so.isDynamic()) { reservedMemory += ((Integer.parseInt(vmDetails.get(UsageEventVO.DynamicParameters.memory.name())) * 1024L * 1024L) / ramOvercommitRatio) * diff --git a/server/src/main/java/com/cloud/server/StatsCollector.java b/server/src/main/java/com/cloud/server/StatsCollector.java index 2096b1255c2..86db544a196 100644 --- a/server/src/main/java/com/cloud/server/StatsCollector.java +++ b/server/src/main/java/com/cloud/server/StatsCollector.java @@ -687,18 +687,17 @@ public class StatsCollector extends ManagerBase implements ComponentMethodInterc return; } // collect the vm disk statistics(total) from hypervisor. added by weizhou, 2013.03. - s_logger.trace("Running VM disk stats ..."); - try { - Transaction.execute(new TransactionCallbackNoReturn() { - @Override - public void doInTransactionWithoutResult(TransactionStatus status) { - s_logger.debug("VmDiskStatsTask is running..."); + s_logger.debug("VmDiskStatsTask is running..."); - SearchCriteria sc = createSearchCriteriaForHostTypeRoutingStateUpAndNotInMaintenance(); - sc.addAnd("hypervisorType", SearchCriteria.Op.IN, HypervisorType.KVM, HypervisorType.VMware); - List hosts = _hostDao.search(sc, null); + SearchCriteria sc = createSearchCriteriaForHostTypeRoutingStateUpAndNotInMaintenance(); + sc.addAnd("hypervisorType", SearchCriteria.Op.IN, HypervisorType.KVM, HypervisorType.VMware); + List hosts = _hostDao.search(sc, null); - for (HostVO host : hosts) { + for (HostVO host : hosts) { + try { + Transaction.execute(new TransactionCallbackNoReturn() { + @Override + public void doInTransactionWithoutResult(TransactionStatus status) { List vms = _userVmDao.listRunningByHostId(host.getId()); List vmIds = new ArrayList(); @@ -709,7 +708,7 @@ public class StatsCollector extends ManagerBase implements ComponentMethodInterc HashMap> vmDiskStatsById = _userVmMgr.getVmDiskStatistics(host.getId(), host.getName(), vmIds); if (vmDiskStatsById == null) - continue; + return; Set vmIdSet = vmDiskStatsById.keySet(); for (Long vmId : vmIdSet) { @@ -796,10 +795,10 @@ public class StatsCollector extends ManagerBase implements ComponentMethodInterc } } } - } - }); - } catch (Exception e) { - s_logger.warn("Error while collecting vm disk stats from hosts", e); + }); + } catch (Exception e) { + s_logger.warn(String.format("Error while collecting vm disk stats from host %s : ", host.getName()), e); + } } } } @@ -815,16 +814,16 @@ public class StatsCollector extends ManagerBase implements ComponentMethodInterc return; } // collect the vm network statistics(total) from hypervisor - try { - Transaction.execute(new TransactionCallbackNoReturn() { - @Override - public void doInTransactionWithoutResult(TransactionStatus status) { - s_logger.debug("VmNetworkStatsTask is running..."); + s_logger.debug("VmNetworkStatsTask is running..."); - SearchCriteria sc = createSearchCriteriaForHostTypeRoutingStateUpAndNotInMaintenance(); - List hosts = _hostDao.search(sc, null); + SearchCriteria sc = createSearchCriteriaForHostTypeRoutingStateUpAndNotInMaintenance(); + List hosts = _hostDao.search(sc, null); - for (HostVO host : hosts) { + for (HostVO host : hosts) { + try { + Transaction.execute(new TransactionCallbackNoReturn() { + @Override + public void doInTransactionWithoutResult(TransactionStatus status) { List vms = _userVmDao.listRunningByHostId(host.getId()); List vmIds = new ArrayList(); @@ -835,7 +834,7 @@ public class StatsCollector extends ManagerBase implements ComponentMethodInterc HashMap> vmNetworkStatsById = _userVmMgr.getVmNetworkStatistics(host.getId(), host.getName(), vmIds); if (vmNetworkStatsById == null) - continue; + return; Set vmIdSet = vmNetworkStatsById.keySet(); for (Long vmId : vmIdSet) { @@ -915,10 +914,10 @@ public class StatsCollector extends ManagerBase implements ComponentMethodInterc } } } - } - }); - } catch (Exception e) { - s_logger.warn("Error while collecting vm network stats from hosts", e); + }); + } catch (Exception e) { + s_logger.warn(String.format("Error while collecting vm network stats from host %s : ", host.getName()), e); + } } } } diff --git a/setup/bindir/cloud-setup-databases.in b/setup/bindir/cloud-setup-databases.in index 98f7139057c..bd23c2ba6ad 100755 --- a/setup/bindir/cloud-setup-databases.in +++ b/setup/bindir/cloud-setup-databases.in @@ -179,7 +179,7 @@ Sql parameters: *************************************************************** Please run: - cloud-setup-database -h + cloudstack-setup-databases -h for full help ''' % msg diff --git a/test/integration/component/test_mm_domain_limits.py b/test/integration/component/test_mm_domain_limits.py index 51e92ce67f1..795055eca6f 100644 --- a/test/integration/component/test_mm_domain_limits.py +++ b/test/integration/component/test_mm_domain_limits.py @@ -210,7 +210,7 @@ class TestDomainMemoryLimits(cloudstackTestCase): domainid=self.child_do_admin_2.domainid) return - @attr(tags=["advanced", "advancedns","simulator"], required_hardware="false") + @attr(tags=["advanced", "advancedns","simulator"], required_hardware="true") def test_01_change_service_offering(self): """Test Deploy VM with specified RAM & verify the usage"""