apache/cloudstack
1
0
Fork 0
mirror of https://github.com/apache/cloudstack.git synced 2025-10-26 08:42:29 +01:00
Code Issues Packages Projects Releases Wiki Activity

CLOUDSTACK-4104: VM Creation should fail if a zone is dedicated to a domain and user of the same domain deploys vm without using affinity group "Explicit Dedication".

Browse Source
This commit is contained in:
Saksham Srivastava 2013-08-07 16:52:50 +05:30 committed by Devdeep Singh
parent 78d344b849
commit 61c7aa7afe
1 changed files with 2 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java
View File

@ -462,24 +462,8 @@ public class DeploymentPlanningManagerImpl extends ManagerBase implements Deploy
if (!isExplicit && vm.getType() == VirtualMachine.Type.User) { if (!isExplicit && vm.getType() == VirtualMachine.Type.User) {
//add explicitly dedicated resources in avoidList //add explicitly dedicated resources in avoidList
DedicatedResourceVO dedicatedZone = _dedicatedDao.findByZoneId(dc.getId()); DedicatedResourceVO dedicatedZone = _dedicatedDao.findByZoneId(dc.getId());
if (dedicatedZone != null) { if (dedicatedZone != null && dedicatedZone.getDomainId() != null) {
long accountDomainId = vmProfile.getOwner().getDomainId(); throw new CloudRuntimeException("Failed to deploy VM. Zone " + dc.getName() + " is dedicated . Please use Explicit Dedication Affinity Group");
long accountId = vmProfile.getOwner().getAccountId();
if (dedicatedZone.getDomainId() != null && !dedicatedZone.getDomainId().equals(accountDomainId)) {
throw new CloudRuntimeException("Failed to deploy VM. Zone " + dc.getName() + " is dedicated.");
}
// If a zone is dedicated to an account then all hosts in this zone will be explicitly dedicated to
// that account. So there won't be any shared hosts in the zone, the only way to deploy vms from that
// account will be to use explicit dedication affinity group.
if (dedicatedZone.getAccountId() != null) {
if (dedicatedZone.getAccountId().equals(accountId)) {
throw new CloudRuntimeException("Failed to deploy VM. There are no shared hosts available in" +
" this dedicated zone.");
} else {
throw new CloudRuntimeException("Failed to deploy VM. Zone " + dc.getName() + " is dedicated.");
}
}
} }
List<HostPodVO> podsInDc = _podDao.listByDataCenterId(dc.getId()); List<HostPodVO> podsInDc = _podDao.listByDataCenterId(dc.getId());