apache/cloudstack
1
0
Fork 0
mirror of https://github.com/apache/cloudstack.git synced 2025-10-26 08:42:29 +01:00
Code Issues Packages Projects Releases Wiki Activity

Logging improvements on migration in the VmwareResource (#8300)

Browse Source
This commit is contained in:
dahn 2024-02-28 10:59:35 +01:00 committed by GitHub
parent 4e34e6b334
commit 56e0450526
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
View File

@ -4766,7 +4766,13 @@ public class VmwareResource extends ServerResourceBase implements StoragePoolRes
final String vmName = cmd.getVmName(); final String vmName = cmd.getVmName();
try { try {
VmwareHypervisorHost hyperHost = getHyperHost(getServiceContext()); VmwareHypervisorHost hyperHost = getHyperHost(getServiceContext());
if (hyperHost == null) {
throw new CloudRuntimeException("no hypervisor host found for migrate command");
}
ManagedObjectReference morDc = hyperHost.getHyperHostDatacenter(); ManagedObjectReference morDc = hyperHost.getHyperHostDatacenter();
if (morDc == null) {
throw new CloudRuntimeException("no Managed Object Reference for the Data Center found for migrate command");
}
// find VM through datacenter (VM is not at the target host yet) // find VM through datacenter (VM is not at the target host yet)
VirtualMachineMO vmMo = hyperHost.findVmOnPeerHyperHost(vmName); VirtualMachineMO vmMo = hyperHost.findVmOnPeerHyperHost(vmName);
@ -4777,6 +4783,9 @@ public class VmwareResource extends ServerResourceBase implements StoragePoolRes
} }
VmwareHypervisorHost destHyperHost = getTargetHyperHost(new DatacenterMO(hyperHost.getContext(), morDc), cmd.getDestinationIp()); VmwareHypervisorHost destHyperHost = getTargetHyperHost(new DatacenterMO(hyperHost.getContext(), morDc), cmd.getDestinationIp());
if (destHyperHost == null) {
throw new CloudRuntimeException("no destination Hypervisor Host found for migrate command");
}
ManagedObjectReference morTargetPhysicalHost = destHyperHost.findMigrationTarget(vmMo); ManagedObjectReference morTargetPhysicalHost = destHyperHost.findMigrationTarget(vmMo);
if (morTargetPhysicalHost == null) { if (morTargetPhysicalHost == null) {
@ -4788,7 +4797,8 @@ public class VmwareResource extends ServerResourceBase implements StoragePoolRes
} }
return new MigrateAnswer(cmd, true, "migration succeeded", null); return new MigrateAnswer(cmd, true, "migration succeeded", null);
} catch (Throwable e) { } catch (Exception e) {
s_logger.info(String.format("migrate command for %s failed due to %s", vmName, e.getLocalizedMessage()));
return new MigrateAnswer(cmd, false, createLogMessageException(e, cmd), null); return new MigrateAnswer(cmd, false, createLogMessageException(e, cmd), null);
} }
} }