From 54606dc965d9d79da03aaf175f7c63a1fd6d995a Mon Sep 17 00:00:00 2001 From: Wei Zhou Date: Wed, 5 Apr 2023 18:29:46 +0200 Subject: [PATCH] server: fix 4.18/main build error after merge forward --- .../storage/VolumeApiServiceImplTest.java | 44 ------------------- 1 file changed, 44 deletions(-) diff --git a/server/src/test/java/com/cloud/storage/VolumeApiServiceImplTest.java b/server/src/test/java/com/cloud/storage/VolumeApiServiceImplTest.java index 1c7f165ea25..e08e3775e35 100644 --- a/server/src/test/java/com/cloud/storage/VolumeApiServiceImplTest.java +++ b/server/src/test/java/com/cloud/storage/VolumeApiServiceImplTest.java @@ -1298,50 +1298,6 @@ public class VolumeApiServiceImplTest { Assert.assertEquals(expectedIsNotPossibleToResize, result); } - @Test - public void isNewDiskOfferingTheSameAndCustomServiceOfferingTestDifferentOfferings() { - prepareAndRunIsNewDiskOfferingTheSameAndCustomServiceOffering(1l, 2l, false, true, false); - } - - @Test - public void isNewDiskOfferingTheSameAndCustomServiceOfferingTestDifferentOfferingsCustom() { - prepareAndRunIsNewDiskOfferingTheSameAndCustomServiceOffering(1l, 2l, true, true, false); - } - - @Test - public void isNewDiskOfferingTheSameAndCustomServiceOfferingTestSameOfferingsCustom() { - prepareAndRunIsNewDiskOfferingTheSameAndCustomServiceOffering(1l, 1l, true, true, true); - } - - @Test - public void isNewDiskOfferingTheSameAndCustomServiceOfferingTestSameOfferingsNotCustom() { - prepareAndRunIsNewDiskOfferingTheSameAndCustomServiceOffering(1l, 1l, false, true, false); - } - - @Test - public void isNewDiskOfferingTheSameAndCustomServiceOfferingTestDifferentOfferingsAndNullOffering() { - prepareAndRunIsNewDiskOfferingTheSameAndCustomServiceOffering(1l, 2l, true, false, false); - } - @Test - public void isNewDiskOfferingTheSameAndCustomServiceOfferingTestSameOfferingsNullOffering() { - prepareAndRunIsNewDiskOfferingTheSameAndCustomServiceOffering(1l, 1l, false, false, false); - } - - private void prepareAndRunIsNewDiskOfferingTheSameAndCustomServiceOffering(long existingDiskOfferingId, long newDiskOfferingId, boolean isCustomized, - boolean isNotNullServiceOffering, boolean expectedResult) { - DiskOfferingVO existingDiskOffering = Mockito.mock(DiskOfferingVO.class); - when(existingDiskOffering.getId()).thenReturn(existingDiskOfferingId); - DiskOfferingVO newDiskOffering = Mockito.mock(DiskOfferingVO.class); - when(newDiskOffering.getId()).thenReturn(newDiskOfferingId); - if(isNotNullServiceOffering) { - ServiceOfferingVO serviceOfferingVO = Mockito.mock(ServiceOfferingVO.class); - when(serviceOfferingVO.isCustomized()).thenReturn(isCustomized); - when(serviceOfferingDao.findServiceOfferingByComputeOnlyDiskOffering(anyLong())).thenReturn(serviceOfferingVO); - } - boolean result = volumeApiServiceImpl.isNewDiskOfferingTheSameAndCustomServiceOffering(existingDiskOffering, newDiskOffering); - Assert.assertEquals(expectedResult, result); - } - @Test (expected = InvalidParameterValueException.class) public void checkIfVolumeCanBeReassignedTestNullVolume() { volumeApiServiceImpl.validateVolume(volumeVoMock.getUuid(), null);