Check all TODO and FIXME tasks

This commit is contained in:
Hugo Trippaers 2012-10-12 12:02:54 +02:00
parent ab8ba3d61d
commit 51f9a98871
4 changed files with 1 additions and 7 deletions

View File

@ -54,7 +54,6 @@ public class ConfigurePortForwardingRulesOnLogicalRouterCommand extends Command
*/ */
@Override @Override
public boolean executeInSequence() { public boolean executeInSequence() {
// TODO Auto-generated method stub
return false; return false;
} }

View File

@ -43,7 +43,6 @@ public class ConfigurePublicIpsOnLogicalRouterCommand extends Command {
@Override @Override
public boolean executeInSequence() { public boolean executeInSequence() {
// TODO Auto-generated method stub
return false; return false;
} }

View File

@ -57,7 +57,6 @@ public class ConfigureStaticNatRulesOnLogicalRouterCommand extends Command {
*/ */
@Override @Override
public boolean executeInSequence() { public boolean executeInSequence() {
// TODO Auto-generated method stub
return false; return false;
} }

View File

@ -268,10 +268,7 @@ public class NiciraNvpElement extends AdapterBase implements
+ network.getId()); + network.getId());
} }
try { try {
// FIXME Check if any services other than connectiviy are required // Implement SourceNat immediately as we have al the info already
// If that is the case start the logical router with only the
// internal interface, leave the external interfaces to the
// IpDeployer
if (_networkManager.isProviderSupportServiceInNetwork( if (_networkManager.isProviderSupportServiceInNetwork(
network.getId(), Service.SourceNat, Provider.NiciraNvp)) { network.getId(), Service.SourceNat, Provider.NiciraNvp)) {
s_logger.debug("Apparently we are supposed to provide SourceNat on this network"); s_logger.debug("Apparently we are supposed to provide SourceNat on this network");