apache/cloudstack
1
0
Fork 0
mirror of https://github.com/apache/cloudstack.git synced 2025-10-26 08:42:29 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge release branch 4.19 to 4.20

Browse Source 
* 4.19:
  Restrict the migration of volumes attached to VMs in Starting state (#9725)
This commit is contained in:
Daan Hoogland 2025-01-08 13:23:42 +01:00
commit 4f9c3492ec
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
View File

@ -3268,6 +3268,7 @@ public class VolumeApiServiceImpl extends ManagerBase implements VolumeApiServic
VMInstanceVO vm = null; VMInstanceVO vm = null;
if (instanceId != null) { if (instanceId != null) {
vm = _vmInstanceDao.findById(instanceId); vm = _vmInstanceDao.findById(instanceId);
checkVmStateForMigration(vm, vol);
} }
// Check that Vm to which this volume is attached does not have VM Snapshots // Check that Vm to which this volume is attached does not have VM Snapshots
@ -3465,6 +3466,22 @@ public class VolumeApiServiceImpl extends ManagerBase implements VolumeApiServic
return orchestrateMigrateVolume(vol, destPool, liveMigrateVolume, newDiskOffering); return orchestrateMigrateVolume(vol, destPool, liveMigrateVolume, newDiskOffering);
} }
private void checkVmStateForMigration(VMInstanceVO vm, VolumeVO vol) {
List<State> suitableVmStatesForMigration = List.of(State.Stopped, State.Running, State.Shutdown);
if (!suitableVmStatesForMigration.contains(vm.getState())) {
s_logger.debug(String.format(
"Unable to migrate volume: [%s] Id: [%s] because the VM: [%s] Id: [%s] is in state [%s], which is not supported for migration.",
vol.getName(), vol.getId(), vm.getInstanceName(), vm.getUuid(), vm.getState()
));
throw new CloudRuntimeException(String.format(
"Volume migration is not allowed when the VM is in the %s state. Supported states are: %s.",
vm.getState(), suitableVmStatesForMigration
));
}
}
private boolean isSourceOrDestNotOnStorPool(StoragePoolVO storagePoolVO, StoragePoolVO destinationStoragePoolVo) { private boolean isSourceOrDestNotOnStorPool(StoragePoolVO storagePoolVO, StoragePoolVO destinationStoragePoolVo) {
return storagePoolVO.getPoolType() != Storage.StoragePoolType.StorPool return storagePoolVO.getPoolType() != Storage.StoragePoolType.StorPool
|| destinationStoragePoolVo.getPoolType() != Storage.StoragePoolType.StorPool; || destinationStoragePoolVo.getPoolType() != Storage.StoragePoolType.StorPool;