diff --git a/engine/components-api/src/com/cloud/storage/StorageManager.java b/engine/components-api/src/com/cloud/storage/StorageManager.java index 129f6b1d354..d314fb33bd6 100644 --- a/engine/components-api/src/com/cloud/storage/StorageManager.java +++ b/engine/components-api/src/com/cloud/storage/StorageManager.java @@ -50,6 +50,8 @@ public interface StorageManager extends StorageService { "Determines how long (in seconds) to wait before actually expunging destroyed volumes. The default value = the default value of storage.cleanup.interval.", false, ConfigKey.Scope.Global, null); static final ConfigKey StorageCleanupEnabled = new ConfigKey(Boolean.class, "storage.cleanup.enabled", "Advanced", "true", "Enables/disables the storage cleanup thread.", false, ConfigKey.Scope.Global, null); + static final ConfigKey TemplateCleanupEnabled = new ConfigKey(Boolean.class, "storage.template.cleanup.enabled", "Storage", "true", + "Enable/disable template cleanup activity, only take effect when overall storage cleanup is enabled", false, ConfigKey.Scope.Global, null); /** * Returns a comma separated list of tags for the specified storage pool diff --git a/server/src/com/cloud/configuration/Config.java b/server/src/com/cloud/configuration/Config.java index 97da0348333..fbf97b2efe2 100644 --- a/server/src/com/cloud/configuration/Config.java +++ b/server/src/com/cloud/configuration/Config.java @@ -182,14 +182,6 @@ public enum Config { "3600", "Timeout (in seconds) to synchronize storage pool operations.", null), - StorageTemplateCleanupEnabled( - "Storage", - ManagementServer.class, - Boolean.class, - "storage.template.cleanup.enabled", - "true", - "Enable/disable template cleanup activity, only take effect when overall storage cleanup is enabled", - null), PrimaryStorageDownloadWait( "Storage", TemplateManager.class, diff --git a/server/src/com/cloud/storage/StorageManagerImpl.java b/server/src/com/cloud/storage/StorageManagerImpl.java index a8a38ba74c5..bee2c3ab3d8 100644 --- a/server/src/com/cloud/storage/StorageManagerImpl.java +++ b/server/src/com/cloud/storage/StorageManagerImpl.java @@ -314,7 +314,6 @@ public class StorageManagerImpl extends ManagerBase implements StorageManager, C protected SearchBuilder LocalStorageSearch; ScheduledExecutorService _executor = null; - boolean _templateCleanupEnabled = true; int _storagePoolAcquisitionWaitSeconds = 1800; // 30 minutes int _downloadUrlCleanupInterval; int _downloadUrlExpirationInterval; @@ -477,11 +476,8 @@ public class StorageManagerImpl extends ManagerBase implements StorageManager, C _agentMgr.registerForHostEvents(new StoragePoolMonitor(this, _storagePoolDao, _dataStoreProviderMgr), true, false, true); - String value = _configDao.getValue(Config.StorageTemplateCleanupEnabled.key()); - _templateCleanupEnabled = (value == null ? true : Boolean.parseBoolean(value)); - s_logger.info("Storage cleanup enabled: " + StorageCleanupEnabled.value() + ", interval: " + StorageCleanupInterval.value() + ", delay: " + StorageCleanupDelay.value() + - ", template cleanup enabled: " + _templateCleanupEnabled); + ", template cleanup enabled: " + TemplateCleanupEnabled.value()); String cleanupInterval = configs.get("extract.url.cleanup.interval"); _downloadUrlCleanupInterval = NumbersUtil.parseInt(cleanupInterval, 7200); @@ -1065,7 +1061,7 @@ public class StorageManagerImpl extends ManagerBase implements StorageManager, C if (scanLock.lock(3)) { try { // Cleanup primary storage pools - if (_templateCleanupEnabled) { + if (TemplateCleanupEnabled.value()) { List storagePools = _storagePoolDao.listAll(); for (StoragePoolVO pool : storagePools) { try { @@ -2426,7 +2422,7 @@ public class StorageManagerImpl extends ManagerBase implements StorageManager, C @Override public ConfigKey[] getConfigKeys() { - return new ConfigKey[] {StorageCleanupInterval, StorageCleanupDelay, StorageCleanupEnabled}; + return new ConfigKey[] {StorageCleanupInterval, StorageCleanupDelay, StorageCleanupEnabled, TemplateCleanupEnabled}; } @Override