diff --git a/server/src/main/java/com/cloud/api/ApiResponseHelper.java b/server/src/main/java/com/cloud/api/ApiResponseHelper.java index 67a6709d402..c159c5c8d53 100644 --- a/server/src/main/java/com/cloud/api/ApiResponseHelper.java +++ b/server/src/main/java/com/cloud/api/ApiResponseHelper.java @@ -3972,7 +3972,6 @@ public class ApiResponseHelper implements ResponseGenerator { NicResponse response = new NicResponse(); NetworkVO network = _entityMgr.findById(NetworkVO.class, result.getNetworkId()); VMInstanceVO vm = _entityMgr.findById(VMInstanceVO.class, result.getInstanceId()); - UserVmJoinVO userVm = _entityMgr.findById(UserVmJoinVO.class, result.getInstanceId()); List nicExtraDhcpOptionVOs = _nicExtraDhcpOptionDao.listByNicId(result.getId()); // The numbered comments are to keep track of the data returned from here and UserVmJoinDaoImpl.setUserVmResponse() @@ -3986,15 +3985,13 @@ public class ApiResponseHelper implements ResponseGenerator { response.setVmId(vm.getUuid()); } - if (userVm != null){ - if (userVm.getTrafficType() != null) { - /*4: trafficType*/ - response.setTrafficType(userVm.getTrafficType().toString()); - } - if (userVm.getGuestType() != null) { - /*5: guestType*/ - response.setType(userVm.getGuestType().toString()); - } + if (network.getTrafficType() != null) { + /*4: trafficType*/ + response.setTrafficType(network.getTrafficType().toString()); + } + if (network.getGuestType() != null) { + /*5: guestType*/ + response.setType(network.getGuestType().toString()); } /*6: ipAddress*/ response.setIpaddress(result.getIPv4Address()); @@ -4003,9 +4000,7 @@ public class ApiResponseHelper implements ResponseGenerator { /*8: netmask*/ response.setNetmask(result.getIPv4Netmask()); /*9: networkName*/ - if(userVm != null && userVm.getNetworkName() != null) { - response.setNetworkName(userVm.getNetworkName()); - } + response.setNetworkName(network.getName()); /*10: macAddress*/ response.setMacAddress(result.getMacAddress()); /*11: IPv6Address*/ diff --git a/test/integration/smoke/test_vm_life_cycle.py b/test/integration/smoke/test_vm_life_cycle.py index 08668e47b72..d9dea1c3006 100644 --- a/test/integration/smoke/test_vm_life_cycle.py +++ b/test/integration/smoke/test_vm_life_cycle.py @@ -1329,7 +1329,7 @@ class TestMigrateVMwithVolume(cloudstackTestCase): Volume.migrate(self.apiclient, storageid=target_pool.id, volumeid=volume1.id) - vol = Volume.list(self.apiclient, volume=volume1.id)[0] + vol = Volume.list(self.apiclient, id=volume1.id)[0] self.assertEqual(vol.storageid, target_pool.id, "Storage pool was not the same as expected")