From 396a13dd0b6483eb7a5715dc8efe04eada18b53b Mon Sep 17 00:00:00 2001 From: Koushik Das Date: Mon, 15 Jul 2013 15:20:28 +0530 Subject: [PATCH] CLOUDSTACK-3445: Observing the system alerts "unallocated Local Storage is low in cluster" when Primary storage is Local Storage Available bytes was getting stored in the used bytes property of local storage pools. As a result of this, for newly added local pools Cloudstack thinks that there is no space available and generated alerts. --- .../apache/cloudstack/storage/datastore/db/StoragePoolVO.java | 4 ++-- .../storage/volume/datastore/PrimaryDataStoreHelper.java | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/engine/api/src/org/apache/cloudstack/storage/datastore/db/StoragePoolVO.java b/engine/api/src/org/apache/cloudstack/storage/datastore/db/StoragePoolVO.java index a8c1e7feb49..941b952baaa 100644 --- a/engine/api/src/org/apache/cloudstack/storage/datastore/db/StoragePoolVO.java +++ b/engine/api/src/org/apache/cloudstack/storage/datastore/db/StoragePoolVO.java @@ -203,8 +203,8 @@ public class StoragePoolVO implements StoragePool { return capacityBytes; } - public void setUsedBytes(long available) { - usedBytes = available; + public void setUsedBytes(long usedBytes) { + this.usedBytes = usedBytes; } public void setCapacityBytes(long capacityBytes) { diff --git a/engine/storage/src/org/apache/cloudstack/storage/volume/datastore/PrimaryDataStoreHelper.java b/engine/storage/src/org/apache/cloudstack/storage/volume/datastore/PrimaryDataStoreHelper.java index 53ead0b99f5..4ea4ceec555 100644 --- a/engine/storage/src/org/apache/cloudstack/storage/volume/datastore/PrimaryDataStoreHelper.java +++ b/engine/storage/src/org/apache/cloudstack/storage/volume/datastore/PrimaryDataStoreHelper.java @@ -113,7 +113,7 @@ public class PrimaryDataStoreHelper { StoragePoolVO pool = this.dataStoreDao.findById(store.getId()); pool.setScope(scope.getScopeType()); - pool.setUsedBytes(existingInfo.getAvailableBytes()); + pool.setUsedBytes(existingInfo.getCapacityBytes() - existingInfo.getAvailableBytes()); pool.setCapacityBytes(existingInfo.getCapacityBytes()); pool.setStatus(StoragePoolStatus.Up); this.dataStoreDao.update(pool.getId(), pool);