diff --git a/build/build-cloud.xml b/build/build-cloud.xml index 5eabf8c3a5d..2b66801ba00 100755 --- a/build/build-cloud.xml +++ b/build/build-cloud.xml @@ -479,7 +479,7 @@ - + @@ -586,7 +586,7 @@ - + @@ -616,4 +616,10 @@ + + + + + + diff --git a/client/tomcatconf/components.xml.in b/client/tomcatconf/components.xml.in index 884e9545534..58541a59606 100755 --- a/client/tomcatconf/components.xml.in +++ b/client/tomcatconf/components.xml.in @@ -160,6 +160,7 @@ + diff --git a/plugins/network-elements/f5/src/com/cloud/api/AddExternalLoadBalancerCmd.java b/plugins/network-elements/f5/src/com/cloud/api/commands/AddExternalLoadBalancerCmd.java similarity index 100% rename from plugins/network-elements/f5/src/com/cloud/api/AddExternalLoadBalancerCmd.java rename to plugins/network-elements/f5/src/com/cloud/api/commands/AddExternalLoadBalancerCmd.java diff --git a/plugins/network-elements/f5/src/com/cloud/api/DeleteExternalLoadBalancerCmd.java b/plugins/network-elements/f5/src/com/cloud/api/commands/DeleteExternalLoadBalancerCmd.java similarity index 100% rename from plugins/network-elements/f5/src/com/cloud/api/DeleteExternalLoadBalancerCmd.java rename to plugins/network-elements/f5/src/com/cloud/api/commands/DeleteExternalLoadBalancerCmd.java diff --git a/plugins/network-elements/f5/src/com/cloud/api/ListExternalLoadBalancersCmd.java b/plugins/network-elements/f5/src/com/cloud/api/commands/ListExternalLoadBalancersCmd.java similarity index 100% rename from plugins/network-elements/f5/src/com/cloud/api/ListExternalLoadBalancersCmd.java rename to plugins/network-elements/f5/src/com/cloud/api/commands/ListExternalLoadBalancersCmd.java diff --git a/plugins/network-elements/juniper-srx/.classpath b/plugins/network-elements/juniper-srx/.classpath new file mode 100644 index 00000000000..a3f5d12a4c8 --- /dev/null +++ b/plugins/network-elements/juniper-srx/.classpath @@ -0,0 +1,11 @@ + + + + + + + + + + + diff --git a/plugins/network-elements/juniper-srx/.project b/plugins/network-elements/juniper-srx/.project new file mode 100644 index 00000000000..393b575fdff --- /dev/null +++ b/plugins/network-elements/juniper-srx/.project @@ -0,0 +1,17 @@ + + + srx + + + + + + org.eclipse.jdt.core.javabuilder + + + + + + org.eclipse.jdt.core.javanature + + diff --git a/plugins/network-elements/juniper-srx/build.xml b/plugins/network-elements/juniper-srx/build.xml new file mode 100755 index 00000000000..7b8138a2ee2 --- /dev/null +++ b/plugins/network-elements/juniper-srx/build.xml @@ -0,0 +1,129 @@ + + + + + + + Cloud Stack ant build file + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/server/src/com/cloud/api/commands/AddExternalFirewallCmd.java b/plugins/network-elements/juniper-srx/src/com/cloud/api/commands/AddExternalFirewallCmd.java similarity index 100% rename from server/src/com/cloud/api/commands/AddExternalFirewallCmd.java rename to plugins/network-elements/juniper-srx/src/com/cloud/api/commands/AddExternalFirewallCmd.java diff --git a/server/src/com/cloud/api/commands/AddSrxFirewallCmd.java b/plugins/network-elements/juniper-srx/src/com/cloud/api/commands/AddSrxFirewallCmd.java similarity index 100% rename from server/src/com/cloud/api/commands/AddSrxFirewallCmd.java rename to plugins/network-elements/juniper-srx/src/com/cloud/api/commands/AddSrxFirewallCmd.java diff --git a/server/src/com/cloud/api/commands/ConfigureSrxFirewallCmd.java b/plugins/network-elements/juniper-srx/src/com/cloud/api/commands/ConfigureSrxFirewallCmd.java similarity index 100% rename from server/src/com/cloud/api/commands/ConfigureSrxFirewallCmd.java rename to plugins/network-elements/juniper-srx/src/com/cloud/api/commands/ConfigureSrxFirewallCmd.java diff --git a/server/src/com/cloud/api/commands/DeleteExternalFirewallCmd.java b/plugins/network-elements/juniper-srx/src/com/cloud/api/commands/DeleteExternalFirewallCmd.java similarity index 100% rename from server/src/com/cloud/api/commands/DeleteExternalFirewallCmd.java rename to plugins/network-elements/juniper-srx/src/com/cloud/api/commands/DeleteExternalFirewallCmd.java diff --git a/server/src/com/cloud/api/commands/DeleteSrxFirewallCmd.java b/plugins/network-elements/juniper-srx/src/com/cloud/api/commands/DeleteSrxFirewallCmd.java similarity index 100% rename from server/src/com/cloud/api/commands/DeleteSrxFirewallCmd.java rename to plugins/network-elements/juniper-srx/src/com/cloud/api/commands/DeleteSrxFirewallCmd.java diff --git a/server/src/com/cloud/api/commands/ListExternalFirewallsCmd.java b/plugins/network-elements/juniper-srx/src/com/cloud/api/commands/ListExternalFirewallsCmd.java similarity index 100% rename from server/src/com/cloud/api/commands/ListExternalFirewallsCmd.java rename to plugins/network-elements/juniper-srx/src/com/cloud/api/commands/ListExternalFirewallsCmd.java diff --git a/server/src/com/cloud/api/commands/ListSrxFirewallNetworksCmd.java b/plugins/network-elements/juniper-srx/src/com/cloud/api/commands/ListSrxFirewallNetworksCmd.java similarity index 100% rename from server/src/com/cloud/api/commands/ListSrxFirewallNetworksCmd.java rename to plugins/network-elements/juniper-srx/src/com/cloud/api/commands/ListSrxFirewallNetworksCmd.java diff --git a/server/src/com/cloud/api/commands/ListSrxFirewallsCmd.java b/plugins/network-elements/juniper-srx/src/com/cloud/api/commands/ListSrxFirewallsCmd.java similarity index 100% rename from server/src/com/cloud/api/commands/ListSrxFirewallsCmd.java rename to plugins/network-elements/juniper-srx/src/com/cloud/api/commands/ListSrxFirewallsCmd.java diff --git a/api/src/com/cloud/api/response/SrxFirewallResponse.java b/plugins/network-elements/juniper-srx/src/com/cloud/api/response/SrxFirewallResponse.java similarity index 100% rename from api/src/com/cloud/api/response/SrxFirewallResponse.java rename to plugins/network-elements/juniper-srx/src/com/cloud/api/response/SrxFirewallResponse.java diff --git a/server/src/com/cloud/network/element/JuniperSRXExternalFirewallElement.java b/plugins/network-elements/juniper-srx/src/com/cloud/network/element/JuniperSRXExternalFirewallElement.java similarity index 100% rename from server/src/com/cloud/network/element/JuniperSRXExternalFirewallElement.java rename to plugins/network-elements/juniper-srx/src/com/cloud/network/element/JuniperSRXExternalFirewallElement.java diff --git a/server/src/com/cloud/network/element/JuniperSRXFirewallElementService.java b/plugins/network-elements/juniper-srx/src/com/cloud/network/element/JuniperSRXFirewallElementService.java similarity index 100% rename from server/src/com/cloud/network/element/JuniperSRXFirewallElementService.java rename to plugins/network-elements/juniper-srx/src/com/cloud/network/element/JuniperSRXFirewallElementService.java diff --git a/core/src/com/cloud/network/resource/JuniperSrxResource.java b/plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java similarity index 100% rename from core/src/com/cloud/network/resource/JuniperSrxResource.java rename to plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java diff --git a/server/src/com/cloud/configuration/DefaultComponentLibrary.java b/server/src/com/cloud/configuration/DefaultComponentLibrary.java index 97cb6aa1410..3bfe84df25d 100755 --- a/server/src/com/cloud/configuration/DefaultComponentLibrary.java +++ b/server/src/com/cloud/configuration/DefaultComponentLibrary.java @@ -96,8 +96,6 @@ import com.cloud.network.dao.VirtualRouterProviderDaoImpl; import com.cloud.network.dao.VpnUserDaoImpl; import com.cloud.network.element.CiscoNexusVSMElement; import com.cloud.network.element.CiscoNexusVSMElementService; -import com.cloud.network.element.JuniperSRXExternalFirewallElement; -import com.cloud.network.element.JuniperSRXFirewallElementService; import com.cloud.network.element.VirtualRouterElement; import com.cloud.network.element.VirtualRouterElementService; import com.cloud.network.firewall.FirewallManagerImpl; @@ -414,7 +412,6 @@ public class DefaultComponentLibrary extends ComponentLibraryBase implements Com protected void populateServices() { addService("VirtualRouterElementService", VirtualRouterElementService.class, VirtualRouterElement.class); - addService("JuniperSRXFirewallElementService", JuniperSRXFirewallElementService.class, JuniperSRXExternalFirewallElement.class); addService("CiscoNexusVSMElementService", CiscoNexusVSMElementService.class, CiscoNexusVSMElement.class); } diff --git a/server/src/com/cloud/network/ExternalNetworkDeviceManagerImpl.java b/server/src/com/cloud/network/ExternalNetworkDeviceManagerImpl.java index 640b216d9ad..cae7e91c298 100755 --- a/server/src/com/cloud/network/ExternalNetworkDeviceManagerImpl.java +++ b/server/src/com/cloud/network/ExternalNetworkDeviceManagerImpl.java @@ -54,8 +54,6 @@ import com.cloud.network.dao.NetworkExternalLoadBalancerDao; import com.cloud.network.dao.PhysicalNetworkDao; import com.cloud.network.dao.PhysicalNetworkServiceProviderDao; import com.cloud.network.dao.VpnUserDao; -import com.cloud.network.element.JuniperSRXFirewallElementService; -import com.cloud.network.resource.JuniperSrxResource; import com.cloud.network.rules.dao.PortForwardingRulesDao; import com.cloud.offerings.dao.NetworkOfferingDao; import com.cloud.resource.ServerResource; @@ -102,8 +100,6 @@ public class ExternalNetworkDeviceManagerImpl implements ExternalNetworkDeviceMa @Inject NetworkExternalLoadBalancerDao _networkExternalLBDao; @Inject NetworkExternalFirewallDao _networkExternalFirewallDao; - @PlugService JuniperSRXFirewallElementService _srxElementService; - ScheduledExecutorService _executor; int _externalNetworkStatsInterval; private final static IdentityService _identityService = (IdentityService)ComponentLocator.getLocator(ManagementServer.Name).getManager(IdentityService.class); @@ -169,18 +165,6 @@ public class ExternalNetworkDeviceManagerImpl implements ExternalNetworkDeviceMa PxeServerProfile profile = new PxeServerProfile(zoneId, podId, url, username, password, type, pingStorageServerIp, pingDir, tftpDir, pingCifsUsername, pingCifsPassword); return _pxeMgr.addPxeServer(profile); - } else if (cmd.getDeviceType().equalsIgnoreCase(NetworkDevice.JuniperSRXFirewall.getName())) { - Long physicalNetworkId = (params.get(ApiConstants.PHYSICAL_NETWORK_ID)==null)?Long.parseLong((String)params.get(ApiConstants.PHYSICAL_NETWORK_ID)):null; - String url = (String) params.get(ApiConstants.URL); - String username = (String) params.get(ApiConstants.USERNAME); - String password = (String) params.get(ApiConstants.PASSWORD); - ExternalFirewallDeviceManager fwDeviceManager = (ExternalFirewallDeviceManager) _srxElementService; - ExternalFirewallDeviceVO fwDeviceVO = fwDeviceManager.addExternalFirewall(physicalNetworkId, url, username, password, NetworkDevice.JuniperSRXFirewall.getName(),new JuniperSrxResource()); - if (fwDeviceVO != null) { - return _hostDao.findById(fwDeviceVO.getHostId()); - } else { - throw new CloudRuntimeException("Failed to add SRX firewall device due to internal error"); - } } else { throw new CloudRuntimeException("Unsupported network device type:" + cmd.getDeviceType()); } @@ -213,8 +197,6 @@ public class ExternalNetworkDeviceManagerImpl implements ExternalNetworkDeviceMa } else { throw new CloudRuntimeException("Unsupported PXE server type:" + pxeType); } - } else if (host.getType() == Host.Type.ExternalFirewall) { - response = _srxElementService.createExternalFirewallResponse(host); } else { throw new CloudRuntimeException("Unsupported network device type:" + host.getType()); } @@ -259,11 +241,6 @@ public class ExternalNetworkDeviceManagerImpl implements ExternalNetworkDeviceMa Long zoneId = Long.parseLong((String) params.get(ApiConstants.ZONE_ID)); Long podId = Long.parseLong((String)params.get(ApiConstants.POD_ID)); res = listNetworkDevice(zoneId, null, podId, Host.Type.PxeServer); - } else if (NetworkDevice.JuniperSRXFirewall.getName().equalsIgnoreCase(cmd.getDeviceType())) { - Long zoneId = Long.parseLong((String) params.get(ApiConstants.ZONE_ID)); - Long physicalNetworkId = (params.get(ApiConstants.PHYSICAL_NETWORK_ID)==null)?Long.parseLong((String)params.get(ApiConstants.PHYSICAL_NETWORK_ID)):null; - ExternalFirewallDeviceManager fwDeviceManager = (ExternalFirewallDeviceManager) _srxElementService; - return fwDeviceManager.listExternalFirewalls(physicalNetworkId, NetworkDevice.JuniperSRXFirewall.getName()); } else if (cmd.getDeviceType() == null){ Long zoneId = Long.parseLong((String) params.get(ApiConstants.ZONE_ID)); Long podId = Long.parseLong((String)params.get(ApiConstants.POD_ID)); @@ -288,10 +265,6 @@ public class ExternalNetworkDeviceManagerImpl implements ExternalNetworkDeviceMa @Override public boolean deleteNetworkDevice(DeleteNetworkDeviceCmd cmd) { HostVO device = _hostDao.findById(cmd.getId()); - if (device.getType() == Type.ExternalFirewall) { - ExternalFirewallDeviceManager fwDeviceManager = (ExternalFirewallDeviceManager) _srxElementService; - return fwDeviceManager.deleteExternalFirewall(cmd.getId()); - } return true; } }