From 381f737e64ed9192e6eea4aeffe1920637f7d835 Mon Sep 17 00:00:00 2001 From: John Kinsella Date: Wed, 13 Mar 2013 16:52:49 -0700 Subject: [PATCH] Summary: Fix exception handling in security_group.py Detail: Code was attempting to concatinate an exception to a string. Updated to convert to text and concatinate that. BUG-ID: CLOUDSTACK-1052 Bugfix-for: master Reported-by: Noa Resare Signed-off-by: John Kinsella 1363218769 -0700 --- scripts/vm/network/security_group.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/scripts/vm/network/security_group.py b/scripts/vm/network/security_group.py index ed4180a508e..50a164105bb 100755 --- a/scripts/vm/network/security_group.py +++ b/scripts/vm/network/security_group.py @@ -25,6 +25,8 @@ import os import xml.dom.minidom from optparse import OptionParser, OptionGroup, OptParseError, BadOptionError, OptionError, OptionConflictError, OptionValueError import re +import traceback + iptables = Command("iptables") bash = Command("/bin/bash") virsh = Command("virsh") @@ -692,7 +694,8 @@ def add_network_rules(vm_name, vm_id, vm_ip, signature, seqno, vmMac, rules, vif return 'true' except: - logging.debug("Failed to network rule !: " + sys.exc_type) + exceptionText = traceback.format_exc() + logging.debug("Failed to network rule !: " + exceptionText) def getVifs(vmName): vifs = []